Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp851781imu; Wed, 28 Nov 2018 00:07:23 -0800 (PST) X-Google-Smtp-Source: AJdET5drvNhsMTv8jo8lTMTT2ayNl3VuxuXbQOvaeEjJXg5BlgCe73Ky8qs7xaGNg29kUnv+Pccg X-Received: by 2002:a62:c583:: with SMTP id j125mr36909860pfg.37.1543392443509; Wed, 28 Nov 2018 00:07:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543392443; cv=none; d=google.com; s=arc-20160816; b=rZ96rIz8GmM/qiwfL4D3+VWgUy7fhPmy+ZmObpU/j8YSrytMERSnlmteVdCfM8hUs+ HW7j9r/2zR9H1akVYj7pk9a4ZjatF7LsJKpTizQwuvcXUnbo5ApRPTww2AHHAvMd2n/v 4RydqE02pV6uJOh5gFKxQXxuOUSB3e2wFjIaIrkYrm/5zLYX/zJDlfOaiJnVCwaiIaTv BZ74IvBf35ci/Qq54NPSQLz1OUlmpFbpHRItoXYUWWxFnPQaI4ovMwVW8Q+kGkrmQ2J3 S62CptQU9afOqZxbn7ooAp+2dGpDL6ocSc6od9O7B5Kp8sbtLOVFl1cnjugNbEHss5mm Wk9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=/rHuzJ5esLSB7W9v7jQPPskXs31vN5JWHcnwaktcfAI=; b=vvnF0qIsmnqE+sOR+VVOSMIrU4mngXi14Ud4duwXRGf02CBQbhz9DqU2pQJ7bdbliC Pv3uRG1dxpcid3xtrMsIkgBC/IM8bSnP6g+6rZm27tX2SfsnuH18JWpSFnzSNurE4hJr Umez7RA/FJ+k8jkwquNVkFVqCB2gheJm/JGnGdWd+Czj6Rc22IeNfgR/4cMwJn2IG9Eg VftVn2M7KdS192ZL36h7YVo1ANyDr5sJ8e7mMqUDpyCedomnU37sHQy2GEMTQi2lXyjv Jh4/Gzv/fufd00Pd0c95NJ4Bs1in3cQl68qoa29Xiaoi1HZ/N259gXgGd556bJVlYK6v bspg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 144si6217524pga.322.2018.11.28.00.07.08; Wed, 28 Nov 2018 00:07:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727788AbeK1TGz (ORCPT + 99 others); Wed, 28 Nov 2018 14:06:55 -0500 Received: from mxhk.zte.com.cn ([63.217.80.70]:21396 "EHLO mxhk.zte.com.cn" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727484AbeK1TGz (ORCPT ); Wed, 28 Nov 2018 14:06:55 -0500 Received: from mse01.zte.com.cn (unknown [10.30.3.20]) by Forcepoint Email with ESMTPS id BE33EA9FA9DC72687B50; Wed, 28 Nov 2018 16:06:08 +0800 (CST) Received: from notes_smtp.zte.com.cn ([10.30.1.239]) by mse01.zte.com.cn with ESMTP id wAS85uAt074619; Wed, 28 Nov 2018 16:05:56 +0800 (GMT-8) (envelope-from wen.yang99@zte.com.cn) Received: from LIN-A6CB96A0603.zte.intra ([10.90.106.118]) by szsmtp06.zte.com.cn (Lotus Domino Release 8.5.3FP6) with ESMTP id 2018112816061913-13470182 ; Wed, 28 Nov 2018 16:06:19 +0800 From: Wen Yang To: kashyap.desai@broadcom.com, sumit.saxena@broadcom.com, shivasharan.srikanteshwara@broadcom.com Cc: linux-kernel@vger.kernel.org, zhong.weidong@zte.com.cn, Wen Yang , Julia Lawall Subject: [PATCH] scsi: megaraid_sas: NULL check before some freeing functions is not needed Date: Wed, 28 Nov 2018 16:05:53 +0800 Message-Id: <20181128080553.37658-1-wen.yang99@zte.com.cn> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 X-MIMETrack: Itemize by SMTP Server on SZSMTP06/server/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2018-11-28 16:06:19, Serialize by Router on notes_smtp/zte_ltd(Release 9.0.1FP7|August 17, 2016) at 2018-11-28 16:05:48 Content-Transfer-Encoding: quoted-printable X-MAIL: mse01.zte.com.cn wAS85uAt074619 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org dma=5Fpool=5Fdestroy(NULL) is safe, so removes NULL check before freeing the mem. This patch also fix the ifnullfree.cocci warnings. Signed-off-by: Wen Yang CC: Julia Lawall CC: Kashyap Desai CC: Sumit Saxena CC: Shivasharan S CC: linux-kernel@vger.kernel.org --- drivers/scsi/megaraid/megaraid=5Fsas=5Ffusion.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid=5Fsas=5Ffusion.c b/drivers/scsi= /megaraid/megaraid=5Fsas=5Ffusion.c index f74b5ea24f0f..aa477f09a7a5 100644 --- a/drivers/scsi/megaraid/megaraid=5Fsas=5Ffusion.c +++ b/drivers/scsi/megaraid/megaraid=5Fsas=5Ffusion.c @@ -807,10 +807,8 @@ megasas=5Ffree=5Frdpq=5Ffusion(struct megasas=5Finstan= ce *instance) { =20 } =20 - if (fusion->reply=5Fframes=5Fdesc=5Fpool) - dma=5Fpool=5Fdestroy(fusion->reply=5Fframes=5Fdesc=5Fpool); - if (fusion->reply=5Fframes=5Fdesc=5Fpool=5Falign) - dma=5Fpool=5Fdestroy(fusion->reply=5Fframes=5Fdesc=5Fpool=5Falign); + dma=5Fpool=5Fdestroy(fusion->reply=5Fframes=5Fdesc=5Fpool); + dma=5Fpool=5Fdestroy(fusion->reply=5Fframes=5Fdesc=5Fpool=5Falign); =20 if (fusion->rdpq=5Fvirt) dma=5Ffree=5Fcoherent(&instance->pdev->dev, @@ -830,8 +828,7 @@ megasas=5Ffree=5Freply=5Ffusion(struct megasas=5Finstan= ce *instance) { fusion->reply=5Fframes=5Fdesc[0], fusion->reply=5Fframes=5Fdesc=5Fphys[0]); =20 - if (fusion->reply=5Fframes=5Fdesc=5Fpool) - dma=5Fpool=5Fdestroy(fusion->reply=5Fframes=5Fdesc=5Fpool); + dma=5Fpool=5Fdestroy(fusion->reply=5Fframes=5Fdesc=5Fpool); =20 } =20 @@ -1627,8 +1624,7 @@ static inline void megasas=5Ffree=5Fioc=5Finit=5Fcmd(= struct megasas=5Finstance *instance) fusion->ioc=5Finit=5Fcmd->frame, fusion->ioc=5Finit=5Fcmd->frame=5Fphys=5Faddr); =20 - if (fusion->ioc=5Finit=5Fcmd) - kfree(fusion->ioc=5Finit=5Fcmd); + kfree(fusion->ioc=5Finit=5Fcmd); } =20 /** --=20 2.19.1