Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Javier Gonzalez <javier@cnexlabs.com>
To:     Hua Su <suhua.tanke@gmail.com>
CC:     =?utf-8?B?TWF0aWFzIEJqw7hybGluZw==?= <mb@lightnvm.io>,
        Jens Axboe <axboe@kernel.dk>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] lightnvm: pblk: add lock protection to list operations
Thread-Topic: [PATCH] lightnvm: pblk: add lock protection to list operations
Thread-Index: AQHUhvq1/HfKQQNiM0itSqrt33gBL6Vk6A0A
Date:   Wed, 28 Nov 2018 09:16:13 +0000
Message-ID: <930717BD-D32A-4BE2-AEE6-579594E70842@cnexlabs.com>
References: <20181128091352.5088-1-suhua.tanke@gmail.com>
In-Reply-To: <20181128091352.5088-1-suhua.tanke@gmail.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: cnexlabs.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/signed;
        boundary="Apple-Mail=_48022DDD-1627-4BA2-B8C8-416BFE625003";
        protocol="application/pgp-signature";
        micalg=pgp-sha512
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 3dd5f9fe-2d33-4ddf-77eb-08d6551224f3
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Nov 2018 09:16:13.5810
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: e40dfc2e-c6c1-463a-a598-38602b2c3cff
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR06MB4617
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--Apple-Mail=_48022DDD-1627-4BA2-B8C8-416BFE625003
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

> On 28 Nov 2018, at 10.13, Hua Su <suhua.tanke@gmail.com> wrote:
>=20
> Protect the list_add on the pblk_line_init_bb() error
> path in case this code is used for some other purpose
> in the future.
>=20
> Signed-off-by: Hua Su <suhua.tanke@gmail.com>
> ---
> drivers/lightnvm/pblk-core.c | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/lightnvm/pblk-core.c =
b/drivers/lightnvm/pblk-core.c
> index 6944aac43b01..247112e1db94 100644
> --- a/drivers/lightnvm/pblk-core.c
> +++ b/drivers/lightnvm/pblk-core.c
> @@ -1295,15 +1295,22 @@ int pblk_line_recov_alloc(struct pblk *pblk, =
struct pblk_line *line)
>=20
> 	ret =3D pblk_line_alloc_bitmaps(pblk, line);
> 	if (ret)
> -		return ret;
> +		goto fail;
>=20
> 	if (!pblk_line_init_bb(pblk, line, 0)) {
> -		list_add(&line->list, &l_mg->free_list);
> -		return -EINTR;
> +		ret =3D -EINTR;
> +		goto fail;
> 	}
>=20
> 	pblk_rl_free_lines_dec(&pblk->rl, line, true);
> 	return 0;
> +
> +fail:
> +	spin_lock(&l_mg->free_lock);
> +	list_add(&line->list, &l_mg->free_list);
> +	spin_unlock(&l_mg->free_lock);
> +
> +	return ret;
> }
>=20
> void pblk_line_recov_close(struct pblk *pblk, struct pblk_line *line)
> --
> 2.19.1

Looks good to me.

Reviewed-by: Javier Gonz=C3=A1lez <javier@cnexlabs.com>


--Apple-Mail=_48022DDD-1627-4BA2-B8C8-416BFE625003
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE+ws7Qq+qZPG1bJoyIX4xUKFRnnQFAlv+XNwACgkQIX4xUKFR
nnTftA/+KnAY8ehl8/JvxaKmMVfNjuVSVjcwjV+aDnQ1WrFYBLSmif+sRx304dnL
bAzaA2f0fLW4crIl2bSiWHMFcwjRS5ptRetN2nJfO9z96BENqTOTGR3zsbtWgRgZ
DJqlPM7jxfwfAiEkSXAodfaXw8MJ5gJA3yb0CDAgoN6rkyoWWGVwjE0mTDyZGO3R
wFEeLwYlOjotdLzwHwe9ogMHbOhwyar36qfIInv420sw+GfwekykskMECQ3T/ecA
g8pviK79DYIoR+L5AdEOR68r1QPJ2pV2mBK50PlhSoi2BUWp354HJzkDPu3Mu6cZ
JLCVIHvcU+e7Qh8n7vN2+PrwVczre3L+1zMlITCb/mTLE6rZPCq0uUsf2UDx0sqK
JrTN0fyKtXrqnM7aFvtj+MrwP5gsjzb1V7pVIIorvdDKqWWjG2FpDUZu8rqim/JE
qEQY1TCCMAGuQXZntdylTbMw6FibVGFH3XFvNAOod6HIbCpmpy7pArQAimHGYnu3
NBCpRa1bf+drt03Ghk3Yk9qOUY8w2Ih64Pp2yZpPiDLjjo1wcfmfa32ygdBQgP1+
2JZCvDBNTOq5eBkbUllWlR9Mm72lKZ6vN13L0oJUHcgjiYG+uqCNNWmCvqRTSdsv
NYcP530SudZgrBKD5rc1SZfZ2sqjeGEBuXmIh5r9xsbS9B8bWSM=
=yiVx
-----END PGP SIGNATURE-----

--Apple-Mail=_48022DDD-1627-4BA2-B8C8-416BFE625003--