Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp927755imu; Wed, 28 Nov 2018 01:40:07 -0800 (PST) X-Google-Smtp-Source: AFSGD/VJZ2jQWPsLiOq2GbjyLWyt+RlkeBfx1k2MCVOVypBXc3Ls/C4fV5ukVV/lI9ovr91Ofljk X-Received: by 2002:a63:9306:: with SMTP id b6mr31287204pge.36.1543398007837; Wed, 28 Nov 2018 01:40:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543398007; cv=none; d=google.com; s=arc-20160816; b=sa+Ifp+3SL9tbqcMf4bT7dvpJJ6FZQMAu1O5iXJOU5l8ZwpJcKjQQInySmqil0P3bD ly4O6aUhjQC1NCnBSa47UDwfcqEdrP72OVyaf1Pe66hMlXvhPMz/REvmf3ldZFVeQRyF 6WiRII6ZdNQvnnXT3IX/FLoZ47Cn28FynBfYlY9Fusu3tuNxG29OnwfWrPqXwhLe97Q1 MqZfJ8LmjtxkYIQm28gkWHKgwNYILeS5VwxIei3qbmrg8luErFf6TiDiaVZxpZbaEVzz oeqbEjY8UZePZalz4UYjrOt1wbxEZgIJVSDHEr8VlU4e3c1+wKAOF5fBu77KEzzYJNZE goMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=SdpF+4mqs+sFcwSgYzOsRMj4vwfjPkY2vZd7cagWk6o=; b=uvhIQyFNuAp5ROeq6NDLwu3rSxJi/CoWRoKwBaB/oLr8GjU/njt8b7fE69oe2fi+Uy Z/XmQ4HNeirZrUNjn1nOEGTub9gbq7ciUgw+384IQtzIxcRqNsxF2oPa8PHqrikMlPIT zJdUEypmHy3lT0SW77JCpSXOlDK+W1ClzXkBbfjaQa++8cq683DEBXm0sM1nSBubk6SV aX9H8Ybkq6rIGnp78tywZcUXsd50EEDDivdn3a464hzy04mxwVS1HXQufWdDC2BIhRU6 qWEtipQl3zJYxBCWCkgDdlc9GEiSbjrkk6mZfL0HiD3qXVpf6vEvypVrY7T/OmYS2wjZ 6Fyg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n18si7451017pfj.30.2018.11.28.01.39.52; Wed, 28 Nov 2018 01:40:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728245AbeK1UkL (ORCPT + 99 others); Wed, 28 Nov 2018 15:40:11 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:59221 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727662AbeK1UkL (ORCPT ); Wed, 28 Nov 2018 15:40:11 -0500 Received: from p4fea46ac.dip0.t-ipconnect.de ([79.234.70.172] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1gRwJE-0002Oc-CW; Wed, 28 Nov 2018 10:39:04 +0100 Date: Wed, 28 Nov 2018 10:39:03 +0100 (CET) From: Thomas Gleixner To: Tim Chen cc: "Lendacky, Thomas" , LKML , "x86@kernel.org" , Peter Zijlstra , Andy Lutomirski , Linus Torvalds , Jiri Kosina , Josh Poimboeuf , Andrea Arcangeli , David Woodhouse , Andi Kleen , Dave Hansen , Casey Schaufler , Asit Mallick , Arjan van de Ven , Jon Masters , Waiman Long , Greg KH , Dave Stewart , Kees Cook Subject: Re: [patch V2 18/28] x86/speculation: Prepare for per task indirect branch speculation control In-Reply-To: Message-ID: References: <20181125183328.318175777@linutronix.de> <20181125185005.176917199@linutronix.de> <7ec59a1a-4caf-24f6-3466-ee1d01594861@amd.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 27 Nov 2018, Tim Chen wrote: > I think it will be cleaner just to fold the msr update into > __speculation_ctrl_update to fix this issue. Yes, that looks nicer and avoids a couple of extra static_cpu_has() evaluations. I'll fold it into the proper places. Thanks, tglx