Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp929727imu; Wed, 28 Nov 2018 01:42:35 -0800 (PST) X-Google-Smtp-Source: AFSGD/U12wL0v7MvBMUyL6t6DaiPjU4G91GEhR59JBLNvs/i7zzFBvDiI1GgZ27tpGVnX+g2TsxN X-Received: by 2002:a62:7652:: with SMTP id r79mr2485722pfc.241.1543398155677; Wed, 28 Nov 2018 01:42:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543398155; cv=none; d=google.com; s=arc-20160816; b=TaMMz6nYhSgG9DQ+eX2KlV4XetE1YDo3C2TDB0UfxrAIk8SmtCqd43schK/u7so672 6ePEavo2AbiWxk6P/Cdlhjag/eBgS1RtyxQW09dGL26nq7Rwzvwa2l+qokHj2hCB2uqQ RqjWEv/DsvRIarzKFoxOC7SsCklDxI34FAJtJGeg7DZzrmX4gHM3W64um1X5N+ZwL6PR Y7f+BbMnVHIIRq4ETky5jV5/ZNdITduIIMnY24JOPjUhR114rW06eyG6toZl/qIrOGlA F9KuAHGOK0LJ6943q8XJf1MdJIQML1pnwRhaEzeYDybIS/u3rCzYCCttfND+HEYmwZA6 lvpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:from:subject; bh=37A4fI9doenmuOliK4N/KmqVN680MWwK6HoCIKz3HIM=; b=MSI1iNEpcBSCRcjPcN0omN0cJttbCmv5NXIh9FxpQ/dIXZhBqT70mfNVVX5NktdbOJ XjOER2YZ1TtUaEMcrCkicyXbhCa5T7JIM2VRfGobapu2vEfKWyWZmct0rio8pnIXSETo RH3NHGs5YAtHZyfqbkdzUzwKB+tMAV0/A/bJqHAg1y+krKsrwsKKjSv0Bvl8YCUugQrl UP/jyaxeqsKCKC3+wp5vT5b5BKdsXAZUvphpkMNt2FxMnGt1zkVnrNktZXarOblBEziB aCcRnzsvuJkTBk5D4kv6YSvtp7dPE1FH9dmFh8qZ+mgJaJsN06BODSBIRcBFXDjTMxoe uCSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=evUOYtI2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c26si6881353pgm.210.2018.11.28.01.42.21; Wed, 28 Nov 2018 01:42:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=evUOYtI2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728226AbeK1Umh (ORCPT + 99 others); Wed, 28 Nov 2018 15:42:37 -0500 Received: from hqemgate14.nvidia.com ([216.228.121.143]:8206 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727541AbeK1Umg (ORCPT ); Wed, 28 Nov 2018 15:42:36 -0500 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 28 Nov 2018 01:41:36 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Wed, 28 Nov 2018 01:41:34 -0800 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Wed, 28 Nov 2018 01:41:34 -0800 Received: from [10.19.225.182] (10.124.1.5) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 28 Nov 2018 09:41:32 +0000 Subject: Re: [PATCH] thermal: tegra: add get_trend ops From: Wei Ni To: Thierry Reding CC: , , , , References: <1542705077-29697-1-git-send-email-wni@nvidia.com> <20181120153833.GB28796@ulmo> Message-ID: <0ff2454d-fc08-ed16-1502-620a726dfca9@nvidia.com> Date: Wed, 28 Nov 2018 17:41:30 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL108.nvidia.com (172.18.146.13) To HQMAIL101.nvidia.com (172.20.187.10) Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1543398096; bh=37A4fI9doenmuOliK4N/KmqVN680MWwK6HoCIKz3HIM=; h=X-PGP-Universal:Subject:From:To:CC:References:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=evUOYtI24RJ2gXfMY5S8wCwx8Yz+UYWtqi7HF681bkZgXJHN/bTSL4vP+cvaq+GND B2Ka7Lyy7itVpD1jbQFLlqOBPS/2UvRoBWVZgUkGgstvQKGsfhBuKlU/42T9sm7UNg /VnC5VS5+vGeWaCDqYHA+OCW0J+2Gw1HOC6U8ZUgr8Qzvqat9dQV+pwDAmJx7/8N1J L5DpX8Ht0yc6lOdS/7ZWQz/D8YDv0SU2lVWj/Aot7NoZsTH16aubAKxV3vLNkRaIfU 3pY9wo7JeCtJVcY5G+c4gOfcXfFUHzO1CXuW1nLi7tj2rNjxUdwdelb9SxYCBHx/wT X5JQ5Y/+tvVtw== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, Does there have any more comments for this patch? Thanks. Wei. On 21/11/2018 2:36 PM, Wei Ni wrote: > > > On 20/11/2018 11:38 PM, Thierry Reding wrote: >> On Tue, Nov 20, 2018 at 05:11:17PM +0800, Wei Ni wrote: >>> Add support for get_trend ops that allows soctherm >>> sensors to be used with the step-wise governor. >>> >>> Signed-off-by: Wei Ni >>> --- >>> drivers/thermal/tegra/soctherm.c | 34 ++++++++++++++++++++++++++++++++++ >>> 1 file changed, 34 insertions(+) >>> >>> diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c >>> index ed28110a3535..d2951fbe2b7c 100644 >>> --- a/drivers/thermal/tegra/soctherm.c >>> +++ b/drivers/thermal/tegra/soctherm.c >>> @@ -488,9 +488,43 @@ static int tegra_thermctl_set_trip_temp(void *data, int trip, int temp) >>> return 0; >>> } >>> >>> +static int tegra_thermctl_get_trend(void *data, int trip, >>> + enum thermal_trend *trend) >>> +{ >>> + struct tegra_thermctl_zone *zone = data; >>> + struct thermal_zone_device *tz = zone->tz; >>> + int trip_temp, temp, last_temp, ret; >>> + >>> + if (!tz) >>> + return -EINVAL; >>> + >>> + ret = tz->ops->get_trip_temp(zone->tz, trip, &trip_temp); >>> + if (ret) >>> + return ret; >>> + >>> + mutex_lock(&tz->lock); >>> + temp = tz->temperature; >>> + last_temp = tz->last_temperature; >>> + mutex_unlock(&tz->lock); >>> + >>> + if (temp > trip_temp) { >>> + if (temp >= last_temp) >>> + *trend = THERMAL_TREND_RAISING; >>> + else >>> + *trend = THERMAL_TREND_STABLE; >>> + } else if (temp < trip_temp) { >>> + *trend = THERMAL_TREND_DROPPING; >>> + } else { >>> + *trend = THERMAL_TREND_STABLE; >>> + } >>> + >>> + return 0; >>> +} >> >> This looks like a reimplementation of the get_tz_trend() helper. Is >> seems like that helper already has everything we need. Perhaps this >> isn't working because of-thermal installs of_thermal_get_trend(), a >> function that returns -EINVAL if the driver doesn't implement the >> ->get_trend() callback. > > 1. The get_tz_trend() helper can work, because it has: > if (tz->emul_temperature || !tz->ops->get_trend || > tz->ops->get_trend(tz, trip, &trend)) { > ... > } > the tz->ops->get_trend is of_thermal_get_trend(). If without special > get_trend(), it will return -EINVAL, so it will implement the if block > to get the "trend". If we have the special get_trend(), then the > of_thermal_get_trend() will return 0, so this helper will not implement > the if block, it will get the "trend" from the special get_trend(). > > 2. There has a little difference between the helper and our special > callback. The tegra_thermctl_get_trend() consider the trip_temp, but the > get_tz_trend() helper didn't. > >> >> Perhaps a better way would be to do something like this in >> thermal_zone_of_add_sensor(): >> >> if (ops->get_trend) >> tzd->ops->get_trend = of_thermal_get_trend; >> >> That's similar to how ->set_trips() and ->set_emul_temp() are set up >> and should make sure that get_tz_trend() will do the right thing for >> all drivers that don't implement a special ->get_trend(). > > As above description, I think the of_thermal_get_trend() already can > handle this case, doesn't need to change. > > Wei. > >> >> Thierry >>