Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp977160imu; Wed, 28 Nov 2018 02:39:27 -0800 (PST) X-Google-Smtp-Source: AFSGD/UO985vbXFlscNSbsfse21i/dmZ6n0qLkh59eF5pJYkU7YbAp4oas27/qtTuzSLivuB09O1 X-Received: by 2002:a65:6392:: with SMTP id h18mr33244322pgv.107.1543401567144; Wed, 28 Nov 2018 02:39:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543401567; cv=none; d=google.com; s=arc-20160816; b=nC3a/GxN585Wmjn6iHMi37lCwLug6SV9sg/R53o35faVuJ2FH6GZWkKT5C2ANJ4JxV LFMFniDKeyS6TUV5V/eK/Xxg8jXqcm3OymIPdtZZgdrvVbDfhbP1vYp7O1q+rbj8wnit XEBBEqikSjMvx1AHo7+p+gcw1KCuBvxTkc8PYoqTYHXhoYrf1f63+HuMhNpdVqZTqfw2 3l+QGGp9lvEgxDuG8ktPDOZR0VTjemw2xsJdKnSBjVZCZMLuoLdtKDdor95EoZjHKRnn wLxcmCi2xXkZ99cMLw4qFF4Q9hGKzaLjo+F1+7Iz17MmXAxcdPh/rV2xH/ZYL9ni3GJi 70Ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:references:in-reply-to:subject:cc:to:from; bh=lv5eiRB7YtdrNe1Ar5qGUaFcCGEOqIoAS6L+99gAlWs=; b=crIagmSeASTxzbUXvusUEXQX/N/KAqWG+rKdqx2+4wwmgKZr/P/84njnBUaPxbEV3x wgSN4gIA6YvdeNn65uRjAP8iI3j8wBmEHQzILXVBZCezfxM/LxH+EHNRhaflmoIsLMLh eQDE4HiLR5YY52CcBqL/ImW7ekPRe2Cy2llRda9OF3PZgzKSyaSBVeN7lmPCFoCmCKz6 PRvAHh+5noGxbDG85BebQGNvdlHDcjLz6V7siBRnoaV5DelKyop7BMuhbPl4uXsV3Kn0 0+ZYwyqhAQxicG1BXk38AINtCObZwMFWGcDfyRpztTf2Ds1NCSyWYqbUDnewkVhtk32K FBLA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i1si6224347pgs.417.2018.11.28.02.39.11; Wed, 28 Nov 2018 02:39:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727858AbeK1ViY (ORCPT + 99 others); Wed, 28 Nov 2018 16:38:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49932 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727673AbeK1ViY (ORCPT ); Wed, 28 Nov 2018 16:38:24 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1A00930B9309; Wed, 28 Nov 2018 10:37:12 +0000 (UTC) Received: from vitty.brq.redhat.com.redhat.com (unknown [10.43.2.155]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 376927A5EF; Wed, 28 Nov 2018 10:37:06 +0000 (UTC) From: Vitaly Kuznetsov To: Nadav Amit Cc: "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , "Michael Kelley \(EOSG\)" , "kvm\@vger.kernel.org" , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , "linux-kernel\@vger.kernel.org" , "x86\@kernel.org" , Roman Kagan Subject: Re: [PATCH v2 1/4] x86/hyper-v: move synic/stimer control structures definitions to hyperv-tlfs.h In-Reply-To: <8A215F49-BB8F-4E93-AC62-EC33B4734F24@gmail.com> References: <20181126154732.23025-1-vkuznets@redhat.com> <20181126154732.23025-2-vkuznets@redhat.com> <20181126200413.GA7852@rkaganb.sw.ru> <87wooyk6na.fsf@vitty.brq.redhat.com> <20181127184835.GA5147@rkaganip.lan> <8A215F49-BB8F-4E93-AC62-EC33B4734F24@gmail.com> Date: Wed, 28 Nov 2018 11:37:04 +0100 Message-ID: <87a7ltjxnz.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Wed, 28 Nov 2018 10:37:12 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Nadav Amit writes: > > On a different note: how come all of the hyper-v structs are not marked > with the “packed" attribute? "packed" should not be needed with proper padding; I vaguely remember someone (from x86@?) arguing _against_ "packed". -- Vitaly