Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1077020imu; Wed, 28 Nov 2018 04:20:57 -0800 (PST) X-Google-Smtp-Source: AFSGD/Vx5KgNQVATXZNYengqDg0SpqeiPjB6SanTViQIl+AwHw2uSAcyVyi6KM/+PwudYG8fmOv5 X-Received: by 2002:a63:6ecf:: with SMTP id j198mr33544386pgc.3.1543407657558; Wed, 28 Nov 2018 04:20:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543407657; cv=none; d=google.com; s=arc-20160816; b=D0uc3M+01HYF154+i/sbvLnexO7NeJ2/2aX6RXG2l2yBDAnNOW+ECwKjQ/ozoXKOME d9NsCX2gkhV8snHGGtSYVIhbOkutFaFgKWsFDZJFWmyVZgRU9/SB3NPendu4M8bl/+kz fYnWaw6MMIIKH4pFoMxxON4OMQ0QftV8QZ6qYZKC6Wr9SRKNnKUKZK6fhH67PsKZ6zLX +874gUaqED9PNx97g0xUzPZr0pXcC/j2803JmrK7bwB3QLs4Yy5fWiThKPQZumHeVlJQ 6l2W5GOqwdr9lfR+isBgFtY1ZE1faSEBvFYYXGRuxnb/fPXsWgKJbFEVcwysdW4yMDUZ dGmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=dNoqpO7uJjK5LHhy4u+aGDeCiPOE4UurPcKF3ENgybo=; b=bkR7fZRLCTPbStwBnMrw0iilm088HjzXrCuCK/fVjiToRc9ahoyjB4DPKjmqa5MbAV Y56Tb3fS58xMKc/qsNpKc6vm3YbOtQE0VQyzpPgOMoFzfRZyPXqkYvR41dcKVPKbiFTg xcIaoU3h9y3s+IiqGjXj2DOqHtGhUHFs0A+TKFlkaPIwNhT+ttq2rITeqBurgnR9yEHd R8ler3pPWTcSzeWPct1GFfP8BBlR6t43bH+VVc6rUYjCevgHgWVEF3mxqbH+UviHeR4S bhYz189gQPL6vxPhRF8f7tLJ4HXP9lIO5wOAFZpPj1vSNO7JULKl80lTdgSi3axVMpNf lUMQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w9si6903756pgg.72.2018.11.28.04.20.41; Wed, 28 Nov 2018 04:20:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728312AbeK1XTt (ORCPT + 99 others); Wed, 28 Nov 2018 18:19:49 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:37608 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727713AbeK1XTt (ORCPT ); Wed, 28 Nov 2018 18:19:49 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 46D053662; Wed, 28 Nov 2018 04:18:21 -0800 (PST) Received: from [10.1.196.75] (e110467-lin.cambridge.arm.com [10.1.196.75]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CD22F3F59C; Wed, 28 Nov 2018 04:18:19 -0800 (PST) Subject: Re: move the arm arch_dma_alloc implementation to common code To: Christoph Hellwig Cc: Will Deacon , iommu@lists.linux-foundation.org, Catalin Marinas , linux-kernel@vger.kernel.org, Guo Ren , Laura Abbott , linux-arm-kernel@lists.infradead.org References: <20181105121931.13481-1-hch@lst.de> <20181109075238.GA27578@lst.de> <20181115195041.GC4535@brain-police> <20181127073715.GA30033@lst.de> From: Robin Murphy Message-ID: <9d31a389-4f8c-a709-b404-e3b3e2623ae9@arm.com> Date: Wed, 28 Nov 2018 12:18:18 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181127073715.GA30033@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/11/2018 07:37, Christoph Hellwig wrote: > On Thu, Nov 15, 2018 at 12:58:04PM -0800, Robin Murphy wrote: >> On 2018-11-15 11:50 am, Will Deacon wrote: >>> On Fri, Nov 09, 2018 at 08:52:38AM +0100, Christoph Hellwig wrote: >>>> Can I get a quick review from the arm64 folks? I think it should >>>> be fine there as it basically is a code move, but an additional pair >>>> or two of eyes always helps to weed out bugs. >>> >>> I reviewed the arm64 parts, but it would be ideal if Robin could have a look >>> as well. >> >> Yup, from a quick skim the general shape of the whole series looks >> pleasing, but I've been holding off going through it in detail until I've >> figured out what's up with the last thing I thought I'd reviewed >> exhaustively... >> >> Either way I'll make some time for a proper look next week once I'm back. > > Did you get a chance to look over this? Sorry, it took a little longer than expected to catch up, but I'm looking at it now. Robin.