From: James Cleverdon <jamesclv@us.ibm.com>
Reply-To: jamesclv@us.ibm.com
Organization: IBM LTC
To: James Bottomley <James.Bottomley@SteelEye.com>
Subject: Re: [PATCH] 2.6.1-mm2: Get irq_vector size right for generic subarch UP installer kernels
Date: Wed, 14 Jan 2004 12:01:43 -0800
User-Agent: KMail/1.5
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
References: <1074108886.11035.59.camel@mulgrave>
In-Reply-To: <1074108886.11035.59.camel@mulgrave>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200401141201.43324.jamesclv@us.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 915
Lines: 27

On Wednesday 14 January 2004 11:34 am, James Bottomley wrote:
> I don't think this:
>
> +# if defined(CONFIG_X86_SUMMIT) || defined(CONFIG_X86_GENERICARCH)
>
> Is a good idea.  You're contaminating the default subarch with another
> subarch specific #define.
>
> generic arch additions are fine here, but you should find a better way
> to abstract the summit stuff.
>
> James

Sorry, but we've had distro installer kernels, which are uni-proc generic 
subarch kernels, blow up with array overflows on large systems.

What would you suggest I do instead?

-- 
James Cleverdon
IBM xSeries Linux Solutions
{jamesclv(Unix, preferred), cleverdj(Notes)} at us dot ibm dot comm
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/