Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 02/41] scsi: NCR5380: Mark expected switch fall-through
To:     Michael Schmitz <schmitzmic@gmail.com>,
        Finn Thain <fthain@telegraphics.com.au>
Cc:     "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
References: <cover.1543374820.git.gustavo@embeddedor.com>
 <8b4ef418aa7803199954100fd89717f38d61ae06.1543374820.git.gustavo@embeddedor.com>
 <0caad885-94ad-9226-fbf1-996b5d465473@gmail.com>
From:   "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Message-ID: <304bd094-7079-3a90-4901-9c86833d49e2@embeddedor.com>
Date:   Wed, 28 Nov 2018 07:47:05 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <0caad885-94ad-9226-fbf1-996b5d465473@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Michael,

On 11/28/18 2:22 AM, Michael Schmitz wrote:

> I believe the 'if we get something weird' comment block relates to the
> default branch of the switch, _not_ the fall through from the case above
> (extended message received that we end up rejecting). Ordering the
> comments like you did just for GCC's sake is misleading.
> 
> The comment block should perhaps be moved after the default label. And
> it would be nice if the reason for the fall through could be retained in
> the comment.
> 

Oh Okay. I'll do that.

Thanks for the feedback.
--
Gustavo