Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 28 Nov 2018 11:03:00 -0500
From:   Luiz Capitulino <lcapitulino@redhat.com>
To:     "Moger, Babu" <Babu.Moger@amd.com>
Cc:     Liran Alon <liran.alon@oracle.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] KVM: VMX: re-add ple_gap module parameter
Message-ID: <20181128110300.49b3110d@doriath>
In-Reply-To: <0a2d9427-18e7-408a-d0ae-b8277cad542a@amd.com>
References: <20181123120214.174457a4@doriath>
        <8049C3CD-E816-4270-A64F-0BB92BD56338@oracle.com>
        <20181123132641.712e2695@doriath>
        <0a2d9427-18e7-408a-d0ae-b8277cad542a@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 28 Nov 2018 15:57:53 +0000
"Moger, Babu" <Babu.Moger@amd.com> wrote:

> My bad.. Sorry about this. I think this should also go to
> stable@vger.kernel.org

No problem man, this happens. Thanks for the review!

> 
> > -----Original Message-----
> > From: Luiz Capitulino <lcapitulino@redhat.com>
> > Sent: Friday, November 23, 2018 12:27 PM
> > To: Liran Alon <liran.alon@oracle.com>
> > Cc: Paolo Bonzini <pbonzini@redhat.com>; Moger, Babu
> > <Babu.Moger@amd.com>; kvm@vger.kernel.org; linux-
> > kernel@vger.kernel.org
> > Subject: Re: [PATCH] KVM: VMX: re-add ple_gap module parameter
> > 
> > On Fri, 23 Nov 2018 19:42:53 +0200
> > Liran Alon <liran.alon@oracle.com> wrote:
> >   
> > > > On 23 Nov 2018, at 19:02, Luiz Capitulino <lcapitulino@redhat.com>  
> > wrote:  
> > > >
> > > >
> > > > Apparently, the ple_gap parameter was accidentally removed
> > > > by commit c8e88717cfc6b36bedea22368d97667446318291. Add it
> > > > back.
> > > >
> > > > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>  
> > >
> > > Weird that nobody noticed this when patch was applied… Thanks.
> > > Reviewed-by: Liran Alon <liran.alon@oracle.com>  
> Reviewed-by: Babu Moger <babu.moger@amd.com>
> 
> > 
> > I forgot to mention that I noticed this because I have systems
> > disabling ple with ple_gap=0 in modprobe.conf. In those systems
> > kvm_intel won't load anymore.
> >   
> > >  
> > > > ---
> > > > arch/x86/kvm/vmx.c | 1 +
> > > > 1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> > > > index 4555077d69ce..be6f13f1c25f 100644
> > > > --- a/arch/x86/kvm/vmx.c
> > > > +++ b/arch/x86/kvm/vmx.c
> > > > @@ -174,6 +174,7 @@ module_param_named(preemption_timer,  
> > enable_preemption_timer, bool, S_IRUGO);  
> > > >  * refer SDM volume 3b section 21.6.13 & 22.1.3.
> > > >  */
> > > > static unsigned int ple_gap = KVM_DEFAULT_PLE_GAP;
> > > > +module_param(ple_gap, uint, 0444);
> > > >
> > > > static unsigned int ple_window = KVM_VMX_DEFAULT_PLE_WINDOW;
> > > > module_param(ple_window, uint, 0444);
> > > > --
> > > > 2.17.2
> > > >  
> > >  
>