Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264286AbUANWX7 (ORCPT ); Wed, 14 Jan 2004 17:23:59 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264351AbUANWX6 (ORCPT ); Wed, 14 Jan 2004 17:23:58 -0500 Received: from palrel13.hp.com ([156.153.255.238]:43737 "EHLO palrel13.hp.com") by vger.kernel.org with ESMTP id S264286AbUANWXf (ORCPT ); Wed, 14 Jan 2004 17:23:35 -0500 From: David Mosberger MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16389.49505.481834.12558@napali.hpl.hp.com> Date: Wed, 14 Jan 2004 14:23:29 -0800 To: Tom Rini Cc: Paul Mackerras , Benjamin Herrenschmidt , Christoph Hellwig , Andrew Morton , Rusty Russell , Kernel Mailing List Subject: Re: [PATCH][RFC] 2.6 && module + -g && kernel w/o -g In-Reply-To: <20040114210937.GA983@stop.crashing.org> References: <20040108003040.GA18481@stop.crashing.org> <20040114210937.GA983@stop.crashing.org> X-Mailer: VM 7.17 under Emacs 21.3.1 Reply-To: davidm@hpl.hp.com X-URL: http://www.hpl.hp.com/personal/David_Mosberger/ Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1562 Lines: 37 >>>>> On Wed, 14 Jan 2004 14:09:37 -0700, Tom Rini said: Tom> The following patch fixes the problem for me on PPC32: Tom> --- 1.96/kernel/module.c Wed Jan 7 22:46:59 2004 Tom> +++ edited/kernel/module.c Wed Jan 14 14:05:12 2004 Tom> @@ -1439,6 +1439,13 @@ Tom> strindex = sechdrs[i].sh_link; Tom> strtab = (char *)hdr + sechdrs[strindex].sh_offset; Tom> } Tom> + Tom> + /* If we find any debug RELAs, frob these away now. */ Tom> + if (sechdrs[i].sh_type == SHT_RELA && Tom> + (strstr(secstrings+sechdrs[i].sh_name, ".debug") Tom> + != 0)) Tom> + sechdrs[i].sh_type = SHT_NULL; Tom> + Tom> #ifndef CONFIG_MODULE_UNLOAD Tom> /* Don't load .exit sections */ Tom> if (strncmp(secstrings+sechdrs[i].sh_name, ".exit", 5) == 0) Tom> IMHO, this shouldn't be covered under a PPC32 test since at Tom> least PPC32, PPC64 and Alpha have this issue, and I suspect Tom> that ia64, parisc, s390 and v850 have the problem as well Tom> (based on what their module_arch_frob bits look to be doing). As far as ia64 is concerned, adding a check for .debug should be OK, but since the debug sections do not have any relocs anyhow, it shouldn't make much of a difference one way or another (addresses in the debug section a segment-relative). --david - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/