Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 28 Nov 2018 15:30:21 -0800
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Minchan Kim <minchan@kernel.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCH v2 6/7] zram: add bd_stat statistics
Message-Id: <20181128153021.3f125ed82df68a29e25ce428@linux-foundation.org>
In-Reply-To: <20181127020754.GB237537@google.com>
References: <20181126082813.81977-1-minchan@kernel.org>
        <20181126082813.81977-7-minchan@kernel.org>
        <20181126125833.e95a21088ae60ccc6fd55022@linux-foundation.org>
        <20181127020754.GB237537@google.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 27 Nov 2018 11:07:54 +0900 Minchan Kim <minchan@kernel.org> wrote:

> On Mon, Nov 26, 2018 at 12:58:33PM -0800, Andrew Morton wrote:
> > On Mon, 26 Nov 2018 17:28:12 +0900 Minchan Kim <minchan@kernel.org> wrote:
> > 
> > > +File /sys/block/zram<id>/bd_stat
> > > +
> > > +The stat file represents device's backing device statistics. It consists of
> > > +a single line of text and contains the following stats separated by whitespace:
> > > + bd_count	size of data written in backing device.
> > > +		Unit: pages
> > > + bd_reads	the number of reads from backing device
> > > +		Unit: pages
> > > + bd_writes	the number of writes to backing device
> > > +		Unit: pages
> > 
> > Using `pages' is a bad choice.  And I assume this means that
> > writeback_limit is in pages as well, which is worse.
> > 
> > Page sizes are not constant!  We want userspace which was developed on
> > 4k pagesize to work the same on 64k pagesize.
> > 
> > Arguably, we could require that well-written userspace remember to use
> > getpagesize().  However we have traditionally tried to avoid that by
> > performing the pagesize normalization within the kernel.
> 
> zram works based on page so I used that term but I agree it's rather
> vague. If there is no objection, I will use (Unit: 4K) instead of
> (Unit: pages).

Is that still true if PAGE_SIZE=64k?