Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 28 Nov 2018 15:41:41 -0800
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Minchan Kim <minchan@kernel.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Joey Pabalinas <joeypabalinas@gmail.com>
Subject: Re: [PATCH v3 7/7] zram: writeback throttle
Message-Id: <20181128154141.d67b70957bc4833d9f0d6635@linux-foundation.org>
In-Reply-To: <20181127055429.251614-8-minchan@kernel.org>
References: <20181127055429.251614-1-minchan@kernel.org>
        <20181127055429.251614-8-minchan@kernel.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 27 Nov 2018 14:54:29 +0900 Minchan Kim <minchan@kernel.org> wrote:

> On small memory system, there are lots of write IO so if we use
> flash device as swap, there would be serious flash wearout.
> To overcome the problem, system developers need to design write
> limitation strategy to guarantee flash health for entire product life.
> 
> This patch creates a new konb "writeback_limit" on zram. With that,
> if current writeback IO count(/sys/block/zramX/io_stat) excceds
> the limitation, zram stops further writeback until admin can reset
> the limit.

I'm not really understanding this.  Does this only refer to suspending
the idle page writeback feature?  Not all zram writeback, surely?

I don't think the documentation gives an administrator sufficient
information to effectively use the feature.  Some additional discussion
would help.  What sort of values should it be set to and why?

And what is the default setting?  And why?

And the limit isn't persistent across reboots which makes me wonder
whether the overall feature is particularly valuable?