Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1860089imu; Wed, 28 Nov 2018 16:50:31 -0800 (PST) X-Google-Smtp-Source: AFSGD/W2t6na/31vbxQ1QmFRHJxWFyrM2I5JcZtfKqPIyXE5D+rGYj2IDJJ5zE8lywzgtooIkuyS X-Received: by 2002:a63:1204:: with SMTP id h4mr35100338pgl.51.1543452631635; Wed, 28 Nov 2018 16:50:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543452631; cv=none; d=google.com; s=arc-20160816; b=rRGjliraHzBzKXuMh+Q9bHtGVWtLLuGT6B9ChEvIl5cTCa5S8yvXd1r9uXmRddB7iq uqyvt9zJJQbK9w9ft8kuotFTceYF3jEkXwx0sxyZmKqEIzfyxUr1SpcKseV/q8/Vvsxn 593pJ0tlyXALnspJZxdvvjLDPUq+yVSVivrwGjxs+eUTbo26ygktl7y9dobAfVb6LdFN CIie3uCrDniwwbZYY37GpgHdudnTjdzKesN483ybBzyLAYKTgYmCg4wiq839JREtUJhV J59uSvUWxbCO2DSockXE9X6sRBoPPh9HQWgFzroZ9hfhxYk7WGiP7YhvMmjA2k/zluEn 86rQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to; bh=+9Ye/essCGnRuPXtxZHkAEH9FUHjB+d+c6fAhpAj6gg=; b=uttJ0go5XmBJbC+l/8zPUN6MdnleWZR/cFRxZQ0nmdZQLL/78a8oRDCG6R6NQr0NWE FblpDzYAndgUt8VtqcgAeSmiAT9VM7ggQRuv9g93Z0F0ioZUohdDWXtXO0wE+kMsTWWH j28x0w0NCmL2omRF5uudLePaocMUFuwj25Dv2WZFoJMXcHk3Kh7HR4SEAu21dSwtrtwn LmavOzEKmPk7idoqVxRNkA0slblDUr/CtoJm5phGu5xkxMhsiD1r2cm2bl+4RahWiq5C zcupjN/RIdM8Iand+4A9840HdJcAO/6sRmkzTvSVbsnpoiHmvVxc7HcKXCixrqnMftj4 gaUg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b14si233956pgj.20.2018.11.28.16.50.16; Wed, 28 Nov 2018 16:50:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726788AbeK2LxL (ORCPT + 99 others); Thu, 29 Nov 2018 06:53:11 -0500 Received: from ale.deltatee.com ([207.54.116.67]:49780 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726492AbeK2LxK (ORCPT ); Thu, 29 Nov 2018 06:53:10 -0500 Received: from guinness.priv.deltatee.com ([172.16.1.162]) by ale.deltatee.com with esmtp (Exim 4.89) (envelope-from ) id 1gSAWR-00073x-My; Wed, 28 Nov 2018 17:49:40 -0700 To: Nadav Amit Cc: Ingo Molnar , Ingo Molnar , Masahiro Yamada , Michal Marek , Thomas Gleixner , Borislav Petkov , "H. Peter Anvin" , X86 ML , Linux Kbuild mailing list , LKML References: <20181112150215.508-1-namit@vmware.com> <20181112150215.508-2-namit@vmware.com> <20181113113000.GB4788@gmail.com> <40E4E1B4-EF5F-43A1-B42C-C4CF6349FC62@vmware.com> <48577A3F-0F76-4CCA-A959-965344D7259F@vmware.com> <7ff5de62-d1df-9a67-1c86-497ce00a4de4@deltatee.com> <7072A2D8-30F8-45CB-AB0C-B1BE4A30259A@vmware.com> <521458D7-A27C-4112-81ED-1974EFE96A76@vmware.com> <5682CCB4-B7D3-4DDC-81BB-2D4DCE968A3D@vmware.com> From: Logan Gunthorpe Message-ID: <336cf7d8-6495-b112-8d3a-c146222fda78@deltatee.com> Date: Wed, 28 Nov 2018 17:49:38 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <5682CCB4-B7D3-4DDC-81BB-2D4DCE968A3D@vmware.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-CA Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, x86@kernel.org, hpa@zytor.com, bp@alien8.de, tglx@linutronix.de, michal.lkml@markovi.net, yamada.masahiro@socionext.com, mingo@redhat.com, mingo@kernel.org, namit@vmware.com X-SA-Exim-Mail-From: logang@deltatee.com X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on ale.deltatee.com X-Spam-Level: X-Spam-Status: No, score=-8.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, GREYLIST_ISWHITE autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [PATCH 1/2] Makefile: Fix distcc compilation with x86 macros X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018-11-28 5:38 p.m., Nadav Amit wrote: > So what’s your take? Would you think this patch is still needed? Should it > only be enabled automatically for distcc and not for distcc-pump? Not sure. The patch will probably slow things down a lot (seeing assembly is always done locally and there are twice as many compile steps) and will create some confusion once it's possible to disable it for the new versions. Maybe hold off and see if anyone else complains? I don't really know how you'd detect whether pump is in use or not and I'm uncertain as to whether any of the auto detection can actually be made to be reliable. Logan