Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <cdd98047d6b8977f49bced95f8fd67f2953f632c.camel@surriel.com>
Subject: Re: [PATCH 01/29] x86/fpu: Use ULL for shift in
 xfeature_uncompacted_offset()
From:   Rik van Riel <riel@surriel.com>
To:     Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        linux-kernel@vger.kernel.org
Cc:     x86@kernel.org, Andy Lutomirski <luto@kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Radim =?UTF-8?Q?Kr=C4=8Dm=C3=A1=C5=99?= <rkrcmar@redhat.com>,
        kvm@vger.kernel.org, "Jason A. Donenfeld" <Jason@zx2c4.com>,
        Dave Hansen <dave.hansen@linux.intel.com>
Date:   Wed, 28 Nov 2018 20:52:21 -0500
In-Reply-To: <20181128222035.2996-2-bigeasy@linutronix.de>
References: <20181128222035.2996-1-bigeasy@linutronix.de>
         <20181128222035.2996-2-bigeasy@linutronix.de>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-9h1MYVYAhemxwlPCV9gs"
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-9h1MYVYAhemxwlPCV9gs
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2018-11-28 at 23:20 +0100, Sebastian Andrzej Siewior wrote:
> The xfeature mask is 64bit so a shift from a number to its mask
> should
> have LL prefix or else nr > 31 will be lost. This is not a problem
> now
> but should XFEATURE_MASK_SUPERVISOR gain a bit >31 then this check
> won't
> catch it.
>=20
> Use BIT_ULL() to compute a mask from a number.
>=20
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

Reviewed-by: Rik van Riel <riel@surriel.com>

--=20
All Rights Reversed.

--=-9h1MYVYAhemxwlPCV9gs
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEKR73pCCtJ5Xj3yADznnekoTE3oMFAlv/RlUACgkQznnekoTE
3oNvoAgArE1oDhD00rBCq+l5WcAoWgNdFAm0dCZyvKRMGxQQ1wR/Cju1lhD24U0j
KtY/p8q+fYSIH5AsTFTpFlJxLJxPv8Zf2xGU+Ktn2vVusED8bHBykDpJZ3Jc2JPB
QCwiPNOBr8hxGBxQoqcAcoVobk5YV+K6D5kFgjpAvNnNu+udKAS4pdxnZeAXuqDE
90MiT3ThqGzyCVvRRnqJTYe9sKGABH5R/U+ricbiDYHKkaFXz5Fd7/KfM/jqKBTP
b1IMS9QJ0s/xwD2nYATE0LOtmoQXfeMJcdRTxKkAQB0jkkCVYr8gfgITFAoTtUHB
DnwfQj9UpEPwhwIStB/oowVLc770zw==
=tgUH
-----END PGP SIGNATURE-----

--=-9h1MYVYAhemxwlPCV9gs--