Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1953764imu; Wed, 28 Nov 2018 18:53:41 -0800 (PST) X-Google-Smtp-Source: AJdET5e8hFx7CvCDqd6txIpNiYYi0FpTzkKmYG+xGClKiO7bnj6wVU9jSS73uCVHLlJ2kOve9nNt X-Received: by 2002:a63:7d06:: with SMTP id y6mr35208655pgc.171.1543460021491; Wed, 28 Nov 2018 18:53:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543460021; cv=none; d=google.com; s=arc-20160816; b=pZaacKUyLQL5i271ojQTxKqciEp4//sc6mhsI3ushIy2BVJGa4EoRB5Y92iYkBAS/W 3gDTe6VZscyzxlTGqkhS+O3zSbJr/6gCtA3wRuvQrStZhowJuF912D8kJAQn/kxtXV84 biM1fELi7CubOJfwbu08IF1tS8wYwiAYVrUDqQOLrKITtpFtltVlzxi+DfAwQowUOxsk C079NZCyTCQqeJp9FemdAgwXzHSeBe8/hvO1X2QUqcAQARPMZsQeXOz0YOmhUJ+Jcphn AZd5boaPxQlYY4xVkh3WJnGoAIUtu3LdGW4wjZodXjDDcfcM5c1WB6nuUGF8G4Epmn3a qMHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=99GSPiKsT1ePaQaJ18PEwVQ2A01zh/1VLhsmFRyeSc8=; b=ryQJ/fGqyX3SHfO0vlgmg0s8U6RubWB6xCNRcci2nqqQoX1ALFAmdOaggvxPctKQpB fjbRMe0kOFzyjJIGGMcygGIwxhrXCpbdZCgULXQ7tRn0WpuRH7ZeuXZv6u3ORMKzwqij Amdm9EfwUVQ2ztUjmB520m4Rbk8Yggg9asZ36cLX1W7hUin0Szpizdq/hHbgHLiiVqoo uDvB4cCv5BpokAaKDxzZcuS3KPRBmC7egOPKq8m8xkbMv0z1aHQg0hjFBkI6dzwGOZ9B 906S4DzTn7nWk66bIHXV1q5mgltMX/15nj6DZH105vXZJBNPgQsk6JjZnVpNGpzfvFrF TvBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=qecfrilS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j35si483842pgl.223.2018.11.28.18.53.26; Wed, 28 Nov 2018 18:53:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=qecfrilS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727677AbeK2N4I (ORCPT + 99 others); Thu, 29 Nov 2018 08:56:08 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:43834 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727239AbeK2N4I (ORCPT ); Thu, 29 Nov 2018 08:56:08 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wAT2ifq8091539; Thu, 29 Nov 2018 02:52:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=99GSPiKsT1ePaQaJ18PEwVQ2A01zh/1VLhsmFRyeSc8=; b=qecfrilSPKhPb7SzxmO42yErIb5FyJp58xIultj4h/sRPWqJF7wBjo43xx4Y+QUJ2nMs W5ndq+2QCAK05wwJ9NO9jO5pyNDVnDmkTPGT7NyxK7eyOeSi0gEFsMYSM3Go2oXIwnpV P2cMKAd/rzhlZliV9rH9kDlEsl0pVjpGZPsCFQq6/35A6e3dcXscg0f48x1B5RESE2po vYlDE77ujW2rCli378r4v6Kpyrpx8n26gPE7OQpI2CLAYN2KZi0BksUd14KEOguwrcSK T5ne5WjX9bDpmBdUTM67ww9XTrTNotHWR9kbWejN+uLSuO0FEbbHNAYWH8iismQoNbtC OA== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp2120.oracle.com with ESMTP id 2nxxkqnpg6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 29 Nov 2018 02:52:07 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id wAT2q1eZ026094 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 29 Nov 2018 02:52:01 GMT Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id wAT2q03d023815; Thu, 29 Nov 2018 02:52:01 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 28 Nov 2018 18:52:00 -0800 To: "Gustavo A. R. Silva" Cc: Kashyap Desai , Sumit Saxena , Shivasharan S , megaraidlinux.pdl@broadcom.com, "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 30/41] scsi: megaraid_sas_fusion: Mark expected switch fall-through From: "Martin K. Petersen" Organization: Oracle Corporation References: <5fceeac101cc3dfe4a129764a139c1b616cba292.1543374820.git.gustavo@embeddedor.com> Date: Wed, 28 Nov 2018 21:51:58 -0500 In-Reply-To: <5fceeac101cc3dfe4a129764a139c1b616cba292.1543374820.git.gustavo@embeddedor.com> (Gustavo A. R. Silva's message of "Tue, 27 Nov 2018 22:32:34 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9091 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=683 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1811290020 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Gustavo A., > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Notice that, in this particular case, I replaced "Fall thru" with a > "Fall through" annotation and added a dash as a token in order to > separate the "Fall through" annotation from the rest of the comment > on the same line, which is what GCC is expecting to find. Applied to 4.21/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering