Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1955009imu; Wed, 28 Nov 2018 18:55:25 -0800 (PST) X-Google-Smtp-Source: AFSGD/XA4ahdItLNoy23n95gGshFwK/8+b2pvJOPS0ComVAhPWdTVxv6wO3SmWYYjOsVGNESMizX X-Received: by 2002:a62:4d81:: with SMTP id a123mr20582516pfb.122.1543460125282; Wed, 28 Nov 2018 18:55:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543460125; cv=none; d=google.com; s=arc-20160816; b=GU983TqoaClJwje5CgNgWD2eibcVHaN5MC3ln+SxS24Ng3IYQBOlWlvwbevkY9ggUd 37nVCaDP2nLATmtSNb9/DgKHUxRE3kNk01zvss9yWoM1FAwvrYSTK4ye/C9ENv6yPsIK Mn6s6+t/1PiP1KKcFqlTN+XklO+p8pw3I+hD4zS7Xy57/LY5EN8D2rhljPEei5Rvh/Kj HPym7xR6ZzPctJfFOHFqbH5vL9zdHPezMwpqB7ljm/DRFHpB34OVKMr9KnFBeW8pmzVQ 4rLM28ixjxJKK11TcDcJ5WIar1Kig6f6MOyxWGFh3Zulr+E27OsQlBmkei7yH/SboqTe rbOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=vz3VseW+/4s+WL5xBi4PVwTPWx9H2J+92nRwZRXNjCE=; b=KXMsJJEqiurPMHmohWQ+TCoO9qbU6vwKuKXfEeQcdW9wkgkgLaFVWNl0OFiEZkGDA1 h9n04/jARtrX6PhJkpf1OFotR3ehAgOhH3MI6g5JQTaBAONSVoYROAZDrkGX5S5K0BTr 7Gy+LF/Sk0wDbMDMgjk9LZvvEd0rryuYvbA+VSsckY2nIJ4r9nuxfXEfdrZqcjBwztij gYmxemqQOOvd3QTJpb01lRZN5tWnSpws/m+HtVHyMAOP6Ky2bak+7KfvKcWNJ4XowS/k gLGeseTtY2jDi1IqCqS0AMJ01I56bRPKkc3LQdFiu6keTtsKLev/pW7PVy/AGpFQNy6f Q5uQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=cHlO1igJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v5si611056plg.318.2018.11.28.18.55.09; Wed, 28 Nov 2018 18:55:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=cHlO1igJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727387AbeK2N5s (ORCPT + 99 others); Thu, 29 Nov 2018 08:57:48 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:45034 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727022AbeK2N5s (ORCPT ); Thu, 29 Nov 2018 08:57:48 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wAT2igin091542; Thu, 29 Nov 2018 02:52:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=vz3VseW+/4s+WL5xBi4PVwTPWx9H2J+92nRwZRXNjCE=; b=cHlO1igJ8soGxLU7bGAw+FWPxFdIXXNwjDDN2BN6EF/sq21Q58+S5uM98gBSdTvabSnx 6XVHkNkUpu9wqcX+wWmmZiUH9YZwAceKwtd6kDVr8fM0WDocuEixH4W6omLlike0p6VT KK/jCow3JK4vJlO3jiJ0FLHs8Vmn5m+AIaGu9ZgvGr53gY7SfTHv/R1SQ9tV4XjcwkBC YqMGfH5zPo+ArABev3Uf0PAAljGyYo5fWLlAdDFIe/eKbGnsuP9wSAIstWeZfGesF5PW U6/VRPa/jlUYz0m4ab32xsGfZRtPQhnKDSu9N5ITZn4ng+0o7kO2u3yFmDotjeAhsLiG Eg== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp2120.oracle.com with ESMTP id 2nxxkqnph7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 29 Nov 2018 02:52:43 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id wAT2qgAK013093 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 29 Nov 2018 02:52:42 GMT Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id wAT2qfcK008898; Thu, 29 Nov 2018 02:52:41 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 28 Nov 2018 18:52:41 -0800 To: "Gustavo A. R. Silva" Cc: Boris Ostrovsky , Juergen Gross , Stefano Stabellini , xen-devel@lists.xenproject.org, "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 41/41] scsi: xen-scsifront: mark expected switch fall-through From: "Martin K. Petersen" Organization: Oracle Corporation References: <00c2a9d45e39fb294f4995b07a9b7547206c3085.1543374820.git.gustavo@embeddedor.com> Date: Wed, 28 Nov 2018 21:52:38 -0500 In-Reply-To: <00c2a9d45e39fb294f4995b07a9b7547206c3085.1543374820.git.gustavo@embeddedor.com> (Gustavo A. R. Silva's message of "Tue, 27 Nov 2018 22:34:35 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9091 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=613 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1811290020 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Gustavo A., > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Notice that, in this particular case, I replaced > "Missed the backend's Closing state -- fallthrough" with > "fall through - Missed the backend's Closing state", which > contains the "fall through" annotation at the beginnig of > the code comment, which is what GCC is expecting to find. Applied to 4.21/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering