Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2077776imu; Wed, 28 Nov 2018 21:58:54 -0800 (PST) X-Google-Smtp-Source: AFSGD/XrQnZUxs8WddZkAqyUn0rJ8zsHdi3U7uFucUr/E4NxPU9SsDP7/Z66lgdbPlqnbp45gpAq X-Received: by 2002:a17:902:b943:: with SMTP id h3mr212034pls.12.1543471134667; Wed, 28 Nov 2018 21:58:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543471134; cv=none; d=google.com; s=arc-20160816; b=NteEgX+y+EkP8BpzaQ+J2CazdYRnFm+6+xg/jUtxsVUm6Pi1TYkaPIIDYTDnW867t1 iaSELX6XG7BEe9Njp3h6HhnpMGQBwdxf/vFfqQR5cOZg2j3G9fmt7pFFdTUEbrgCVo+y dqju5je1BiwCPNEvvqvkRGzyau0qGOoDok8ZZpXrp67Y2zNYM8WpUiuFa4vv6GpRtSGh 5SoYe2U7hA4duMMYuo6CDyB1NKgNnJI2DF+8V5svORN++ND0MyPd2YkKnykjgyHZmGka 6XZZDiC9B//bDHULCFPH9CdLdM2HKCtzOAUySTQwBRiq8C/kuL3UcOHlJCAEaPjYz6Cz 8+OA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Ysqc7EAm+5OxsQ6JaAY2P/dGkuI2kV3/vkdaQENDhDg=; b=nHkzONN5YiKaQAhQswI3iSTBqaEdA6O6RT+85vxJrtcufrjecg17qZoYRg+ziBQJQv V00tsmAYQApbnSPDXIRcMODrJeD+on5Wy8k9sqs35Vc2/P+slqPG0q6yEMM+mXmqT01l 7UPK4a5shnV/kTHVmk9J+xvA574OHaTAMN+xsvR4B25tHHKsKRrOkRSa85hA3ojc4p+y iSSOByiKiP0R6Q06XQyHFNEHHdrmCxGv/iVAdt3MpHQOSCJ4IgGm4i6NEhNHUH/pxt2i e27LEK6BBsqpsbEPUyA9NlZaWUpJNU2BfBx4nIHGeFP2z8t7z86mKpmOecJNoELIsiI7 cVyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=AmwfTLGi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i18si1016152pgl.414.2018.11.28.21.58.40; Wed, 28 Nov 2018 21:58:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=AmwfTLGi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728069AbeK2RAk (ORCPT + 99 others); Thu, 29 Nov 2018 12:00:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:33924 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727024AbeK2RAk (ORCPT ); Thu, 29 Nov 2018 12:00:40 -0500 Received: from sasha-vm.mshome.net (unknown [37.142.5.207]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AE2C020834; Thu, 29 Nov 2018 05:56:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1543470989; bh=jY7+2yB08jE8HxtxUtg+NxWiQ/iXK6M0A3+UFF+CLmE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AmwfTLGiuffGpk5emj5n5zyvS/U9odvo2eBmTpuumOpWxJbtDkiG4KJdnxhqQep9U 7d5W9JlrsoGnrH3eZfBw2dZ3EG4dS4xL6cIMQP74S8ghBigQhp7OHFG5AVypQKhDty QIKra76IUDQfEV3PqY4b1ndKnylnfg7hI4FuY3jg= From: Sasha Levin To: stable@vger.kernel.org, linux-kernel@vger.kernel.org Cc: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= , Kalle Valo , Sasha Levin , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 06/68] brcmutil: really fix decoding channel info for 160 MHz bandwidth Date: Thu, 29 Nov 2018 00:54:57 -0500 Message-Id: <20181129055559.159228-6-sashal@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181129055559.159228-1-sashal@kernel.org> References: <20181129055559.159228-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rafał Miłecki [ Upstream commit 3401d42c7ea2d064d15c66698ff8eb96553179ce ] Previous commit /adding/ support for 160 MHz chanspecs was incomplete. It didn't set bandwidth info and didn't extract control channel info. As the result it was also using uninitialized "sb" var. This change has been tested for two chanspecs found to be reported by some devices/firmwares: 1) 60/160 (0xee32) Before: chnum:50 control_ch_num:36 After: chnum:50 control_ch_num:60 2) 120/160 (0xed72) Before: chnum:114 control_ch_num:100 After: chnum:114 control_ch_num:120 Fixes: 330994e8e8ec ("brcmfmac: fix for proper support of 160MHz bandwidth") Signed-off-by: Rafał Miłecki Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin --- drivers/net/wireless/broadcom/brcm80211/brcmutil/d11.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmutil/d11.c b/drivers/net/wireless/broadcom/brcm80211/brcmutil/d11.c index e7584b842dce..eb5db94f5745 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmutil/d11.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmutil/d11.c @@ -193,6 +193,9 @@ static void brcmu_d11ac_decchspec(struct brcmu_chan *ch) } break; case BRCMU_CHSPEC_D11AC_BW_160: + ch->bw = BRCMU_CHAN_BW_160; + ch->sb = brcmu_maskget16(ch->chspec, BRCMU_CHSPEC_D11AC_SB_MASK, + BRCMU_CHSPEC_D11AC_SB_SHIFT); switch (ch->sb) { case BRCMU_CHAN_SB_LLL: ch->control_ch_num -= CH_70MHZ_APART; -- 2.17.1