Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2077919imu; Wed, 28 Nov 2018 21:59:06 -0800 (PST) X-Google-Smtp-Source: AFSGD/XhpaoZj+hQ2oyAJVPVxxluTADxGzUV/OXlhO6zN5skGtGatuCaSRV8pGZOd/0Jn/N4rnSe X-Received: by 2002:a63:66c6:: with SMTP id a189mr147887pgc.167.1543471146883; Wed, 28 Nov 2018 21:59:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543471146; cv=none; d=google.com; s=arc-20160816; b=CIRw1xO3F/5PFCdREY3TNkkw7Ot92PpS9v5kYZPh9VEGJlLGQhO5W10X1kFc3rd2na IG8anjwK/JnL+HkXlvG37ZxZ7YLPwOpfdioDXDMovSRzlRbZ7cA1cG9nyzZHurvA3F36 r27l9YrPZCWiuTcANGGeYAy2eSDgalHN6XUjWfeTX1iSDomEKo8MNLEYORyWZ1qaonUS VasN0q7XkweZgXbb6SpsER26t01iI84LoqhXuDPdbZ5E16eAWj8Km1LgMJEfRucCDk00 cYoVuOum3Hj8fQMx96W+/6zJSgs3ywlDCs0Nv7iYO3t6RwbP4rtag9W1gY5oepqO3PWK orjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=Kbl5/gHBvg6fK1PlfSlth3G9Bc6imw2Jw+L3s4nY7nc=; b=ZEe63WzBmDaIaoEiwIOhSZpEAZyWr2PZ8ayi+oa2p09/Dh07rm+z2ZBnMCtNDH20AS TscAO52dhqRUZ68SNfMWF49OO601+tKY4Q2OK+GMjAzaEE/0cMunBNkt1kJYIIXrNDL1 1rKYh3dtG0dHM6Ml9te453Ogy8KdFjD9ebhloRbBINmR9lQvC8pcu4pE/nKDHi7fTXXy zmSYoBdEXhJWBZn7zvHMLslby1XKIn67hCGVGPZZ6EF4ubIYxvBE2SHjAwxljL6otftJ u7zTLQt+syk/MDgBz+wT/cwIoezRqvtNvyEK6yoEt3epTH3wz6fEXDaFKqhj0qPeh95q CIow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=EPw+M4Zm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d10-v6si1173306pla.207.2018.11.28.21.58.52; Wed, 28 Nov 2018 21:59:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=EPw+M4Zm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728334AbeK2RBy (ORCPT + 99 others); Thu, 29 Nov 2018 12:01:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:35242 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727416AbeK2RBx (ORCPT ); Thu, 29 Nov 2018 12:01:53 -0500 Received: from sasha-vm.mshome.net (unknown [37.142.5.207]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2317A208E7; Thu, 29 Nov 2018 05:57:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1543471062; bh=g+ZoD/XMBJPHU2RS+Q05povaxqZJrUNE/vww7AGnsAo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EPw+M4ZmxoCzOB3CqbRRaEVlDiiNQYsnYPc3cyqBi1tEY0gJAeDxKAdksMuGRv57G /hrURBu5HlCzGV/UmNgWZvNRsp5r+8nrqj9E2Wu7DCeb0WkCgd1mxRWw/vW1k14Fbe Fv0ttJYLNmoDwg5f+VgsJ510S1SQrn1Za4CxO2LQ= From: Sasha Levin To: stable@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Denis Bolotin , Michal Kalderon , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 18/68] qed: Fix PTT leak in qed_drain() Date: Thu, 29 Nov 2018 00:55:09 -0500 Message-Id: <20181129055559.159228-18-sashal@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181129055559.159228-1-sashal@kernel.org> References: <20181129055559.159228-1-sashal@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Denis Bolotin [ Upstream commit 9aaa4e8ba12972d674caeefbc5f88d83235dd697 ] Release PTT before entering error flow. Signed-off-by: Denis Bolotin Signed-off-by: Michal Kalderon Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/qlogic/qed/qed_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c b/drivers/net/ethernet/qlogic/qed/qed_main.c index 2094d86a7a08..cf3b0e3dc350 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_main.c +++ b/drivers/net/ethernet/qlogic/qed/qed_main.c @@ -1634,9 +1634,9 @@ static int qed_drain(struct qed_dev *cdev) return -EBUSY; } rc = qed_mcp_drain(hwfn, ptt); + qed_ptt_release(hwfn, ptt); if (rc) return rc; - qed_ptt_release(hwfn, ptt); } return 0; -- 2.17.1