Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2078080imu; Wed, 28 Nov 2018 21:59:19 -0800 (PST) X-Google-Smtp-Source: AFSGD/XTiUKCrTUYo+WrkQVVp1KMLuhQlfgVYlfA4OdCTMWkocnb/OdwvE2go+s02YIayah9MDun X-Received: by 2002:a17:902:622:: with SMTP id 31mr173898plg.171.1543471158961; Wed, 28 Nov 2018 21:59:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543471158; cv=none; d=google.com; s=arc-20160816; b=GLH0oymFVWJzDft5MjluFteR4anULyKFG0KmwQmihSVPVpBjsJfhMV+xVJLpnUSP4c 9JOH7GGQDKokAgPNiGu/LV/jR2TfLQnGDTEuVI/rnlaQPCe5LhiDJ2qwht+Rq0H8nr5h 9d48eeBJoO2y96nVSlAWhPxcvXw98mYSNpT9+ps2oOAZhE7pX5Fte92y44JxuvoTZJds oLEiZ7LnJHnoZqY3NwtBXXmqUakhlRvoJDBD8oGXKR6I2euu/ChtzhQn6wRVTW8DvS0B a35KgMCoKi+pfSO2ps2EABS9sZd6SlR+DG4nvzheXeQY5SRXyfalUiMt4XTbgi40kEQF W2iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=C5YB+kfMvGBjFLELpJAOwFo6KKECE8KT6xxJ51Kdrf4=; b=HEduW4Emg/gO1fhpqWUHxxR2Shgo7s9Nis0PRGfZnlpYbqYehiajcT3Z4jj4fgXIqo CfFFY6TZ3mGhkw29mAy2sRDpKC7JbytJOAmhVIqiwFOTHb3k8VQR+cEdwP4PTIoFD2Um A4eknNr1VoDWRodq60TLexxTtx/C2KqZ0e72K2mjw0urU7OLp+0uiMukx/G/2+rtGKb5 49jR//xO1nu34LM0mmB5tesDLK5Cigbsp9w2puea0wepyGzcEmo9aHes4Kuob6LKpLG0 8qsQr4Wk9d2FX11BY+1xu4Bd/XqPN9IBmZu0h+Jd48TXLdzch9mfx4zHC1ONBbuhmLSW m43Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YlS25U64; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y20si1065708plr.106.2018.11.28.21.59.04; Wed, 28 Nov 2018 21:59:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YlS25U64; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728416AbeK2RCG (ORCPT + 99 others); Thu, 29 Nov 2018 12:02:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:35590 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728032AbeK2RCG (ORCPT ); Thu, 29 Nov 2018 12:02:06 -0500 Received: from sasha-vm.mshome.net (unknown [37.142.5.207]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9F5B5208E7; Thu, 29 Nov 2018 05:57:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1543471075; bh=4J+99dOlWLBxhySDJITTOZmm5WOJYtTN6vEFu9Evopw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YlS25U64n5zzkF7MfC7Ly6u6bJvX44DhlGQXgiuuSsUDwJDsaSzbczdyeCbog3sqm 5y9eojWZQ15YnfqUMjJGhQEmga6+HLKVJibU/Xd6EG9yS6m6Pd7BuaYIvAdO2jd2gQ rizpHoFMh71YHEAJY8YcpFYvMpuSdT87n+WQzp6w= From: Sasha Levin To: stable@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Dan Carpenter , Felipe Balbi , Sasha Levin , linux-usb@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 22/68] usb: dwc2: pci: Fix an error code in probe Date: Thu, 29 Nov 2018 00:55:13 -0500 Message-Id: <20181129055559.159228-22-sashal@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181129055559.159228-1-sashal@kernel.org> References: <20181129055559.159228-1-sashal@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit 3c135e8900199e3b9375c1eff808cceba2ee37de ] We added some error handling to this function but forgot to set the error code on this path. Fixes: ecd29dabb2ba ("usb: dwc2: pci: Handle error cleanup in probe") Acked-by: Minas Harutyunyan Signed-off-by: Dan Carpenter Signed-off-by: Felipe Balbi Signed-off-by: Sasha Levin --- drivers/usb/dwc2/pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/dwc2/pci.c b/drivers/usb/dwc2/pci.c index d257c541e51b..7afc10872f1f 100644 --- a/drivers/usb/dwc2/pci.c +++ b/drivers/usb/dwc2/pci.c @@ -120,6 +120,7 @@ static int dwc2_pci_probe(struct pci_dev *pci, dwc2 = platform_device_alloc("dwc2", PLATFORM_DEVID_AUTO); if (!dwc2) { dev_err(dev, "couldn't allocate dwc2 device\n"); + ret = -ENOMEM; goto err; } -- 2.17.1