Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2081925imu; Wed, 28 Nov 2018 22:03:43 -0800 (PST) X-Google-Smtp-Source: AFSGD/V8b9wJcvntgarv3M65oHmRcuJL4zhgdcalDTuh6XR+DQTzW87s3uC1y+7i3B54jrtFy1Kt X-Received: by 2002:a17:902:bf49:: with SMTP id u9mr223384pls.4.1543471423913; Wed, 28 Nov 2018 22:03:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543471423; cv=none; d=google.com; s=arc-20160816; b=MSomD1hKRZ/bX2gfXCw3uBOOq7gTlzvdw2HxT9OZsG38ojesVqsLM6nJcmKQYwM1lQ ir+Ky5fEx2f+Dlz0Q8oYDV0bLv0ZANpxMyTfgYokCsnwcfsiu0zfE3DkvFe+EWO3zUZr sVON7abctTW1GxGZ3E68k5Ba6jPuDSgvzWPyHQN9hNNMM6cBr3/LeQd97kjisSmQT9bF +H1UW8ErmxPyR/hiDkcbUljY0gxqIQEn+vyqttyFnGE63Vo8J32bLqYe9o2nJMqwTwLt 6NzCvOesnqo4/njExG7BJ5JK9CKB+E6ZMwNlBa+1zNNMdcQG4Mtn2CbqbS+IB4SfnIKx UJyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=s1IUgyPAcByaHaXvoyBUXDvCVQzpp6XT6BnQIssdrNA=; b=Lfm9PgEVzKpsQvYJe0O/S09Emok419b4eayWPTS1eST3B8uXmihc/5xZmUcg3E2+Im sOgjm9W1/oHSJcB8jjROK2m1C3FaZ5GfhUwhSSRk8xgNHZ55onzhjSsRYKB4glkqf9bY bgKfzLcEWb0GiP9wiqjI3slreIe04VAGNEdx3V9DtTMTcDE/oHGZXIZhpcaZUqzw8ODS bBvfTSIY45qfnqDZwjqAqCCDjFul7KSV8rHoCtCdtsW3NdMUk8xzrYLdzHEIWRrVIgmt 44jZIT0CCXz4aomysxkX3o+72Sc53U77BwVrBUONZvLwQ/bPqTcfTbvxNSKyJy44dj+p hMHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zSbJQ0ym; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w12si1013732pgs.182.2018.11.28.22.03.29; Wed, 28 Nov 2018 22:03:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zSbJQ0ym; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729527AbeK2RGO (ORCPT + 99 others); Thu, 29 Nov 2018 12:06:14 -0500 Received: from mail.kernel.org ([198.145.29.99]:42180 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727767AbeK2RGN (ORCPT ); Thu, 29 Nov 2018 12:06:13 -0500 Received: from sasha-vm.mshome.net (unknown [37.142.5.207]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1FF27208E7; Thu, 29 Nov 2018 06:01:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1543471321; bh=6eYduTDK3BIhaAuDKD59d3iLpXl299kajHmxpRqGlYA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zSbJQ0ymvHxOY83F9CHpfW4arvraA0E7fhKYyk1W5E3vLfr8G3CLImRWK4RPa4FJc yU2osNxKxypoAe3bh/alPEuKvOYZm7Si6vdOGh3HZolW+ujoAv2V6zsUmHc5YmhnYv /Nru61Y0YGpT5x9BNODWQvjlI2K6e+EbQzmmy8z4= From: Sasha Levin To: stable@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Denis Bolotin , Michal Kalderon , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 12/35] qed: Fix PTT leak in qed_drain() Date: Thu, 29 Nov 2018 01:00:46 -0500 Message-Id: <20181129060110.159878-12-sashal@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181129060110.159878-1-sashal@kernel.org> References: <20181129060110.159878-1-sashal@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Denis Bolotin [ Upstream commit 9aaa4e8ba12972d674caeefbc5f88d83235dd697 ] Release PTT before entering error flow. Signed-off-by: Denis Bolotin Signed-off-by: Michal Kalderon Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/qlogic/qed/qed_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c b/drivers/net/ethernet/qlogic/qed/qed_main.c index 954f7ce4cf28..ecc2d4296526 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_main.c +++ b/drivers/net/ethernet/qlogic/qed/qed_main.c @@ -1561,9 +1561,9 @@ static int qed_drain(struct qed_dev *cdev) return -EBUSY; } rc = qed_mcp_drain(hwfn, ptt); + qed_ptt_release(hwfn, ptt); if (rc) return rc; - qed_ptt_release(hwfn, ptt); } return 0; -- 2.17.1