Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2088444imu; Wed, 28 Nov 2018 22:12:20 -0800 (PST) X-Google-Smtp-Source: AFSGD/XXUqa5+i3/7RshCGFWYn5dZ1oVqtBOzcDzl++h07KxrA5SedT0S5HWV67PfAH1jjM5FTea X-Received: by 2002:a17:902:9f89:: with SMTP id g9mr238514plq.214.1543471940696; Wed, 28 Nov 2018 22:12:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543471940; cv=none; d=google.com; s=arc-20160816; b=aHNZjGRD62iJzI7WL53SWSdq7Kih2qrpZk1PBsOnlOUnzBGv+W8NeHJ8pHudrFlxyc pYUuL3uvAWNfA4NvR7xHPf9NaHZNXNnWnh9Z7zZdHoQ0aXnSsT8Y2/yAY34GCASBqsDd Zg7aO1zdy8Qmg+AzDHYs2JHtmPWeGEiFxRDg7Dqvmc41vDNABRzOyqHRxrwXTvCATO7n RDNy7zRfX+TobimphEqCUM3CrYIjb6Klx7I3X7d4RwMwFgySFGgLJgzzKOgu8m/bU7mT Q65gv2kKaR+ZkIxRUyz4F77kL8yFzSZO6y8cnXftlg4y46dUmRvjtub4JqjIiuHJSmJF 39ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Ysqc7EAm+5OxsQ6JaAY2P/dGkuI2kV3/vkdaQENDhDg=; b=XEnAePHmM/pzJmVUuE5QtxOPYnLlHBOhZBzvqkmALQGiRqs0jpiuP/QtCWaJA9i1Oh Naod9zRDF0RqaIOPe1TzS9hI+0rBmTW5jg2Vt6IR8t6F4GkgvFWig4QA/BfOz7HJBNoZ Z3Wc2GY8Mu5Cq0rhCrpIzto5tGjc/pdQ9VPEMij+gpxCjFoJ1x+8Osdtwsgg5kQAaBHx 2L6pj2Gt+judYXEPXnZAkcBRHSvNj1WsOCsJDdxtiMOYV60TPWnZh7OfkE82Oo97WxkH BTGQK7/IBjs63/385pUdfqlP/a6WCFj8BG+LlYnA4/+ArGI0+2eLxMmfDLAlqT6yN7Od c7xQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="xMw/Xj14"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s12si991749pgh.488.2018.11.28.22.12.06; Wed, 28 Nov 2018 22:12:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="xMw/Xj14"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728767AbeK2RFi (ORCPT + 99 others); Thu, 29 Nov 2018 12:05:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:40998 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727767AbeK2RFi (ORCPT ); Thu, 29 Nov 2018 12:05:38 -0500 Received: from sasha-vm.mshome.net (unknown [37.142.5.207]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 280E521104; Thu, 29 Nov 2018 06:01:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1543471286; bh=jY7+2yB08jE8HxtxUtg+NxWiQ/iXK6M0A3+UFF+CLmE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xMw/Xj14EGS+otL3dXhmPpU8YPxTj/ApVmyD9Svp8B8jS4IKsKP0LivNheeYhpY0b pJ/AqEZ7A4/ReguNX9g5Mdbq7rZ7emopkdSVGwQyznowhJewuOUkC2yL5tC6qChmWz nvgBarZveLh10WYWCzAtYFu0SksjEG7V7phAlleE= From: Sasha Levin To: stable@vger.kernel.org, linux-kernel@vger.kernel.org Cc: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= , Kalle Valo , Sasha Levin , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 03/35] brcmutil: really fix decoding channel info for 160 MHz bandwidth Date: Thu, 29 Nov 2018 01:00:37 -0500 Message-Id: <20181129060110.159878-3-sashal@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181129060110.159878-1-sashal@kernel.org> References: <20181129060110.159878-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rafał Miłecki [ Upstream commit 3401d42c7ea2d064d15c66698ff8eb96553179ce ] Previous commit /adding/ support for 160 MHz chanspecs was incomplete. It didn't set bandwidth info and didn't extract control channel info. As the result it was also using uninitialized "sb" var. This change has been tested for two chanspecs found to be reported by some devices/firmwares: 1) 60/160 (0xee32) Before: chnum:50 control_ch_num:36 After: chnum:50 control_ch_num:60 2) 120/160 (0xed72) Before: chnum:114 control_ch_num:100 After: chnum:114 control_ch_num:120 Fixes: 330994e8e8ec ("brcmfmac: fix for proper support of 160MHz bandwidth") Signed-off-by: Rafał Miłecki Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin --- drivers/net/wireless/broadcom/brcm80211/brcmutil/d11.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmutil/d11.c b/drivers/net/wireless/broadcom/brcm80211/brcmutil/d11.c index e7584b842dce..eb5db94f5745 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmutil/d11.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmutil/d11.c @@ -193,6 +193,9 @@ static void brcmu_d11ac_decchspec(struct brcmu_chan *ch) } break; case BRCMU_CHSPEC_D11AC_BW_160: + ch->bw = BRCMU_CHAN_BW_160; + ch->sb = brcmu_maskget16(ch->chspec, BRCMU_CHSPEC_D11AC_SB_MASK, + BRCMU_CHSPEC_D11AC_SB_SHIFT); switch (ch->sb) { case BRCMU_CHAN_SB_LLL: ch->control_ch_num -= CH_70MHZ_APART; -- 2.17.1