Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2172888imu; Thu, 29 Nov 2018 00:11:02 -0800 (PST) X-Google-Smtp-Source: AFSGD/V2ZgOTQ2j25msNCc+tHO6nOs4uZuCT5gH4FLX5p8Qg0OvtmJ3vtDbY6y9TnUDcm1AYD+SS X-Received: by 2002:a63:8f45:: with SMTP id r5mr419962pgn.222.1543479062041; Thu, 29 Nov 2018 00:11:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543479062; cv=none; d=google.com; s=arc-20160816; b=0u2ufvHtDOZT8la8af+KZeFpkYkY8XOSAbxog9iwyvetp4bwHD07x/zfSQr7sw3vCQ 1yLsnhAc/ToJf5MnkTGpVaCujNSd2O4Lvv2CyqNxORRVDF0KF1BUvrLaLh7fgUn+qMRx WSDLsm7Y1rOEpWvMP9G9iH9e2hbgMZi1s/5LbciSxfZqPIwhd+00wdNejPn6DYYWsSoJ 5JEl70fqwWAx8mE5lkqcpfHYACoDkc4f1WmzDyjNmJVjWqKwypFYL0T55IN4ulAa/gAx aPztrFZmDcdpcjAKLmq3puxljOi76CNw1kSr+Nl7PNEjrVfQ3f/CraDQn/+2Ag6bidkY Olrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:dkim-signature; bh=s8D3KGdqHXecFnX8it035mVxsJixwUXlYYaL2rTeZpw=; b=OTFLlKWWlrdjE/Cy5VlK8ptoe3S/xvHHCZHbENZxWLSvcJbCofoQ1HSq6w+IG6HJwf b9nVOSvIA+fuYyFEXhZsmkwYyl8mvqTMrD4vhq4U3DKX4Jl9ZKDvFks7sm5OQ96mQ+UB N1u94f/rwiVdhUBN1J1sq3LDmwmljxMDwTbu6xpSNs7E/BobibAVUMeXhTKU2+tLCxUH YonTHysF1iMKbJN00bUj3JPgFxXM5wG7vDClPWA+a+XuNyjgMyoeyRM9HMD+Gpdmy4oT 183dG4EsTMvOKay/l9SGdJU7yZnu14X7+Ec1qzCTHZX0I3sCNJfWagVwf/yPy+nf7svB 4N3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kroah.com header.s=fm2 header.b=D+auLjln; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=h4t5752D; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a1si1316298pgk.495.2018.11.29.00.10.46; Thu, 29 Nov 2018 00:11:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kroah.com header.s=fm2 header.b=D+auLjln; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=h4t5752D; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727534AbeK2TN5 (ORCPT + 99 others); Thu, 29 Nov 2018 14:13:57 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:51673 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727017AbeK2TN5 (ORCPT ); Thu, 29 Nov 2018 14:13:57 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 89E8C21C24; Thu, 29 Nov 2018 03:09:25 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 29 Nov 2018 03:09:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=s8D3KGdqHXecFnX8it035mVxsJi xwUXlYYaL2rTeZpw=; b=D+auLjlnt/60hHebumzyX1bPax7V6Y3zBYkpDyjRTRY JZP0JpIR4kQAl0ccya1WP+bgGKPKPPV/8COn1uCCmkn7hOgmXhxfEgiDJAi9N5pp yWNRIvkbnOZXwbDQc8wsU21DBnKqF05jeCZyhPJsNeqUrpFtfH1LoWHUIYjsZ2IQ ffeO7qUpieqWPHIZ5m9muuhkH5pULUu0Kjk+pS21jO4omaFAaIrQ8PWc65lH4Xvk OkjyyoHgafSabf0I9D8NaG/ZNMHK924NM426LmHUeEJbfLVOAQr7Pphu+bJsoZJs PhbYsB6OyIGwpm8OTlFSV7dthAjCjc3PpwdACYsD7Qg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=s8D3KG dqHXecFnX8it035mVxsJixwUXlYYaL2rTeZpw=; b=h4t5752DULVxuP6RmCILZ8 e5DIxOhzCAo4oIXYNzo0d9j53fbVqGI0DNYGM++2mI6qhYn65CI4VCT8nwVGpcvz cI1bcZYoXfUgrMOcjpf0uCYbXoeApkxU/fkUbs7Ib+ZQFnF15d77VxOjQniRMCRZ aPgPp3Q9sJf0FtGkSBgvNS9ebeCYKeV8JcTbTWqDXc4Eg7MpieB6HERQ1D9O9eFL W78cJvs4ytwxWZxWjYKDsC+oT1sffXQWWQLzkcPGw+2mPReANyNIKORrjkN/zm+z AlmloD6gUVsSbnG7fTvYdcSRWzmPnb5CJIFZiPi9vGiKXSKOA95Gra7BtANByyzg == X-ME-Sender: X-ME-Proxy: Received: from localhost (5356596b.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id 75642E4122; Thu, 29 Nov 2018 03:09:24 -0500 (EST) Date: Thu, 29 Nov 2018 09:09:23 +0100 From: Greg KH To: Martin Kepplinger Cc: stable@vger.kernel.org, dedekind1@gmail.com, richard@nod.at, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ubi: fastmap: Check each mapping only once Message-ID: <20181129080923.GE13859@kroah.com> References: <20181126103842.3249-1-martin.kepplinger@ginzinger.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181126103842.3249-1-martin.kepplinger@ginzinger.com> User-Agent: Mutt/1.11.0 (2018-11-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 26, 2018 at 11:38:42AM +0100, Martin Kepplinger wrote: > From: Richard Weinberger > > [ Upstream commit 34653fd8c46e771585fce5975e4243f8fd401914 ] > > This commit got merged along with commit 781932375ffc > ("ubi: fastmap: Correctly handle interrupted erasures in EBA") upstream but > only the latter has been applied to stable v4.14.54 as commit a23cf10d9abb. > This resulted in a performance regression. Startup on i.MX platforms is > delayed for up to a few seconds depending on the platform. > This fixes ubi fastmap to be of the same performance as it has been before > said fastmap changes. > > Fixes: a23cf10d9abb ("ubi: fastmap: Correctly handle interrupted erasures in EBA") > Signed-off-by: Richard Weinberger > Signed-off-by: Martin Kepplinger > --- > > Richard, although this fixes a major slowdown regression in -stable, do you > consider this "stable" too? > > This applies and is tested only for the 4.14 stable tree. It seems to be > equally relevant for 4.9 and 4.4 though. Now queued up for 4.14.y, thanks. greg k-h