Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2518219imu; Thu, 29 Nov 2018 06:18:52 -0800 (PST) X-Google-Smtp-Source: AFSGD/VNvDQODVjGsWviysbdMJhwFZ7e/AoHV88P1cuHRqbSJYZKoJ4+O46N6rEIgu63tnEGpC8q X-Received: by 2002:a63:e302:: with SMTP id f2mr1431130pgh.320.1543501132575; Thu, 29 Nov 2018 06:18:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543501132; cv=none; d=google.com; s=arc-20160816; b=yaE6sWbZ+Jv4atqq2PmcTqveyQ2gihhaLdff76EqwhOrP9mS3suB2Sp+veMAv6gy4k HzIHIyv/hQEfXD6sRsHqpseNbWYUfBYZhrJtd7w8C1NvZYwZg8pGQABud0BC6IOaoCMN n2DiHic82EHZaf1oLoL4yPg3fM8lk5/co/rnFXBZel2qQYv35Z3dDoBMxL1hCskxkOFR pdLP821vDFQqO7AporChSfj9Ut8XJPquzqhePcTk0ophwrDYDHDHHqvEUWkazjMfEqM7 JPIZQO4kAONAfDvVVETAbQKgao2ZusTWRmgHkz6T9vhGIlQG4xnMIbTq6sslB2+DfOA9 xS+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=VqJxXYMpMSQMLu9rhkRguGGjRuYo09wUORyNKw85PJo=; b=ZBzn4XxvWM7NLEg7WmGLLtvvJB9u87oAGOQnHJ5hCYO7e66LW/XGnsg6xdIvOScipH 9qAkS8K3WWoWuYCZtkWSd2UkGaEEE8Cs0TKpdNttdAjTQzhLBMgwRkQga9QPXnlVI5IQ +cqU7c4rT7PTr+fE+5+1LfbXQIx/7zhLuCinF6S26XSZ+sXjdWsS7rj/h5Obs7Y2BLZG Im0Ysbw+TVvQhmQy+fa3yyklIlcITpCdeRfwzjTIwUAjaLFgQV6WDqmwV+EHh6oby4uQ BftqAfTCz/Ps6aDdSAxLs6EdZPJZimm6/2G2GwNe9ZuMACyXopNrKmbl7fHrCTsmGeru bk0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="fHwDitm/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 2si2315081pla.156.2018.11.29.06.18.37; Thu, 29 Nov 2018 06:18:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="fHwDitm/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730194AbeK3BW0 (ORCPT + 99 others); Thu, 29 Nov 2018 20:22:26 -0500 Received: from mail.kernel.org ([198.145.29.99]:44122 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728190AbeK3BWZ (ORCPT ); Thu, 29 Nov 2018 20:22:25 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A76E6208E7; Thu, 29 Nov 2018 14:16:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1543501015; bh=1tdAH1Lqz1Nd94s3V4+QUWhEC8CbsdTqZeK86t8DVyQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fHwDitm/i33DgbDJz9yNxezIqalDhOi3p9KWo+RjkI/zjoDmYPeYGnQO3cD7PfLRk JzFKPmXh4PCVIDRuZOwPctY3+DTL0EXMEA2Z12BU9Aam4eSq9t7Tcm1tIFHq9zQFjP RzqH7xPVbdi28qtK5uXVkEEDcAdHiVrFCpzElIJQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Leo Sperling , Dmitry Torokhov , Sasha Levin Subject: [PATCH 3.18 70/83] Input: xpad - fix some coding style issues Date: Thu, 29 Nov 2018 15:12:28 +0100 Message-Id: <20181129140141.813718989@linuxfoundation.org> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20181129140138.002176596@linuxfoundation.org> References: <20181129140138.002176596@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.18-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 68c78d0155e37992268664e134996d2b140ddf38 ] Fix some coding style issues reported by checkpatch.pl. Mostly brackets in macros, spacing and comment style. Signed-off-by: Leo Sperling Signed-off-by: Dmitry Torokhov Signed-off-by: Sasha Levin --- drivers/input/joystick/xpad.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c index 298581b0f6c1..b6e172f22c16 100644 --- a/drivers/input/joystick/xpad.c +++ b/drivers/input/joystick/xpad.c @@ -89,8 +89,10 @@ #define XPAD_PKT_LEN 64 -/* xbox d-pads should map to buttons, as is required for DDR pads - but we map them to axes when possible to simplify things */ +/* + * xbox d-pads should map to buttons, as is required for DDR pads + * but we map them to axes when possible to simplify things + */ #define MAP_DPAD_TO_BUTTONS (1 << 0) #define MAP_TRIGGERS_TO_BUTTONS (1 << 1) #define MAP_STICKS_TO_NULL (1 << 2) @@ -390,15 +392,15 @@ static const signed short xpad_abs_triggers[] = { * match against vendor id as well. Wired Xbox 360 devices have protocol 1, * wireless controllers have protocol 129. */ -#define XPAD_XBOX360_VENDOR_PROTOCOL(vend,pr) \ +#define XPAD_XBOX360_VENDOR_PROTOCOL(vend, pr) \ .match_flags = USB_DEVICE_ID_MATCH_VENDOR | USB_DEVICE_ID_MATCH_INT_INFO, \ .idVendor = (vend), \ .bInterfaceClass = USB_CLASS_VENDOR_SPEC, \ .bInterfaceSubClass = 93, \ .bInterfaceProtocol = (pr) #define XPAD_XBOX360_VENDOR(vend) \ - { XPAD_XBOX360_VENDOR_PROTOCOL(vend,1) }, \ - { XPAD_XBOX360_VENDOR_PROTOCOL(vend,129) } + { XPAD_XBOX360_VENDOR_PROTOCOL((vend), 1) }, \ + { XPAD_XBOX360_VENDOR_PROTOCOL((vend), 129) } /* The Xbox One controller uses subclass 71 and protocol 208. */ #define XPAD_XBOXONE_VENDOR_PROTOCOL(vend, pr) \ @@ -408,7 +410,7 @@ static const signed short xpad_abs_triggers[] = { .bInterfaceSubClass = 71, \ .bInterfaceProtocol = (pr) #define XPAD_XBOXONE_VENDOR(vend) \ - { XPAD_XBOXONE_VENDOR_PROTOCOL(vend, 208) } + { XPAD_XBOXONE_VENDOR_PROTOCOL((vend), 208) } static const struct usb_device_id xpad_table[] = { { USB_INTERFACE_INFO('X', 'B', 0) }, /* X-Box USB-IF not approved class */ @@ -1576,6 +1578,7 @@ static void xpad_close(struct input_dev *dev) static void xpad_set_up_abs(struct input_dev *input_dev, signed short abs) { struct usb_xpad *xpad = input_get_drvdata(input_dev); + set_bit(abs, input_dev->absbit); switch (abs) { -- 2.17.1