Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2520533imu; Thu, 29 Nov 2018 06:20:38 -0800 (PST) X-Google-Smtp-Source: AFSGD/W1TDxasXNyWbD8xi7a3Dafa+HoirvV9L4pN0VqfUZnsR7clvBF94GydcIGJ3gNZSLds9CH X-Received: by 2002:a17:902:45:: with SMTP id 63mr1590711pla.272.1543501238246; Thu, 29 Nov 2018 06:20:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543501238; cv=none; d=google.com; s=arc-20160816; b=iUF5B15zdTzeFlI/PsFJUpOWXlP/03lpUKPkpJpL6GpVYsIQKmznax01T2XiDQDT8p 1pOVQN4uCyjzFKfIAn2OIR74JvgRymhkd7+5anugxDdrou4YWwgRiHrId8/r58i4xwKX hpek6px/x5DZ1cTl0QqsmRPWZg1jwb6+AL/x4/zyBSwhSqX2uJQkD7gq/Q/MB/Tppm54 A28nMy8OOM1/K60xWJSsM1wHmfNlHTpcWJpc9bzYBmkvfeGE8lH/GHwAF3SXHqPgw08p pZ24gM4+5pcrukKduXmVFZ7Fp7A6YedWFGp0lfG23987yplaxFsP9/XtJnXC/wi3OZc9 Goig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=SJt1Okz4uYP/R4RegVKjrwjuzu846D3RXLb0Jh5vOes=; b=RY7+Lsstoz+LJlX3iPQg7ZfP9AfrQLOWJtRfNDaXupFnGpcYNq8DLr4ljTQ+u9ZalL YY1V76/eYQIF7kh/poq7BGhK+5XcPywK2dckSkurZkAtk5hsMUpxotrox7TNdbOgD6EW NTyMi1ZTjqEM7cS8yyVzGWH/YDuBrWT+vGp/0BiLS7aOcq7f2sKgbKH1XiMZ8boPtbH6 9LmhnBydkB+dBJ6ER5711kc1xNEdWMcO2ems7RnfLXAgiS1N3jG2CJyj3W1HyH6h2f17 VSiAn8GPIJaTw7x9JL0JehIVi2rH5y1r5Qoc2cKD8dfNd8FlUDs5+bOPk7XrkiholV8g cHLQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=e1nE6MZV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a34si2048163pgb.458.2018.11.29.06.20.22; Thu, 29 Nov 2018 06:20:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=e1nE6MZV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731016AbeK3BYr (ORCPT + 99 others); Thu, 29 Nov 2018 20:24:47 -0500 Received: from mail.kernel.org ([198.145.29.99]:47830 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729808AbeK3BYq (ORCPT ); Thu, 29 Nov 2018 20:24:46 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F0865205C9; Thu, 29 Nov 2018 14:19:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1543501155; bh=0akjBsO4IScAdT3FMMt1rcze8ojsxVLi5pwqYK8n+3c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=e1nE6MZVBMDwktpI2sTabogtIWJEbUg6KvYT3VZ6+pgwzzva7HdwAXhaxalwfPz/s p9s1rfpNMeWlTssJfSyFBYZ7bilJFvDK4VZY3JHqQPc+rqmLQ3MeNwq+k7s9kEhz1a /YQn1rnLC0K0JXhLTwXtpPmgoy0ehz/39FxOk6h0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Leo Sperling , Dmitry Torokhov , Sasha Levin Subject: [PATCH 4.4 64/86] Input: xpad - fix some coding style issues Date: Thu, 29 Nov 2018 15:12:29 +0100 Message-Id: <20181129140115.335704910@linuxfoundation.org> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20181129140109.832117862@linuxfoundation.org> References: <20181129140109.832117862@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 68c78d0155e37992268664e134996d2b140ddf38 ] Fix some coding style issues reported by checkpatch.pl. Mostly brackets in macros, spacing and comment style. Signed-off-by: Leo Sperling Signed-off-by: Dmitry Torokhov Signed-off-by: Sasha Levin --- drivers/input/joystick/xpad.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c index 298581b0f6c1..b6e172f22c16 100644 --- a/drivers/input/joystick/xpad.c +++ b/drivers/input/joystick/xpad.c @@ -89,8 +89,10 @@ #define XPAD_PKT_LEN 64 -/* xbox d-pads should map to buttons, as is required for DDR pads - but we map them to axes when possible to simplify things */ +/* + * xbox d-pads should map to buttons, as is required for DDR pads + * but we map them to axes when possible to simplify things + */ #define MAP_DPAD_TO_BUTTONS (1 << 0) #define MAP_TRIGGERS_TO_BUTTONS (1 << 1) #define MAP_STICKS_TO_NULL (1 << 2) @@ -390,15 +392,15 @@ static const signed short xpad_abs_triggers[] = { * match against vendor id as well. Wired Xbox 360 devices have protocol 1, * wireless controllers have protocol 129. */ -#define XPAD_XBOX360_VENDOR_PROTOCOL(vend,pr) \ +#define XPAD_XBOX360_VENDOR_PROTOCOL(vend, pr) \ .match_flags = USB_DEVICE_ID_MATCH_VENDOR | USB_DEVICE_ID_MATCH_INT_INFO, \ .idVendor = (vend), \ .bInterfaceClass = USB_CLASS_VENDOR_SPEC, \ .bInterfaceSubClass = 93, \ .bInterfaceProtocol = (pr) #define XPAD_XBOX360_VENDOR(vend) \ - { XPAD_XBOX360_VENDOR_PROTOCOL(vend,1) }, \ - { XPAD_XBOX360_VENDOR_PROTOCOL(vend,129) } + { XPAD_XBOX360_VENDOR_PROTOCOL((vend), 1) }, \ + { XPAD_XBOX360_VENDOR_PROTOCOL((vend), 129) } /* The Xbox One controller uses subclass 71 and protocol 208. */ #define XPAD_XBOXONE_VENDOR_PROTOCOL(vend, pr) \ @@ -408,7 +410,7 @@ static const signed short xpad_abs_triggers[] = { .bInterfaceSubClass = 71, \ .bInterfaceProtocol = (pr) #define XPAD_XBOXONE_VENDOR(vend) \ - { XPAD_XBOXONE_VENDOR_PROTOCOL(vend, 208) } + { XPAD_XBOXONE_VENDOR_PROTOCOL((vend), 208) } static const struct usb_device_id xpad_table[] = { { USB_INTERFACE_INFO('X', 'B', 0) }, /* X-Box USB-IF not approved class */ @@ -1576,6 +1578,7 @@ static void xpad_close(struct input_dev *dev) static void xpad_set_up_abs(struct input_dev *input_dev, signed short abs) { struct usb_xpad *xpad = input_get_drvdata(input_dev); + set_bit(abs, input_dev->absbit); switch (abs) { -- 2.17.1