Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2527735imu; Thu, 29 Nov 2018 06:26:31 -0800 (PST) X-Google-Smtp-Source: AFSGD/U5yg9WCL5E7o3+yizfLEtbPVDmmCpo4cG6AqyNPwnTJOtew7dc2jUqAM9Tje6JazkSqe+N X-Received: by 2002:a62:4641:: with SMTP id t62mr1562057pfa.141.1543501591673; Thu, 29 Nov 2018 06:26:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543501591; cv=none; d=google.com; s=arc-20160816; b=Y/E/n/CGbT8CY6AjpIBvP+cBYOTb/YkE1FaYiSrhJrxo41g/ODa4z+9w+uxboB2uSG JSnoctNgS19N1H+9FmWS1r+QgKQh28TG3qsPateDIV+zCZ13AeJU8HIuE6fBYeiTMKT5 QGH6CGe+kaujtL1inkU45+JczV/LkMRgQugO7RCvPeuOJ9VJfRO4tvXycLMdoWXjWWGE XGSuxBdQwoDoj6A85r5MYvlm/DRs7lF+QBlvMnfQaCqKjcmvdXnmA2HL1ePaPH6ewMpC TlWSJTbq1mDM9NpdsuPJ/i72XxK6dEDBJbupAhTFimRYFa22PeU32R90ZU5sBO0RtD7Q j9cQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=RhoXFOKB5vKdyluIag3QN+vwvN58g1W6pHoYHvZ/A4M=; b=R1az0xo60LDzWaYKcukX+irrWgHB/BqZRL2KHKEhQeUl2r4BMvPt5gRF9PaJu1j90f Ev2036lq1Hbjbb+B22whdEf0+K0e5hRFQEq78Fy1FqN+3chyfbF8+o/no+MMzOm4gva4 Xx7yhFQf6Bbbil3F31pHA39KMP9Nzi2xvh3WaJZpCT+51uM1rlYErao64ueCDSBZzRGI 1IX7+CntwKnvjzKyEoePK8dTTuFvVSspjKaubrfIlLKvnmcLriQpwajoHCkFpTmdZwri La4gWDnMRhXFREBEIFtjYgGiiPHlrTpB3xEAYNxPFbAyRWTawHjuAs3b4fgs5ESe6Vqv WBBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vwbNPFAZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x128si2296336pfb.128.2018.11.29.06.26.15; Thu, 29 Nov 2018 06:26:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vwbNPFAZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732593AbeK3B3s (ORCPT + 99 others); Thu, 29 Nov 2018 20:29:48 -0500 Received: from mail.kernel.org ([198.145.29.99]:56456 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731464AbeK3B3r (ORCPT ); Thu, 29 Nov 2018 20:29:47 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 58D0320868; Thu, 29 Nov 2018 14:24:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1543501455; bh=cWxRcq1wN3+l01X2HjpOxmHZPOs0u8DkyGrIB176xbU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vwbNPFAZhgcK5Rc1uA6kn9vo9wtU/fLucO2A8EmAWoMcx5SVoFUyPchPCKLOW3vc7 2R+l16/t3HHU5MRnNPCw1O0IU5ftGb0UAwGiTIdXi+XXQpe1COv4JOVZZPYGti5EU0 2AYW0GB3pIOA5z6q62EWwY0/g7f6rfx1nVkf9QVQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Leo Sperling , Dmitry Torokhov , Sasha Levin Subject: [PATCH 4.9 65/92] Input: xpad - fix some coding style issues Date: Thu, 29 Nov 2018 15:12:34 +0100 Message-Id: <20181129140111.578221830@linuxfoundation.org> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20181129140106.520639693@linuxfoundation.org> References: <20181129140106.520639693@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 68c78d0155e37992268664e134996d2b140ddf38 ] Fix some coding style issues reported by checkpatch.pl. Mostly brackets in macros, spacing and comment style. Signed-off-by: Leo Sperling Signed-off-by: Dmitry Torokhov Signed-off-by: Sasha Levin --- drivers/input/joystick/xpad.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c index 298581b0f6c1..b6e172f22c16 100644 --- a/drivers/input/joystick/xpad.c +++ b/drivers/input/joystick/xpad.c @@ -89,8 +89,10 @@ #define XPAD_PKT_LEN 64 -/* xbox d-pads should map to buttons, as is required for DDR pads - but we map them to axes when possible to simplify things */ +/* + * xbox d-pads should map to buttons, as is required for DDR pads + * but we map them to axes when possible to simplify things + */ #define MAP_DPAD_TO_BUTTONS (1 << 0) #define MAP_TRIGGERS_TO_BUTTONS (1 << 1) #define MAP_STICKS_TO_NULL (1 << 2) @@ -390,15 +392,15 @@ static const signed short xpad_abs_triggers[] = { * match against vendor id as well. Wired Xbox 360 devices have protocol 1, * wireless controllers have protocol 129. */ -#define XPAD_XBOX360_VENDOR_PROTOCOL(vend,pr) \ +#define XPAD_XBOX360_VENDOR_PROTOCOL(vend, pr) \ .match_flags = USB_DEVICE_ID_MATCH_VENDOR | USB_DEVICE_ID_MATCH_INT_INFO, \ .idVendor = (vend), \ .bInterfaceClass = USB_CLASS_VENDOR_SPEC, \ .bInterfaceSubClass = 93, \ .bInterfaceProtocol = (pr) #define XPAD_XBOX360_VENDOR(vend) \ - { XPAD_XBOX360_VENDOR_PROTOCOL(vend,1) }, \ - { XPAD_XBOX360_VENDOR_PROTOCOL(vend,129) } + { XPAD_XBOX360_VENDOR_PROTOCOL((vend), 1) }, \ + { XPAD_XBOX360_VENDOR_PROTOCOL((vend), 129) } /* The Xbox One controller uses subclass 71 and protocol 208. */ #define XPAD_XBOXONE_VENDOR_PROTOCOL(vend, pr) \ @@ -408,7 +410,7 @@ static const signed short xpad_abs_triggers[] = { .bInterfaceSubClass = 71, \ .bInterfaceProtocol = (pr) #define XPAD_XBOXONE_VENDOR(vend) \ - { XPAD_XBOXONE_VENDOR_PROTOCOL(vend, 208) } + { XPAD_XBOXONE_VENDOR_PROTOCOL((vend), 208) } static const struct usb_device_id xpad_table[] = { { USB_INTERFACE_INFO('X', 'B', 0) }, /* X-Box USB-IF not approved class */ @@ -1576,6 +1578,7 @@ static void xpad_close(struct input_dev *dev) static void xpad_set_up_abs(struct input_dev *input_dev, signed short abs) { struct usb_xpad *xpad = input_get_drvdata(input_dev); + set_bit(abs, input_dev->absbit); switch (abs) { -- 2.17.1