Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2533848imu; Thu, 29 Nov 2018 06:31:25 -0800 (PST) X-Google-Smtp-Source: AFSGD/U943Nk7eQPEU87o/KslK81BM2ocvM3AdH1dNgEslbE5tpXcmeQDVmwHckwGMrobh9W0Zju X-Received: by 2002:a63:da14:: with SMTP id c20mr1355530pgh.233.1543501885180; Thu, 29 Nov 2018 06:31:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543501885; cv=none; d=google.com; s=arc-20160816; b=uLeiC+1WkFFNSjPYMo9qX3l24RoUJRXgVf+a06gJwRGA/tFDQnOeBczlCliOVmIwvG IXLzPvHEFiS+nCnVXjKRSvdKFNmCeJKoHauGeL1imueVsiH6ODqw8N4R1rHg2vjbTcef LTnZq9/kXu84qGiIoybmdVJnt2sbu95NBKfzV1RTmfjETLgSaC5iGc2tH8Mfe6VUe4+C u46JBkC0NadGhwSvbO1y0adlJtfC3Wd1Xp20GTRP6dzyb0XqenVl2yuIl9A7U0PnyFEd PQtsnqcBsiunGl3UVIchpyiYkvTZLvm4bA94A0qUhd+ny2Xq8Ob1srCKtiV3EilK8tXw 6BRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=bG5+Q/z9FvF9TdnhXONdktOd6VNu7JF6ugxgq3dSs7U=; b=pJZGSmnQPAazGDuwwV/XFDvuvTr9dyAWg0L3o3ul5eAIivY5kkDPgvC8Flx5d24Ule aTuPwWZvzypW3ZqLV6wFNDNgVIGYQHDdJvE/jWKz/qPIyiAe43YtEh4xdw0U4DKVfjDW VJ3QNFy28VB50GL+mV/r7AA7YnyfJKwFPJ6oxb8hnpqeDvvr17iovihSLQtB28y1Epgt om7VZ2HZz+djdcPKDnvRK/dWD3Ob4ZMclGsbF+DUz1AKPSefH+h59VomxO7/BEz3xAwz 6f7VfMfKyDItRyTarkTqV48XfO5v0y3vfbjBBsFMzMmIG7IgbPmddMJQ8lwqL75UjzMc 1Uow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=UTRswU+S; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cd16si2619822plb.47.2018.11.29.06.31.09; Thu, 29 Nov 2018 06:31:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=UTRswU+S; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388678AbeK3Bfl (ORCPT + 99 others); Thu, 29 Nov 2018 20:35:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:37684 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732139AbeK3Bfl (ORCPT ); Thu, 29 Nov 2018 20:35:41 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A58362146D; Thu, 29 Nov 2018 14:30:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1543501808; bh=aK9HG/37bRM8qOiiNdraJI4L2qEfzloicGqwadoqIgY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UTRswU+SpnkCg/idhHE3jv5hdLfZqZX2jt+dT74vIHN3JNQLP2+pfBtAaDESVdpKS S/MLUFfEiULTRIiljNVPtFd0MaiE+q3ICy1CFXuId1CQ+D8VRTewlHAYVQxVRJ78NY oksnzRkhOD1HYSrSGZLQSYBRdaOkbTXt2xydL7F4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Alexander Stein , Pankaj Bansal , Marc Kleine-Budde Subject: [PATCH 4.19 048/110] can: flexcan: Unlock the MB unconditionally Date: Thu, 29 Nov 2018 15:12:19 +0100 Message-Id: <20181129135923.203428995@linuxfoundation.org> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20181129135921.231283053@linuxfoundation.org> References: <20181129135921.231283053@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Pankaj Bansal commit 5178b7cd8e42448b1041716f124734eaaa36ca50 upstream. Unlock the MB irrespective of reception method being FIFO or timestamp based. It is optional but recommended to unlock Mailbox as soon as possible and make it available for reception. Reported-by: Alexander Stein Signed-off-by: Pankaj Bansal Cc: linux-stable Signed-off-by: Marc Kleine-Budde Signed-off-by: Greg Kroah-Hartman --- drivers/net/can/flexcan.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) --- a/drivers/net/can/flexcan.c +++ b/drivers/net/can/flexcan.c @@ -720,9 +720,14 @@ static unsigned int flexcan_mailbox_read priv->write(BIT(n - 32), ®s->iflag2); } else { priv->write(FLEXCAN_IFLAG_RX_FIFO_AVAILABLE, ®s->iflag1); - priv->read(®s->timer); } + /* Read the Free Running Timer. It is optional but recommended + * to unlock Mailbox as soon as possible and make it available + * for reception. + */ + priv->read(®s->timer); + return 1; }