Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2542849imu; Thu, 29 Nov 2018 06:39:02 -0800 (PST) X-Google-Smtp-Source: AFSGD/VD1L/i7hQbZmoI78xx7/AsXVbnku/QJlFFl4TJqURMY5zGPaisdLq0lpvH/2LIqmjegL85 X-Received: by 2002:a63:ce50:: with SMTP id r16mr1440595pgi.217.1543502342242; Thu, 29 Nov 2018 06:39:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543502342; cv=none; d=google.com; s=arc-20160816; b=IwufTYFSy6Oyo+VP0/qZhbUBHiDxmDMtfSo/YoJb8NCuM0XccJ74X+4s+SzQQpA5WT yu5YmJqiWSMUX2y7LvccDeiy0oJIREsy0yVc1mas8JW0w/+eZFVw5l4El57x8aIVyuCS eaXAOOgaCv+7oEMbZFpHoX9XneLQB6I5OAS336IRqBuu5W7ytTFoyHaqNwerQalW2X7h 8omQKfh8+bpLajWNuQ0uIde3LjQjgqWuUmGgNC5JR6Z5TUjumTvzbKpCdk8nTI5MN1R/ 2L+cC9Gm8Fw7UNkWjfuhAJVEom0FsNsTVKCXALEgwk+mWQ5KuwnvQWdswmjpg4kca3Ip YkBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=BsnM2JTeDOy2cywF9+UBNZTE10WUOsh4GbOw0ItFP8A=; b=SiJrNohCCPysersMvnD0NqbwsVWA3c01OrkIEUSJoi+CWJmY8BH4fuvd42n7RDP9gX ZLLftrq3StFdihLu2dWXc2dwhw1vKBYefm19rBwP7yZ9xZkbYnPN8VaNL1tn7sYD5PkX POEexbw8z9osqVZuiGn649Ot/q6llvQ/g9GBay5CAMSRxn5j9QRimp5IZCmbe2UYq0k4 6ILTdUy27byTyMn43gMFP7Cr/f0DG/eEfQQGz77GHvQNN6EqLP8+qonj+qE/3KxFOj6E 0SE40bVGgaEjfZCSxbBM9Y6hCkZwJTZV3j8TS1Qw9ZHjHgmkC8fzYuug3NZmd+LSrgKi 2e5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ZR20S7MI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u6si2520534pfb.92.2018.11.29.06.38.47; Thu, 29 Nov 2018 06:39:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ZR20S7MI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388783AbeK3BgB (ORCPT + 99 others); Thu, 29 Nov 2018 20:36:01 -0500 Received: from mail.kernel.org ([198.145.29.99]:38102 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728991AbeK3BgA (ORCPT ); Thu, 29 Nov 2018 20:36:00 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1437E2145D; Thu, 29 Nov 2018 14:30:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1543501827; bh=PVkWm2ooxq48zmLQ5B4G+gccdU/BC53mqFyomRE4Yog=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZR20S7MIMQO+L8Pmbz8fCNAzsilhacLRHXzkZSPWu0xseAJjZJR+KEedejN2IbLPH gFtz03s0bpwZtHZsNEjug+gP7gBC/s1lyuG+4hfZsnXnrDKpEl6GZste6ENvMLtKn1 hRUKWgVJwhMOmJA2AvORQpSvZUOVmZiBy34cKit4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Emmanuel Grumbach , Luca Coelho Subject: [PATCH 4.19 023/110] iwlwifi: mvm: support sta_statistics() even on older firmware Date: Thu, 29 Nov 2018 15:11:54 +0100 Message-Id: <20181129135922.192308861@linuxfoundation.org> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20181129135921.231283053@linuxfoundation.org> References: <20181129135921.231283053@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Emmanuel Grumbach commit ec484d03ef0df8d34086b95710e355a259cbe1f2 upstream. The oldest firmware supported by iwlmvm do support getting the average beacon RSSI. Enable the sta_statistics() call from mac80211 even on older firmware versions. Fixes: 33cef9256342 ("iwlwifi: mvm: support beacon statistics for BSS client") Cc: stable@vger.kernel.org # 4.2+ Signed-off-by: Emmanuel Grumbach Signed-off-by: Luca Coelho Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 4 ---- 1 file changed, 4 deletions(-) --- a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c @@ -4416,10 +4416,6 @@ static void iwl_mvm_mac_sta_statistics(s sinfo->filled |= BIT_ULL(NL80211_STA_INFO_SIGNAL_AVG); } - if (!fw_has_capa(&mvm->fw->ucode_capa, - IWL_UCODE_TLV_CAPA_RADIO_BEACON_STATS)) - return; - /* if beacon filtering isn't on mac80211 does it anyway */ if (!(vif->driver_flags & IEEE80211_VIF_BEACON_FILTER)) return;