Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2551578imu; Thu, 29 Nov 2018 06:46:57 -0800 (PST) X-Google-Smtp-Source: AFSGD/Wn8gQFezz6gDY+rjF5SeLgxMKaW5Z4ok6HJn6OBLIQ0OkekV+GFBnx81+b1ChPSgGeso9n X-Received: by 2002:a63:89c2:: with SMTP id v185mr1348272pgd.97.1543502817261; Thu, 29 Nov 2018 06:46:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543502817; cv=none; d=google.com; s=arc-20160816; b=WqA3jccZUq6doG8Tqhw7AhHhr8Iuux/BCPdd2FCP8D4IRlUjj/+uT4wPt8x4e/M6aT hopqKIqymZTiEYgmk7lLrsSf+yqYPyoV1YyKWEFwfyHl2noBDJF/nmKPSG491lY3pS8B e4d1TRBKEy/VD3WRjxJUy9oYPhi6JawO9hWTLKS42M4kEOdxw/u/ORKzWYJwwddceA7G Y40VfFc192QQgwrHSV+i/lLrOxKIuLTEUqk56wyv/3wKc++hzuwo5iCFl2MqjLvW0g0U aFZynjpBh0i2Ae54dR+kmf3dEAp7xYkytdt6WgH8zSlxrPDcr3qiJg2JKdgO/rxc5Bl+ Y71Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=XG1YNjkFb5rLlznM5fV/XXhtNgpMAU/H8IEqhZURpkc=; b=XjHP/F7/nwwlncyuyI41B0MJc9H0+BD9lKzdTCEaCa6yiukjK/+cue0ZE3i/93W7SL 4Ci5+msct8IKET7h8BRKirW/0V43QZBSI6Ls6FXlwzNVoNVmGCMOgSI2i8twBEgLeMYF +W3x75lJeTOiXXUUjrK69g8UOSlRJhpOHYpPPrULVgQwRRx34Xvs7xNsFA82ymfQEdOd 5R0X2Jzq1q0bi9/8RJWlOzIKw6DYdw2e1S/G2zLXXF54GCKlh9iE2wzspjPtTSjaaZnl hoJhtRCAWmI7QD3cE37braNfY+IUmB+Hg95uhxqgYzb43PlC12qIPd7N66CRwkqXsCY6 rGag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=hNFKeJ3O; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j5si2333561pfg.254.2018.11.29.06.46.41; Thu, 29 Nov 2018 06:46:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=hNFKeJ3O; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387603AbeK3Bcn (ORCPT + 99 others); Thu, 29 Nov 2018 20:32:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:32836 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731824AbeK3Bcn (ORCPT ); Thu, 29 Nov 2018 20:32:43 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0DDEB21473; Thu, 29 Nov 2018 14:27:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1543501630; bh=qYkcDCN8sB+JPlmhs261ZZpYSx/sTtR3Sz7Ow40k3g8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hNFKeJ3OGKmzizKZ6lj8osxyLW5uGCYKFF5t22kIGwXw6GbBe4wCvkbrCiPJ0Cqqh kVqwfwpRxxp0mrmxg0XO9+qeNxPdb1Dy8q7a1uusyUAHF2sKRIpp48Rtp/wz74ZR0r PpVUarJnWGsuPtU1Rb5F3xz5dc52juSyfurHocIc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Leo Sperling , Dmitry Torokhov , Sasha Levin Subject: [PATCH 4.14 076/100] Input: xpad - fix some coding style issues Date: Thu, 29 Nov 2018 15:12:46 +0100 Message-Id: <20181129140105.330211851@linuxfoundation.org> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20181129140058.768942700@linuxfoundation.org> References: <20181129140058.768942700@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 68c78d0155e37992268664e134996d2b140ddf38 ] Fix some coding style issues reported by checkpatch.pl. Mostly brackets in macros, spacing and comment style. Signed-off-by: Leo Sperling Signed-off-by: Dmitry Torokhov Signed-off-by: Sasha Levin --- drivers/input/joystick/xpad.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c index d2a1857fdae5..7e812a8877bc 100644 --- a/drivers/input/joystick/xpad.c +++ b/drivers/input/joystick/xpad.c @@ -89,8 +89,10 @@ #define XPAD_PKT_LEN 64 -/* xbox d-pads should map to buttons, as is required for DDR pads - but we map them to axes when possible to simplify things */ +/* + * xbox d-pads should map to buttons, as is required for DDR pads + * but we map them to axes when possible to simplify things + */ #define MAP_DPAD_TO_BUTTONS (1 << 0) #define MAP_TRIGGERS_TO_BUTTONS (1 << 1) #define MAP_STICKS_TO_NULL (1 << 2) @@ -391,15 +393,15 @@ static const signed short xpad_abs_triggers[] = { * match against vendor id as well. Wired Xbox 360 devices have protocol 1, * wireless controllers have protocol 129. */ -#define XPAD_XBOX360_VENDOR_PROTOCOL(vend,pr) \ +#define XPAD_XBOX360_VENDOR_PROTOCOL(vend, pr) \ .match_flags = USB_DEVICE_ID_MATCH_VENDOR | USB_DEVICE_ID_MATCH_INT_INFO, \ .idVendor = (vend), \ .bInterfaceClass = USB_CLASS_VENDOR_SPEC, \ .bInterfaceSubClass = 93, \ .bInterfaceProtocol = (pr) #define XPAD_XBOX360_VENDOR(vend) \ - { XPAD_XBOX360_VENDOR_PROTOCOL(vend,1) }, \ - { XPAD_XBOX360_VENDOR_PROTOCOL(vend,129) } + { XPAD_XBOX360_VENDOR_PROTOCOL((vend), 1) }, \ + { XPAD_XBOX360_VENDOR_PROTOCOL((vend), 129) } /* The Xbox One controller uses subclass 71 and protocol 208. */ #define XPAD_XBOXONE_VENDOR_PROTOCOL(vend, pr) \ @@ -409,7 +411,7 @@ static const signed short xpad_abs_triggers[] = { .bInterfaceSubClass = 71, \ .bInterfaceProtocol = (pr) #define XPAD_XBOXONE_VENDOR(vend) \ - { XPAD_XBOXONE_VENDOR_PROTOCOL(vend, 208) } + { XPAD_XBOXONE_VENDOR_PROTOCOL((vend), 208) } static const struct usb_device_id xpad_table[] = { { USB_INTERFACE_INFO('X', 'B', 0) }, /* X-Box USB-IF not approved class */ @@ -1578,6 +1580,7 @@ static void xpad_close(struct input_dev *dev) static void xpad_set_up_abs(struct input_dev *input_dev, signed short abs) { struct usb_xpad *xpad = input_get_drvdata(input_dev); + set_bit(abs, input_dev->absbit); switch (abs) { -- 2.17.1