Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 29 Nov 2018 19:01:32 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>,
        ckeepax@opensource.cirrus.com
Subject: Re: [PATCH 00/10] Regulator ena_gpiod fixups
Message-ID: <20181129190132.GM2089@sirena.org.uk>
References: <20181128104350.31902-1-linus.walleij@linaro.org>
 <CAMpxmJUsAccSKELNxn6DEWO6_3aCbzM=hZyaXUCr30S0-Eh0mA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="mDSUb3soQrPtHYgy"
Content-Disposition: inline
In-Reply-To: <CAMpxmJUsAccSKELNxn6DEWO6_3aCbzM=hZyaXUCr30S0-Eh0mA@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--mDSUb3soQrPtHYgy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Nov 29, 2018 at 07:38:20PM +0100, Bartosz Golaszewski wrote:

> I'm wondering if instead of using the non-devm variants of
> gpiod_get_*() routines, we shouldn't provide helpers in the regulator
> framework that would be named accordingly, for example:
> regulator_gpiod_get_optional() etc. even if all they do is call the
> relevant gpiolib function. Those helpers could then be documented as
> passing the control over GPIO lines over to the regulator subsystem.

> The reason for that is that most driver developers will automatically
> use devm functions whenever available and having a single non-devm
> function without any comment used in a driver normally using devres
> looks like a bug. Expect people sending "fixes" in a couple months.

I predict that people would then immediately start demanding devm_
variants of that function...

--mDSUb3soQrPtHYgy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlwAN4wACgkQJNaLcl1U
h9BdTAf9FuBzyCXH+8N0FZSbkFFEKvSA97LAbwYwv6lJWzQfkyYN/i7nFxAmyfKr
URMA7sxFMkIwXRvghNL7y9lyWoLhz5a+EWp2N8mAaTdEj8V1k+7dWC/vIX87w5Xq
3WtNZw/ZAIQAMy7YXN7rwa9Chi4v91TkhF2j7T5BgAnvtAaQC68ruCt9kCO3Hn86
Qh5TIkZL+LAcql7TvNEO2Dc5VDvOM81fygrR0ZuC7zdNhCILdjL9LV/ZPk3JLDaw
oZpf69eLs1U8cYFPUXKsr46OoaXUPyjQ/k+VMAyXYiM00yJXuDVTrlS4LpP05WCz
qRE0MnS3iD7HUSl6/AP93XaN2EMXFA==
=TSQQ
-----END PGP SIGNATURE-----

--mDSUb3soQrPtHYgy--