Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2930744imu; Thu, 29 Nov 2018 12:33:36 -0800 (PST) X-Google-Smtp-Source: AFSGD/WnvzZw5buOih1bsAbWtOfL7Qm5g2rrc1X8c+kDwOpnll1rD2QJsDpPePxK0pp6lDttahV9 X-Received: by 2002:a62:4e49:: with SMTP id c70mr2783970pfb.167.1543523616509; Thu, 29 Nov 2018 12:33:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543523616; cv=none; d=google.com; s=arc-20160816; b=cFX03qUJTR3ZvwIR5xm4kHlAQn22JC790IT4P/IlthXDM2EvO32V3Ut9FGffYCR6iE 2B4ffi/gmPFB3PDboFW7Jcne5FRLDMM41/8r4mPbcednbpW+SJ4ToVkxrlwnWyuwiFrw ZF0CSc0uAeVSjgEtVkedErQiwK4cZ219h5UJgSWQoO+BJ3l5zz5+w0Dq6gyF4VkR4not BKYdHNtiryLP7tagohR3Q0SGOKVtHOBtv4E9cRszH/zRaQVKq37cQgxgQ2HFmt3AfFl5 XioptjqnTw2Kuu043Xo+dTlxPIYrNZrWZVEUJIcrOBqkNzwQbFADLy1nizLIhuSPDypO Ab8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=nWgITe3FPummspeNoS4ZUCY7EDjHmPmOP03FidrfrhE=; b=k/mq2v8I057wr7ZBU4t5R6Hq9MCOnKJjP8KindnZMF1Gc+p4Yy96pu9zSEA5/YttL9 KSZV3O+zDs3LhSXnR9OTaGKL7qBpzCmJo6aYlkaH7InyuVRjZKSnOM1equqOIipfbWpj /kPaEodme/X64tud/hfKdPbR34wKAlJWBBcQCJnzRofyVUKzGBwuI6wi7n3JQnI9ltRP FJudpJQfOAQUuOOD0wxztMWa4l+5pRzBKqV/9bD2dTsCsYOEwcolqj/9FxRVY4GZ8/lV Hi5ihIN8k4YmXEEu7XjGrhTZma6PpLPY6lUtKJgjhaiGQwpZxdLmLSm6ukFG1saqkzLv BTiA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1-v6si3201329plr.113.2018.11.29.12.33.21; Thu, 29 Nov 2018 12:33:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726725AbeK3HjS (ORCPT + 99 others); Fri, 30 Nov 2018 02:39:18 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:39596 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726152AbeK3HjR (ORCPT ); Fri, 30 Nov 2018 02:39:17 -0500 Received: from akpm3.svl.corp.google.com (unknown [104.133.8.65]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id CE13888D; Thu, 29 Nov 2018 20:32:37 +0000 (UTC) Date: Thu, 29 Nov 2018 12:32:36 -0800 From: Andrew Morton To: Dave Rodgman Cc: Sergey Senozhatsky , "linux-kernel@vger.kernel.org" , nd , "herbert@gondor.apana.org.au" , "davem@davemloft.net" , Matt Sealey , "nitingupta910@gmail.com" , "rpurdie@openedhand.com" , "markus@oberhumer.com" , "minchan@kernel.org" , "sonnyrao@google.com" , "gregkh@linuxfoundation.org" Subject: Re: [PATCH 7/7] lib/lzo: separate lzo-rle from lzo Message-Id: <20181129123236.8e31034663cd391bf9c24c3e@linux-foundation.org> In-Reply-To: <293c53a6-3313-359a-c5d0-2e2fa453494a@arm.com> References: <20181127161913.23863-1-dave.rodgman@arm.com> <20181127161913.23863-8-dave.rodgman@arm.com> <20181129044333.GH6379@jagdpanzerIV> <293c53a6-3313-359a-c5d0-2e2fa453494a@arm.com> X-Mailer: Sylpheed 3.6.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 29 Nov 2018 10:21:53 +0000 Dave Rodgman wrote: > >> @@ -41,7 +41,7 @@ static DEFINE_IDR(zram_index_idr); > >> static DEFINE_MUTEX(zram_index_mutex); > >> > >> static int zram_major; > >> -static const char *default_compressor = "lzo"; > >> +static const char *default_compressor = "lzo-rle"; > > > > OK, so it's not just "separate lzo-rle", it's also "switch zram to > > a new compression algorithm by default". I'd say that usually I'd > > expect this to be separate patches. > > Yes, fair point. akpm has picked this up now though, so probably a bit > late to break it out into a separate patch? That's fine. akpm is flexible ;) Whatever produces the best overall result in the permanent record, please.