Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1504729681-3504-1-git-send-email-deller@gmx.de> <1504729681-3504-10-git-send-email-deller@gmx.de>
In-Reply-To: <1504729681-3504-10-git-send-email-deller@gmx.de>
From:   Kees Cook <keescook@chromium.org>
Date:   Thu, 29 Nov 2018 15:26:51 -0800
Message-ID: <CAGXu5jL3qs=YrXWesOueaZYZ8k1qjJ=1HYb9Rmfry8tzvaGY8w@mail.gmail.com>
Subject: Re: [PATCH 09/14] fs/pstore: Use %pS printk format for direct addresses
To:     Helge Deller <deller@gmx.de>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Petr Mladek <pmladek@suse.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Tony Luck <tony.luck@intel.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Sep 6, 2017 at 1:28 PM Helge Deller <deller@gmx.de> wrote:
>
> Use the %pS instead of the %pF printk format specifier for printing symbols
> from direct addresses. This is needed for the ia64, ppc64 and parisc64
> architectures.
>
> Signed-off-by: Helge Deller <deller@gmx.de>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Tony Luck <tony.luck@intel.com>

I missed this email from some time ago. I've now applied it, thanks!

-Kees

> ---
>  fs/pstore/inode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/pstore/inode.c b/fs/pstore/inode.c
> index fefd226..59f65d7 100644
> --- a/fs/pstore/inode.c
> +++ b/fs/pstore/inode.c
> @@ -116,7 +116,7 @@ static int pstore_ftrace_seq_show(struct seq_file *s, void *v)
>
>         rec = (struct pstore_ftrace_record *)(ps->record->buf + data->off);
>
> -       seq_printf(s, "CPU:%d ts:%llu %08lx  %08lx  %pf <- %pF\n",
> +       seq_printf(s, "CPU:%d ts:%llu %08lx  %08lx  %ps <- %pS\n",
>                    pstore_ftrace_decode_cpu(rec),
>                    pstore_ftrace_read_timestamp(rec),
>                    rec->ip, rec->parent_ip, (void *)rec->ip,
> --
> 2.1.0
>


-- 
Kees Cook