Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
To:     Andreas Kemnade <andreas@kemnade.info>, bcousson@baylibre.com,
        letux-kernel@openphoenux.org, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
        mturquette@baylibre.com, paul@pwsan.com, t-kristo@ti.com,
        tony@atomide.com
From:   Stephen Boyd <sboyd@kernel.org>
In-Reply-To: <20181110203115.13335-1-andreas@kemnade.info>
Cc:     Andreas Kemnade <andreas@kemnade.info>
References: <20181110203115.13335-1-andreas@kemnade.info>
Message-ID: <154353757335.88331.5161306764126530976@swboyd.mtv.corp.google.com>
User-Agent: alot/0.7
Subject: Re: [PATCH v2 0/3] mach-omap2: handle autoidle denial
Date:   Thu, 29 Nov 2018 16:26:13 -0800
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Andreas Kemnade (2018-11-10 12:31:12)
> On the gta04 with a dm3730 omap_hdq does not work properly when the
> device enters lower power states. Idling uart1 and 2 is enough
> to show up that problem, if there are no other things enabled.
> Further research reveals that hdq iclk must not be turned off during
> transfers, also according to the TRM. That fact is also correctly describ=
ed
> in the flags but the code to handle that is incomplete.
> =

> To handle multiple users of a single ick, autoidle is disabled
> when a user of that ick requires that (has the OCPIF_SWSUP_IDLE))
> =

> Changes since v1:
> - uses spinlocks instead of mutexes
> - invert counter logic
> - check whether clock type is basic
> =


I'm expecting someone like Tero or Tony to review this.