Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3150684imu; Thu, 29 Nov 2018 16:42:08 -0800 (PST) X-Google-Smtp-Source: AFSGD/UyZaP67Yo4Cv9cRwmiacwsyJI2Ddo0UDCmcwnFZ4pjTF+MHNltliQWXY/z92sW8y6omgA1 X-Received: by 2002:aa7:8608:: with SMTP id p8mr3613266pfn.125.1543538527983; Thu, 29 Nov 2018 16:42:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543538527; cv=none; d=google.com; s=arc-20160816; b=RYTDq8WGSZBpgLy4KuB2SLoLgKI06Zcddx8UYsHBiycQ2kdF1ETg552fGc/3C1VNKy 7Wn/zTUPdwUBsQfxuADazGuui9BUOOjBDIR6DvZ8SzH0eWeW2LQnHNeqDFKr1hVSN26g h7U4iwq8oC5LcfPiXfD/gdCimOh/2hMZhkKuU8PVQJ/OGNzGg5Xy3f+tKmqEjGOCJ2gm OccNgmi/ywRjjUL4VNM0hnQp3fErZg6rPWDKlucs8ccxlcYw/aFN2syO0SqrzrsVibfU u2YyI3UENFDXMvoTkqoScLwdjAwwXZGz4y04McMfNboCEpDazx38p0jxHWSWkNYiHUZu fgAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=V5rIEwW9EjTfjTCfJxWzE0pXhFFZR/7GOiBBNHjWMtQ=; b=Y4T6EhLoApNGBbN2ZltrDVCEHIyvcuN66EXYg2yry4fNGedFqrNKTH997OM9YM5dCm ukM/KnWV2Ih6rTYftl4ZHcta1PxObl7yt6vftNkiqBHbdxaLAIIef0HUXKDjwUzvXTIn 3PRFsgBEFPbkbf7vcPqElWDDa9WKR9WXmvpmbeLO3zI/KkMl8egxhUL12238vZKxtii7 X+olPwiv5NkUx8IPHQyrRH/aKNBsDpyFvXbHMmtdTz98+2Rd8f/qNZtHwKwvsbZQzXyt P6Y+C7nYHBZjt2vQUsSR7THrOC2bAgMj3zK7VgEO42g9ZKIgXM0jwzeLcee/0KVTpQ9M zYSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=nbeitbzL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 69si3486992pgc.164.2018.11.29.16.41.52; Thu, 29 Nov 2018 16:42:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=nbeitbzL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727170AbeK3Lsf (ORCPT + 99 others); Fri, 30 Nov 2018 06:48:35 -0500 Received: from mail-yw1-f66.google.com ([209.85.161.66]:35518 "EHLO mail-yw1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726393AbeK3Lsf (ORCPT ); Fri, 30 Nov 2018 06:48:35 -0500 Received: by mail-yw1-f66.google.com with SMTP id h32so1591482ywk.2 for ; Thu, 29 Nov 2018 16:41:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=V5rIEwW9EjTfjTCfJxWzE0pXhFFZR/7GOiBBNHjWMtQ=; b=nbeitbzLLkUdVVpiO/8CtMUdHtOuBKeCgZN0W8PlIvw78a08YqSZMC50WwBvB1NXlX rJeAWW8yFQYkD0pzWzwKqo9VIU7SriqTrZuZv6S0qpbrrCD5FevKJA/oe9ZwhdDmsH1j 5QsIZU8g6qNog1DdHRD+ctZpAQ0ijB/GS8+6s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=V5rIEwW9EjTfjTCfJxWzE0pXhFFZR/7GOiBBNHjWMtQ=; b=AjnuncYg64BDfZer1VmzHebQ469d2r5qWjWif7CAG3D4ogBDFYfNNCTiZiCu4Y8c0/ Q0XugMYv6sS29+H4xvrqt7COCeDp6MsTRMPsXF7lo0MShbSluIhvbLTY0ImIcVKDW7do QRbeoDnhhOp+XaXc9uNCa+l/BhzlIOH7OJwLI+NQV09O8yiZ43m3A1QXJm/88xF7prQ6 pO9sFih0npo38FlgPFAGCs49N9UsQLtr8/uutEKjFUUyT+kVlQskSehs1m6UgwkqLh4h iUQeTW5/w9VGxiWpALQKGG7Z4aAmPSB9p5WZttWszysD07JrmDgIycAvE2LMSYhmvN02 kjhg== X-Gm-Message-State: AA+aEWbuNyjmUushpNh/SDYSeVcvofMFQM+TvdbrJ3qcydpvnMbF/PGC aYzW+GGvZznLbPmk+ebG/XlqF2DhEhM= X-Received: by 2002:a81:4757:: with SMTP id u84-v6mr3871053ywa.343.1543538469320; Thu, 29 Nov 2018 16:41:09 -0800 (PST) Received: from mail-yw1-f53.google.com (mail-yw1-f53.google.com. [209.85.161.53]) by smtp.gmail.com with ESMTPSA id j6sm1019358ywi.110.2018.11.29.16.41.08 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Nov 2018 16:41:08 -0800 (PST) Received: by mail-yw1-f53.google.com with SMTP id x2so1577308ywc.9 for ; Thu, 29 Nov 2018 16:41:08 -0800 (PST) X-Received: by 2002:a81:2f0f:: with SMTP id v15mr3909249ywv.124.1543538467761; Thu, 29 Nov 2018 16:41:07 -0800 (PST) MIME-Version: 1.0 References: <1504729681-3504-1-git-send-email-deller@gmx.de> <1504729681-3504-10-git-send-email-deller@gmx.de> <20181129234912.GA7787@agluck-desk> In-Reply-To: <20181129234912.GA7787@agluck-desk> From: Kees Cook Date: Thu, 29 Nov 2018 16:40:56 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 09/14] fs/pstore: Use %pS printk format for direct addresses To: Tony Luck Cc: Helge Deller , LKML , Sergey Senozhatsky , Petr Mladek , Andrew Morton Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 29, 2018 at 3:49 PM Luck, Tony wrote: > > On Thu, Nov 29, 2018 at 03:26:51PM -0800, Kees Cook wrote: > > On Wed, Sep 6, 2017 at 1:28 PM Helge Deller wrote: > > > > > > Use the %pS instead of the %pF printk format specifier for printing symbols > > > from direct addresses. This is needed for the ia64, ppc64 and parisc64 > > > architectures. > > > > > > Signed-off-by: Helge Deller > > > Cc: Kees Cook > > > Cc: Tony Luck > > > > I missed this email from some time ago. I've now applied it, thanks! > > Though it isn't really needed any more. See > > 04b8eb7a4ccd ("symbol lookup: introduce dereference_symbol_descriptor()") > > which is part of the plan to deprecate %pF Ah-ha! Okay then, nevermind. :) Thanks! -- Kees Cook