Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] nvme-rdma: complete requests from ->timeout
To:     Jaesoo Lee <jalee@purestorage.com>, keith.busch@intel.com,
        axboe@fb.com, hch@lst.de
Cc:     linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
        psajeepa@purestorage.com, roland@purestorage.com,
        ashishk@purestorage.com
References: <1543535954-28073-1-git-send-email-jalee@purestorage.com>
From:   Sagi Grimberg <sagi@grimberg.me>
Message-ID: <cc7cbad6-0e7d-8328-c602-61d659c3a7de@grimberg.me>
Date:   Thu, 29 Nov 2018 17:30:25 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <1543535954-28073-1-git-send-email-jalee@purestorage.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> This does not hold at least for NVMe RDMA host driver. An example scenario
> is when the RDMA connection is gone while the controller is being deleted.
> In this case, the nvmf_reg_write32() for sending shutdown admin command by
> the delete_work could be hung forever if the command is not completed by
> the timeout handler.

If the queue is gone, this means that the queue has already flushed and
any commands that were inflight has completed with a flush error
completion...

Can you describe the scenario that caused this hang? When has the
queue became "gone" and when did the shutdown command execute?