Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 30 Nov 2018 13:12:01 +1100
From:   Stephen Rothwell <sfr@canb.auug.org.au>
To:     Andy Gross <andy.gross@linaro.org>
Cc:     Stephen Boyd <swboyd@chromium.org>, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        kbuild test robot <lkp@intel.com>,
        Jordan Crouse <jcrouse@codeaurora.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Evan Green <evgreen@chromium.org>,
        Rob Clark <robdclark@gmail.com>
Subject: Re: [PATCH] drm: msm: Check cmd_db_read_aux_data() for failure
Message-ID: <20181130131201.6fc91dcd@canb.auug.org.au>
In-Reply-To: <20181129224234.GD32306@hector.attlocal.net>
References: <20181129163826.178670-1-swboyd@chromium.org>
        <20181129223600.GC32306@hector.attlocal.net>
        <20181129224234.GD32306@hector.attlocal.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 boundary="Sig_/uTnMOcHV6Tw7mxJCfUrnTQC"; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--Sig_/uTnMOcHV6Tw7mxJCfUrnTQC
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Andy,

On Thu, 29 Nov 2018 16:42:34 -0600 Andy Gross <andy.gross@linaro.org> wrote:
>
> On Thu, Nov 29, 2018 at 04:36:00PM -0600, Andy Gross wrote:
> > On Thu, Nov 29, 2018 at 08:38:26AM -0800, Stephen Boyd wrote: =20
> > > We need to check the call to cmd_db_read_aux_data() for the error cas=
e,
> > > so that we don't continue and use potentially uninitialized values for
> > > 'pri_count' and 'sec_count'. Otherwise, we get the following compiler
> > > warnings:
> > >=20
> > >    drivers/gpu/drm/msm/adreno/a6xx_gmu.c: In function 'a6xx_gmu_rpmh_=
arc_votes_init.isra.12':
> > >    drivers/gpu/drm/msm/adreno/a6xx_gmu.c:943:12: warning: 'pri_count'=
 is used uninitialized in this function [-Wuninitialized]
> > >      pri_count >>=3D 1;
> > >                ^~~
> > >    drivers/gpu/drm/msm/adreno/a6xx_gmu.c:948:12: warning: 'sec_count'=
 may be used uninitialized in this function
> > > [-Wmaybe-uninitialized]
> > >      sec_count >>=3D 1;
> > >                ^~~
> > >=20
> > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > > Reported-by: kbuild test robot <lkp@intel.com>
> > > Cc: Jordan Crouse <jcrouse@codeaurora.org>
> > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> > > Cc: Evan Green <evgreen@chromium.org>
> > > Cc: Jordan Crouse <jcrouse@codeaurora.org>
> > > Cc: Rob Clark <robdclark@gmail.com>
> > > Fixes: ed3cafa79ea7 ("soc: qcom: cmd-db: Stop memcpy()ing in cmd_db_r=
ead_aux_data()")
> > > Signed-off-by: Stephen Boyd <swboyd@chromium.org> =20
>=20
> On second thought, this needs to go through drm tree.

Why?  The commit that introduces the warnings is only in the qcom
tree ...


--=20
Cheers,
Stephen Rothwell

--Sig_/uTnMOcHV6Tw7mxJCfUrnTQC
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAlwAnHEACgkQAVBC80lX
0Gzm5QgAoS5hbEm2DH6OlupYdISzBShylvu98CN3kkwvnYnWUaqc8FZ0RcVRRbdN
T9E2kznxCpp0dyan/ZEw+5w/RtbKqurg33bGnVEGljZ9XdskEtc3bv/wVqGIvNrN
wWN0pss6sjSi9r/SezK46NTq/9deR6Dm41xvRv6M62yesTSjp1/BssvGPQGm6SLQ
GIjXIR1wYy1jFKZGL3UgruwCHg1wb3TuvSsZmWhoIXjSdjR0Q1zhg27YWeDSit70
sihng+14RHSXHYbOYbPD0EdVcl+TLqlR8uMoyE8bVUPucJkhgCTVz2ba3wqPTw0O
EbJdRFtVUaohn2apbPGjpxY9CGEhCw==
=SDX4
-----END PGP SIGNATURE-----

--Sig_/uTnMOcHV6Tw7mxJCfUrnTQC--