Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3251254imu; Thu, 29 Nov 2018 19:01:19 -0800 (PST) X-Google-Smtp-Source: AFSGD/UAbnIL62xsKNCVoMd3tpGY9rM4e0wZMVOc1OVWeDbBhQwlSllBj6VmF7tCe3U2thjCjjwi X-Received: by 2002:a17:902:4623:: with SMTP id o32-v6mr3937424pld.187.1543546879436; Thu, 29 Nov 2018 19:01:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543546879; cv=none; d=google.com; s=arc-20160816; b=tTrMw4/rTT4vk3gfxH9e/393tUZQQp4KSqyDslPKUins3/B8CN1+an9f8DnB+LWwzN n0lR2gGO9zvPfrmGUu9Q2OH6IXCZOcMAW3gXVm4ejMwMk++g8Lab21Mu0MxS0ym51wmK JH8SQalzl/AD/a3uJ4WYExWpsl0REl2hljUwIO8VLftZiyHigxF74iSfx+4tNniB1jh8 X8fCzeQyHT63cDUAZbDyzwXZKQy2htEhWGBLwLo3gTmoiJKy6Thnr3/BNkzUks3aLwyp X6srq1gUIMGmUPKaTcsQICJK5r31H1XGGWcJqeQsHQWvHm4vw30xSdceKHoAyYcGK7zV onZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=7ef2Ws1xUU/zS+Rm5Jt+e01hr2n1VZaVyu3DNKm3dTg=; b=KYwpEct0SLk/F7Ds2XrSORKGLQlfHM8DRL34VJC/etS/ze0rtXJ9MxzD2nU2gQciWF B/xV/I7mC+hLwLv2QQ/4zYG+3AtkHte+2Koj9YGeQ3mqWSZ+kKbcSDWsZrSX1tvqghdd 82v6iTErZXoZL/4RHWBjQtJEy6iegL0cwn4NFYwEvNvj44EWXyqBn+zBryFYqFySE72P MCzldud4Wm/dyF6iGO3GgzyThx1LNGfoCh659Uu24kIzxG/oJjmE8SOjleSgEwRx20UM jqBXc6u8qG+wmhz+RNjI0g6d+ued+79ayqwPZowOrswyfwCHhQMvTQHMdgD/BGo5u7+G xNKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=gEUtLls1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i18si3755041pgl.414.2018.11.29.19.01.02; Thu, 29 Nov 2018 19:01:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=gEUtLls1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726915AbeK3OIM (ORCPT + 99 others); Fri, 30 Nov 2018 09:08:12 -0500 Received: from hqemgate16.nvidia.com ([216.228.121.65]:11752 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726161AbeK3OIM (ORCPT ); Fri, 30 Nov 2018 09:08:12 -0500 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 29 Nov 2018 19:00:31 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Thu, 29 Nov 2018 19:00:26 -0800 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Thu, 29 Nov 2018 19:00:26 -0800 Received: from [10.19.225.182] (172.20.13.39) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 30 Nov 2018 03:00:23 +0000 Subject: Re: [PATCH v4 3/3] thermal: tegra: parse sensor id before sensor register To: Eduardo Valentin CC: , , , , , References: <1543486183-2868-1-git-send-email-wni@nvidia.com> <1543486183-2868-4-git-send-email-wni@nvidia.com> <20181129164656.GA2688@localhost.localdomain> From: Wei Ni Message-ID: <19b6f139-c54c-6bf7-45ab-6e8bcbf8e6d8@nvidia.com> Date: Fri, 30 Nov 2018 11:00:21 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181129164656.GA2688@localhost.localdomain> X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL101.nvidia.com (172.20.187.10) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1543546831; bh=7ef2Ws1xUU/zS+Rm5Jt+e01hr2n1VZaVyu3DNKm3dTg=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=gEUtLls12xtp6VJAICWfdj+2d2lAcAiFgOBGD+ygHL6P7wdDfJngDWHULZcqO4jjy FZpgWTkTQR3ID3OQmGEHJQAeI3zOJ5P5rQSmsfr6dUZRsJSuScIdp9pTvBcIrLgpFL xz6T8aPT24+mHnPGqa66VA3z92ZnrDR21qZ0f4tQ6Qq33usTwx9RlIf8ILyB28jdX/ vJWZlQ7rX5Bu2QBKyzVxT80d3F/zJQdbcFC2ydOqZU+yuVVNsG78ZhPmWHHwAeTyHK ainPhxWI/bqsjZFycwoSU3XlyNG9XzdBOdRRgWk7P61sAWZPr2R56vIughJx6ZmH3/ DudGZolkDpZvA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/11/2018 12:46 AM, Eduardo Valentin wrote: > On Thu, Nov 29, 2018 at 06:09:43PM +0800, Wei Ni wrote: >> Since different platforms may not support all 4 >> sensors, so the sensor registration may be failed. >> Add codes to parse dt to find sensor id which >> need to be registered. So that the registration >> can be successful on all platform. >> >> Signed-off-by: Wei Ni >> --- >> drivers/thermal/tegra/soctherm.c | 46 ++++++++++++++++++++++++++++++++++++++-- >> 1 file changed, 44 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c >> index 375cadbc24cd..bdc660f2794a 100644 >> --- a/drivers/thermal/tegra/soctherm.c >> +++ b/drivers/thermal/tegra/soctherm.c >> @@ -1224,6 +1224,42 @@ static void soctherm_init(struct platform_device *pdev) >> tegra_soctherm_throttle(&pdev->dev); >> } >> >> +static bool tegra_soctherm_find_sensor_id(unsigned int sensor_id) >> +{ >> + bool ret = false; >> + struct of_phandle_args sensor_specs; >> + struct device_node *np, *sensor_np; >> + >> + np = of_find_node_by_name(NULL, "thermal-zones"); >> + if (!np) >> + return ret; >> + >> + sensor_np = of_get_next_child(np, NULL); >> + for_each_available_child_of_node(np, sensor_np) { >> + if (of_parse_phandle_with_args(sensor_np, "thermal-sensors", >> + "#thermal-sensor-cells", >> + 0, &sensor_specs)) >> + continue; >> + >> + if (sensor_specs.args_count != 1) { >> + WARN(sensor_specs.args_count != 1, >> + "%s: wrong cells in sensor specifier %d\n", >> + sensor_specs.np->name, sensor_specs.args_count); >> + continue; >> + } >> + >> + if (sensor_specs.args[0] == sensor_id) { >> + ret = true; >> + break; >> + } >> + } >> + >> + of_node_put(np); >> + of_node_put(sensor_np); >> + >> + return ret; >> +} >> + >> static const struct of_device_id tegra_soctherm_of_match[] = { >> #ifdef CONFIG_ARCH_TEGRA_124_SOC >> { >> @@ -1365,13 +1401,16 @@ static int tegra_soctherm_probe(struct platform_device *pdev) >> zone->sg = soc->ttgs[i]; >> zone->ts = tegra; >> >> + if (!tegra_soctherm_find_sensor_id(soc->ttgs[i]->id)) >> + continue; >> + > > > Instead of matching driver id with DT id presence, wouldnt make sense to > simply have DT with the sensors that makes sense for that platform? > > I am failing to understand why you need to go over and find ids. As discussed with Daniel several days ago, this driver will always try to register 4 thermal zones, including cpu, gpu, mem and pll, but some platform doesn't need to support all of them, so the thermal zone registration will be failed. In previous patches, we just ignore the failure and continue to register next sensors, but Daniel think it's not good. And per his suggestion, we refer to the qoriq thermal driver to parse dt to get sensor_id, so that we can make the registration to be successful. Wei. > >> z = devm_thermal_zone_of_sensor_register(&pdev->dev, >> soc->ttgs[i]->id, zone, >> &tegra_of_thermal_ops); >> if (IS_ERR(z)) { >> err = PTR_ERR(z); >> - dev_err(&pdev->dev, "failed to register sensor: %d\n", >> - err); >> + dev_err(&pdev->dev, "failed to register sensor %s: %d\n", >> + soc->ttgs[i]->name, err); >> goto disable_clocks; >> } >> >> @@ -1434,6 +1473,9 @@ static int __maybe_unused soctherm_resume(struct device *dev) >> struct thermal_zone_device *tz; >> >> tz = tegra->thermctl_tzs[soc->ttgs[i]->id]; >> + if (!tz) >> + continue; >> + >> err = tegra_soctherm_set_hwtrips(dev, soc->ttgs[i], tz); >> if (err) { >> dev_err(&pdev->dev, >> -- >> 2.7.4 >>