Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3256610imu; Thu, 29 Nov 2018 19:08:37 -0800 (PST) X-Google-Smtp-Source: AFSGD/V5avGWSwP4NfLagK52/EIc2dk/tUKgmJyrN3R+nugjFM1gtQ+pd5Qy5cogyDuCnX5vZLy1 X-Received: by 2002:a63:554b:: with SMTP id f11mr3513458pgm.37.1543547317916; Thu, 29 Nov 2018 19:08:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543547317; cv=none; d=google.com; s=arc-20160816; b=a4yT+J/XE64ZFHkkqhdVhHpnNNLJ8xWEIgrvzsk+Sx85cgX2VQ2DIGbzfdtSt/2ntO xN6pBhDPFatY1HrnxM4mYmqadbJijBzUR6rWuYRQTEc4F375Xmkw4DIXkV4p7VcWvo4k bJLRUHEbUJMqDsWnHnRTZZE85jp6ckBK7lW19tESGihZyjLAtTu1R5r142pcFFx+Imgd 0aj2DUbcFtf7kfmd58SMJpJ22NK8afD8r1C5Xg+HTU5+fwEcE5aKnAWxBZnu4fQnTOQx Eul0VHUqAoNTcPU80rkDnq5EAEJ/L/yoNZH7N7d58ZjeB2I0JvRnZC4ah/IpFn/sY8+V rQKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=YRKXUlBstRrLkeRgSYEE/JKNdSIS2sd/PSlpHIO88ME=; b=NR6RpD+8AvG4koI1nAdrjW8wRAEM7YTI7g2XM8xsQbhjnhvPBixE8nJkezodV4sm1M typpKvXKvbiNSjnc3y2zNjm7LuqlDHS9uqII6DqVGA0PROuUfL2jgBXFovF8Jep8pya5 fdyBpU9+/HmlN2dN7EnIYLUyopXIT36mJuWg1LqRbTFp5/goZuUsCExZTHG8BCkC/XYG ehRUsGjL/+bz6dTljt/I73g2xkKAxnuzBkQEA64Eu3qYyv3S5FE9JsxXjfzPDSkomh/C l9UeVarLGXubAevumRy4OljPJ/YZ+4biYEno+uRGeLTbXB0D2s3fciLockXsimIlC2Ww gWSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=Jb5EPmRV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o12si3704299pgn.145.2018.11.29.19.08.23; Thu, 29 Nov 2018 19:08:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=Jb5EPmRV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726609AbeK3OPf (ORCPT + 99 others); Fri, 30 Nov 2018 09:15:35 -0500 Received: from hqemgate16.nvidia.com ([216.228.121.65]:12123 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726161AbeK3OPe (ORCPT ); Fri, 30 Nov 2018 09:15:34 -0500 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 29 Nov 2018 19:07:52 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Thu, 29 Nov 2018 19:07:47 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Thu, 29 Nov 2018 19:07:47 -0800 Received: from [10.19.225.182] (10.124.1.5) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 30 Nov 2018 03:07:45 +0000 Subject: Re: [PATCH] thermal: tegra: add get_trend ops To: Eduardo Valentin CC: Thierry Reding , , , , References: <1542705077-29697-1-git-send-email-wni@nvidia.com> <20181120153833.GB28796@ulmo> <20181129170145.GG2688@localhost.localdomain> From: Wei Ni Message-ID: Date: Fri, 30 Nov 2018 11:07:42 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181129170145.GG2688@localhost.localdomain> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL101.nvidia.com (172.20.187.10) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1543547272; bh=YRKXUlBstRrLkeRgSYEE/JKNdSIS2sd/PSlpHIO88ME=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=Jb5EPmRVRK1512VXrpuDmgT06jvLy2XqJaZcqcw02tb6xEBrkRcGC1geqtoSsYE1T PTRX2TO2dz1M9w9ZsNzo2GqM0XSU2+gO54VXVv6Mny7kqRnNS6gzgvIiU1+aFCs/pd 27qc0TzsBAlFQuRdmwAmvs8tj03oCG1W4aF84KfyJmh4iuJ8NG4bWigDQ+QGkmfLZC 1RMQSOotZW9ZfZqO0lODgJksWmKgAh2wrpnHK306R7x2ZVfDu38BA9VMpOsg1uGFTc u3yEVsZIMkSs4NM5Dq1UT+bzxu7d5wOA129pCqyWW0rVFDfneDrfy+pb5kXbt80WhW vGF1WAjRFJinQ== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/11/2018 1:01 AM, Eduardo Valentin wrote: > On Wed, Nov 21, 2018 at 02:36:10PM +0800, Wei Ni wrote: >> >> >> On 20/11/2018 11:38 PM, Thierry Reding wrote: >>> On Tue, Nov 20, 2018 at 05:11:17PM +0800, Wei Ni wrote: >>>> Add support for get_trend ops that allows soctherm >>>> sensors to be used with the step-wise governor. >>>> >>>> Signed-off-by: Wei Ni >>>> --- >>>> drivers/thermal/tegra/soctherm.c | 34 ++++++++++++++++++++++++++++++++++ >>>> 1 file changed, 34 insertions(+) >>>> >>>> diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c >>>> index ed28110a3535..d2951fbe2b7c 100644 >>>> --- a/drivers/thermal/tegra/soctherm.c >>>> +++ b/drivers/thermal/tegra/soctherm.c >>>> @@ -488,9 +488,43 @@ static int tegra_thermctl_set_trip_temp(void *data, int trip, int temp) >>>> return 0; >>>> } >>>> >>>> +static int tegra_thermctl_get_trend(void *data, int trip, >>>> + enum thermal_trend *trend) >>>> +{ >>>> + struct tegra_thermctl_zone *zone = data; >>>> + struct thermal_zone_device *tz = zone->tz; >>>> + int trip_temp, temp, last_temp, ret; >>>> + >>>> + if (!tz) >>>> + return -EINVAL; >>>> + >>>> + ret = tz->ops->get_trip_temp(zone->tz, trip, &trip_temp); >>>> + if (ret) >>>> + return ret; >>>> + >>>> + mutex_lock(&tz->lock); >>>> + temp = tz->temperature; >>>> + last_temp = tz->last_temperature; >>>> + mutex_unlock(&tz->lock); >>>> + >>>> + if (temp > trip_temp) { >>>> + if (temp >= last_temp) >>>> + *trend = THERMAL_TREND_RAISING; >>>> + else >>>> + *trend = THERMAL_TREND_STABLE; >>>> + } else if (temp < trip_temp) { >>>> + *trend = THERMAL_TREND_DROPPING; >>>> + } else { >>>> + *trend = THERMAL_TREND_STABLE; >>>> + } >>>> + >>>> + return 0; >>>> +} >>> >>> This looks like a reimplementation of the get_tz_trend() helper. Is >>> seems like that helper already has everything we need. Perhaps this >>> isn't working because of-thermal installs of_thermal_get_trend(), a >>> function that returns -EINVAL if the driver doesn't implement the >>> ->get_trend() callback. >> >> 1. The get_tz_trend() helper can work, because it has: >> if (tz->emul_temperature || !tz->ops->get_trend || >> tz->ops->get_trend(tz, trip, &trend)) { >> ... >> } >> the tz->ops->get_trend is of_thermal_get_trend(). If without special >> get_trend(), it will return -EINVAL, so it will implement the if block >> to get the "trend". If we have the special get_trend(), then the >> of_thermal_get_trend() will return 0, so this helper will not implement >> the if block, it will get the "trend" from the special get_trend(). > > The idea of the helper is to provide a trend in case drivers dont have > a specific way of doing so. Yes, thanks for your explanation. > >> >> 2. There has a little difference between the helper and our special >> callback. The tegra_thermctl_get_trend() consider the trip_temp, but the >> get_tz_trend() helper didn't. >> > > Yeah, if you are computing trend towards a trip, then yes, that is > different and this patch is needed. > >>> >>> Perhaps a better way would be to do something like this in >>> thermal_zone_of_add_sensor(): >>> >>> if (ops->get_trend) >>> tzd->ops->get_trend = of_thermal_get_trend; >>> >>> That's similar to how ->set_trips() and ->set_emul_temp() are set up >>> and should make sure that get_tz_trend() will do the right thing for >>> all drivers that don't implement a special ->get_trend(). >> >> As above description, I think the of_thermal_get_trend() already can >> handle this case, doesn't need to change. >> >> Wei. >> >>> >>> Thierry >>>