Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3278553imu; Thu, 29 Nov 2018 19:40:57 -0800 (PST) X-Google-Smtp-Source: AFSGD/Vac5Uyhyc49qrteXaR5oSGzWX4TIuiE2HgfotjeDraKT5IjObNBUcIEL6goIsDr37KZjhs X-Received: by 2002:a63:ac1a:: with SMTP id v26mr3539585pge.293.1543549257582; Thu, 29 Nov 2018 19:40:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543549257; cv=none; d=google.com; s=arc-20160816; b=tHtvdwtfIq73U/afcv7Z+oT/q7MUCtmhOxGJSjLjCu6xITsKaTMmstsyuz5+U+dAVM SIo20GjdfyvLnIU3O+/iVU+BZ5JwVuGKnsj75/eCU4K4ZYImWfbV+UyfjPCpAM5XoIGB RnpI0/dmp8kkuwrXlPml8XGMFsPENrOe76aRV21c1NMKXFgNEeQGkwNZhEkWztc50dHb IhzgWidgjjpDlhy05BVVc2mp6vmvQgTenXJb6Hs1dBEvW0fs7YFAdvgB8GvMPfPXUfa/ Mj9Ggi1Zk+vmwB0vtjzOFmtusos7pjlebXm7nQyq68rsHRkHJIUb4Lh9gqhremaEe7+U 9Mdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=MOscoK7YgjjO9zcvs2Z8lH/CUSAqck4kqeux+9WRBXk=; b=x6Huk720YzrkNVVvzsREVZy9azI47GyGyVKv1m9fnzuu+844wYY1n+RgIjqFy66Gd5 p21WtuBHvXGTFX6iV++xq0Plia5qHmMyQsC0D6E1L40R+nQZ3ZHV70H0HRaSCMeLYpQ6 ISecS6TI9icpvreyJihwvkgZ+x8XraKpNnUeushHKKqQDoVJ/vIA0KRWALiSbTrsC/OE Nq9DRzaGrHj+hM6NkRNkG2+pFe97Ge/NRfWX1sormztN2na978H+5FkbghJQmcAEO2Yq dNlPtPJYvDPqx5FreHtvMhIf+AKPvQFqiM8rRNXfajANAsFYsKbwDAAq3ldSOi2b9AtN 84Lw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q5si3889553pgr.435.2018.11.29.19.40.42; Thu, 29 Nov 2018 19:40:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726521AbeK3Or5 (ORCPT + 99 others); Fri, 30 Nov 2018 09:47:57 -0500 Received: from mail-pf1-f182.google.com ([209.85.210.182]:45028 "EHLO mail-pf1-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726161AbeK3Or5 (ORCPT ); Fri, 30 Nov 2018 09:47:57 -0500 Received: by mail-pf1-f182.google.com with SMTP id u6so2077884pfh.11; Thu, 29 Nov 2018 19:40:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MOscoK7YgjjO9zcvs2Z8lH/CUSAqck4kqeux+9WRBXk=; b=LN20O87mZHlzugN3fwUF4Nf6es+emJzuPNWqOY3wIOKvC4Vl/M5RAsZUJ6pMAZDoiZ JtiVwpA3HXKJMmTPPI1/+OAZdtgWOt4/58Dv9pABbaVG+kx2v2jUiiJoGNe6hkWTj7N6 6C3NpVOblvhVcC3ZArvyZi/VyO/Cu3ESY7tGpMLQboDq7ofsGVnHdj80+JOFIZIuZJ/O qbVZcpsN5qv+hB/ZOm4XlXGCvL7WXGFohM2E5FCQO/eWOtGDp6snm4ROmATAdg5v3+7r 4EUOpa2HiTqCKZCan/Dl3hvrZkIsFirH45MvpHLUOkR0e76Pv9VTh8vHclIfudkJ77kH x2YA== X-Gm-Message-State: AA+aEWa2CX/gPvri3mfcVuXfktgVBRnV0E+mffOXUtIhSchtiMh1g3Ad fZuCKYQ0b4DjUy/GYoSMbLc= X-Received: by 2002:a62:1e45:: with SMTP id e66mr3998635pfe.152.1543549205805; Thu, 29 Nov 2018 19:40:05 -0800 (PST) Received: from garbanzo.do-not-panic.com (c-73-71-40-85.hsd1.ca.comcast.net. [73.71.40.85]) by smtp.gmail.com with ESMTPSA id y66-v6sm4854884pfy.24.2018.11.29.19.40.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 29 Nov 2018 19:40:04 -0800 (PST) Received: by garbanzo.do-not-panic.com (sSMTP sendmail emulation); Thu, 29 Nov 2018 19:40:01 -0800 Date: Thu, 29 Nov 2018 19:40:01 -0800 From: Luis Chamberlain To: Brendan Higgins Cc: gregkh@linuxfoundation.org, keescook@google.com, shuah@kernel.org, joel@jms.id.au, mpe@ellerman.id.au, joe@perches.com, brakmo@fb.com, rostedt@goodmis.org, Tim.Bird@sony.com, khilman@baylibre.com, julia.lawall@lip6.fr, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, jdike@addtoit.com, richard@nod.at, linux-um@lists.infradead.org, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, robh@kernel.org, dan.j.williams@intel.com, linux-nvdimm@lists.01.org, kieran.bingham@ideasonboard.com, frowand.list@gmail.com, knut.omang@oracle.com Subject: Re: [RFC v3 07/19] kunit: test: add initial tests Message-ID: <20181130034001.GM18410@garbanzo.do-not-panic.com> References: <20181128193636.254378-1-brendanhiggins@google.com> <20181128193636.254378-8-brendanhiggins@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181128193636.254378-8-brendanhiggins@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 28, 2018 at 11:36:24AM -0800, Brendan Higgins wrote: > Add a test for string stream along with a simpler example. > > Signed-off-by: Brendan Higgins > --- > kunit/Kconfig | 12 ++++++ > kunit/Makefile | 4 ++ > kunit/example-test.c | 88 ++++++++++++++++++++++++++++++++++++++ BTW if you need another more concrete but very simple example I think it may be possible to port tools/testing/selftests/sysctl/sysctl.sh + lib/test_sysctl.c into a kunit test. Correct me if I'm wrong. I think that would show the differences clearly between selftests and kunit as well. Luis