Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3428701imu; Thu, 29 Nov 2018 23:29:29 -0800 (PST) X-Google-Smtp-Source: AFSGD/XAkAanoR3imz8FH6FLSmviqSRwFn7QTKRXYRpeK8K9WYNzSwGFKab5xgV4hlgcuOy01h5Q X-Received: by 2002:a62:e511:: with SMTP id n17mr4541828pff.71.1543562969697; Thu, 29 Nov 2018 23:29:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543562969; cv=none; d=google.com; s=arc-20160816; b=Gzql6bjjSeaNkUSpucYhZK+zyaUPbDUDW/2TJwCw6TjZ+UiMme7lUglQKRWcT7hZeU RLE8W3+QKl6bG6KCTssLcv3HM2qT7P9W83P8CpCAazBkL5CTUkayTTtrPEueUxaCd/85 J6DbNIIhAsrlf9t1ZifjdazY4AWU9fkLtf3enn3XAylyzJFLni7MVH6A+ab/xCK0kaCY umwc5qWYEUoZM7XwIeCxq9+/dlkbWFxw1eON7P4mYVQmAC83NzxD6QZmqkA9lR33pJqu iks/iVY71eQ3U0y7KoHfOZSCwQhuQw6AEkabI88/hC0DuGJHkD84CKY52pFswExLejD2 3yDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=6czgDvtOK84cQiH27gj58EcxjHCyIgKR400QoIHUptw=; b=R/t9CYnM8bNrPsLPtKkAPGaGVWltLw/Vz8lkP2X0lzDH47qD5Y4CFs14q65/86P9aA rp3bhyusYP8ODQrcr+xvk+gsruuf2ei0OQV10K9EZRQ5dpGWXuv68+Bo8sJNXj75kKyq zotkdZyNH6UTLIHHdKb3FD+jTWrHRxYvB3002QKiXYfp77FIiOFYU+9e7LLvAD1S88tp wXeg3gUnLaKgz0NExnnTqX4QAuygu3PX+8jnXbUSxeM1Lb/dPy9jKts5O+jHbPpOMS2J Bg9nmxRvCKfpIEA6mBwBH1QQRAylVV7arrjBNfDJvbc9TugZ+QmZgzmE1Pk5ah70L56P hX7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FHtThs6U; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p14si4569861pfi.12.2018.11.29.23.29.14; Thu, 29 Nov 2018 23:29:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FHtThs6U; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726778AbeK3Sfv (ORCPT + 99 others); Fri, 30 Nov 2018 13:35:51 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:35956 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726562AbeK3Sfv (ORCPT ); Fri, 30 Nov 2018 13:35:51 -0500 Received: by mail-pf1-f194.google.com with SMTP id b85so2370797pfc.3 for ; Thu, 29 Nov 2018 23:27:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=6czgDvtOK84cQiH27gj58EcxjHCyIgKR400QoIHUptw=; b=FHtThs6UpCZbBKJ/ExPsF7EqkZMjHKczQyqT7U7YG2kia5CN8tvZ9DzQeia6y8L3Is xovFphAWiCZGw8+odr6RdGMLHv4HYTHarYmbNJAzOKSG5oU2J7LsExWPhF2ojo5AmStP tfdGn1NChoLEn/rRn4rFN5yCyhNuCuRTqTwEM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6czgDvtOK84cQiH27gj58EcxjHCyIgKR400QoIHUptw=; b=cO52wc+9wO/bH3IjSx8JrCvDPs4D+0rXvah4x1D8i0OprGu9w4mJhWANehBOhELE24 rZyDJbhYqGHjrE51tAAusF6Dy1Hz3WBh1il6sm78L4w52gd5WZ1Vf7FfnU/JnI8fGuWa RxtTkj7zzrpL0fczAAzRZSwXEMnegbmdi7mYYh88aS8C6YOB5rAcxdrwQvGaWkWq4cAH 9rWvqe1YK2THkWJJsz57UQOsYkJzWenl0FaGmLSEg7aoajfCwbK/I8dPIxtxMRG9rsfs hHcZuKenD1ajYDKLNNClqWidKYrV6Vkhywwuf/B+qTNcDZsqamr7dWZuZE6r9UISixDI vqWQ== X-Gm-Message-State: AA+aEWZ51gbe2pFUzDAB9M24Q7tt6bLN5M+dXSOP1HtnXHzU7zkdLTUI tYckWzW0arRYrdmsn3GQCjraGQ== X-Received: by 2002:a63:4b25:: with SMTP id y37mr4076905pga.181.1543562849166; Thu, 29 Nov 2018 23:27:29 -0800 (PST) Received: from tuxbook-pro (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id b10sm8897824pfj.183.2018.11.29.23.27.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 29 Nov 2018 23:27:28 -0800 (PST) Date: Thu, 29 Nov 2018 23:27:25 -0800 From: Bjorn Andersson To: Stephen Boyd , Vivek Gautam Cc: Michael Turquette , Andy Gross , David Brown , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Marc Gonzalez , Amit Kucheria Subject: Re: [PATCH 2/3] clk: qcom: gcc-msm8998: Disable halt check of UFS clocks Message-ID: <20181130072725.GH5278@tuxbook-pro> References: <20181130065259.26497-1-bjorn.andersson@linaro.org> <20181130065259.26497-3-bjorn.andersson@linaro.org> <154356160607.88331.15203631970252933137@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <154356160607.88331.15203631970252933137@swboyd.mtv.corp.google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 29 Nov 23:06 PST 2018, Stephen Boyd wrote: > Quoting Bjorn Andersson (2018-11-29 22:52:58) > > Drop the halt check of the UFS symbol clocks, in accordance with other > > platforms. This makes clk_disable_unused() happy and makes it possible > > to turn the clocks on again without an error. > > > > Signed-off-by: Bjorn Andersson > > Someone was supposed to figure out why we needed to SKIP here instead of > doing things in the proper order. Is anyone attempting to figure that > out? > I'm not aware of any such efforts, but looping in Vivek here. I would be happy to revert this change in 8996, 8998 and 845 once such fix arrives. But as this is needed to make progress on getting UFS up on 8998 it would be nice to get it merged for now... Regards, Bjorn