Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
To:     Bjorn Andersson <bjorn.andersson@linaro.org>
From:   Stephen Boyd <sboyd@kernel.org>
In-Reply-To: <20181130072420.GG5278@tuxbook-pro>
Cc:     Michael Turquette <mturquette@baylibre.com>,
        Andy Gross <andy.gross@linaro.org>,
        David Brown <david.brown@linaro.org>,
        linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
        linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
        Marc Gonzalez <marc.w.gonzalez@free.fr>,
        Amit Kucheria <amit.kucheria@linaro.org>
References: <20181130065259.26497-1-bjorn.andersson@linaro.org>
 <20181130065259.26497-2-bjorn.andersson@linaro.org>
 <154356151361.88331.1298482384404357982@swboyd.mtv.corp.google.com>
 <20181130072420.GG5278@tuxbook-pro>
Message-ID: <154356557630.88331.15462727905875864666@swboyd.mtv.corp.google.com>
User-Agent: alot/0.7
Subject: Re: [PATCH 1/3] clk: qcom: gcc-msm8998: Mark hmss_dvm and lpass_at critical
Date:   Fri, 30 Nov 2018 00:12:56 -0800
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Bjorn Andersson (2018-11-29 23:24:20)
> On Thu 29 Nov 23:05 PST 2018, Stephen Boyd wrote:
> =

> > Quoting Bjorn Andersson (2018-11-29 22:52:57)
> > > Keep the two clocks enabled, so that the platform passes
> > > clk_disable_unused().
> > > =

> > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > > ---
> > >  drivers/clk/qcom/gcc-msm8998.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > > =

> > > diff --git a/drivers/clk/qcom/gcc-msm8998.c b/drivers/clk/qcom/gcc-ms=
m8998.c
> > > index 9f0ae403d5f5..d89f8e7c2a59 100644
> > > --- a/drivers/clk/qcom/gcc-msm8998.c
> > > +++ b/drivers/clk/qcom/gcc-msm8998.c
> > > @@ -1972,6 +1972,7 @@ static struct clk_branch gcc_hmss_dvm_bus_clk =
=3D {
> > >                 .enable_mask =3D BIT(0),
> > >                 .hw.init =3D &(struct clk_init_data){
> > >                         .name =3D "gcc_hmss_dvm_bus_clk",
> > > +                       .flags =3D CLK_IS_CRITICAL,
> > =

> > Please add a comment about why they're critical. This is a temporary
> > solution?
> > =

> =

> Disabling them in clk_disable_unused() are bad, mkay...

Ugh sad.

> =

> =

> SDM845 marks the equivalent clocks as critical with a comment that they
> must be on for system operation... I'm uncertain what the exact purpose
> of these two clocks are, so I don't have a better explanation right now.
> =


Ok. But does any driver ever want to use it? It may make more sense to
just remove it entirely and not touch it.