Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3571901imu; Fri, 30 Nov 2018 02:33:15 -0800 (PST) X-Google-Smtp-Source: AFSGD/Xj6rcGcUCaxeOcwxAULYsm+QUDiqrt28PcwBQyfSanaeSGpbLG/FyZWSZHF8W7GR4tfa4r X-Received: by 2002:a65:63d3:: with SMTP id n19mr4444261pgv.179.1543573995259; Fri, 30 Nov 2018 02:33:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543573995; cv=none; d=google.com; s=arc-20160816; b=tCiPiyZPrrDfC9FfzVS0Vj4p6Z8bHiZUrvIZn2DmrsR47o6zrM3dCr9rEPTcpzb2pH LSZrcLillwgH5+bwa/sgcR3bLLqWXOt3NDs+5HHY25my9fCXSTgJLrc6UO977cbD4oh0 bBLC8CGl9aAS5yxrag6mG+zlnA0rosjgxZ8h2y+BSWkHOP9IMaHcp8t+H3ztATaAwpn3 p5nGpzIn37VtnW2RfaX7923UG3FMEciAq51IOTL+yBYLyO83HIl+w5ykCSD2NX+cq/jl jW8S6TOLzFOdBtP+oxRwyJj/zfFxghPsPk+mFmGIfqnLmd6iN8uZ0qxIaetHunWm0WyE T2MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=RmzzgGbQnHeaaw7Va/XBi8TkEbDA2sf8YWB5qL6Kuhg=; b=uIysmG/elW//HW1LWFcMIlG/ZjeAnjn41uyWP6yHX9XTU5yBLBdQWDabDEBf0870qH Bdn657rJsq47ebF9g2fLDvfAEAJMVV/uOrwmwEnoHq1WjDL3y9I5fZ/cqEuoRZa1+NJ9 lf0h1HziBeFcJnpJ62TLRkARWFQW9RdvmtHmKyikqe73ZWkclkbkxfYkAXS3tcAMcVg4 7i45gLong1CffU4HrhjCjsqrmWoO4FA1F+uTqv6Jun5Aj4Xe1ZV2oPTca/sRQ7iaSK/s 5tfRN73TJYn4WrOuCJQ3dGtvnfAOYP1EwQbNWxa83Rq/tPlyuCQ7gNU3+v9JFXvUKUEB zk5w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i12si4668349plt.213.2018.11.30.02.33.00; Fri, 30 Nov 2018 02:33:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726582AbeK3VlO (ORCPT + 99 others); Fri, 30 Nov 2018 16:41:14 -0500 Received: from verein.lst.de ([213.95.11.211]:49455 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726507AbeK3VlO (ORCPT ); Fri, 30 Nov 2018 16:41:14 -0500 Received: by newverein.lst.de (Postfix, from userid 2407) id 964A868BDF; Fri, 30 Nov 2018 11:32:22 +0100 (CET) Date: Fri, 30 Nov 2018 11:32:22 +0100 From: Christoph Hellwig To: Rui Salvaterra Cc: hch@lst.de, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org Subject: Re: use generic DMA mapping code in powerpc V4 Message-ID: <20181130103222.GA23393@lst.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rui, can you check if the patch below fixes the issue for you? diff --git a/arch/powerpc/sysdev/dart_iommu.c b/arch/powerpc/sysdev/dart_iommu.c index 2e24fc87ed84..809797dbe169 100644 --- a/arch/powerpc/sysdev/dart_iommu.c +++ b/arch/powerpc/sysdev/dart_iommu.c @@ -392,7 +392,9 @@ static void pci_dma_dev_setup_dart(struct pci_dev *dev) static bool iommu_bypass_supported_dart(struct pci_dev *dev, u64 mask) { - return dart_is_u4 && dart_device_on_pcie(&dev->dev); + return dart_is_u4 && + dart_device_on_pcie(&dev->dev) && + mask >= DMA_BIT_MASK(40); } void __init iommu_init_early_dart(struct pci_controller_ops *controller_ops)