Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3637512imu; Fri, 30 Nov 2018 03:46:56 -0800 (PST) X-Google-Smtp-Source: AFSGD/XmbD5X7nmVNlV5a9iPTyT8JhBXeG4k8Iv1Xa91ezF2sYJjPF48Awtd1HrweiLdRSaQsc6E X-Received: by 2002:a17:902:8ec9:: with SMTP id x9mr5434928plo.27.1543578416279; Fri, 30 Nov 2018 03:46:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543578416; cv=none; d=google.com; s=arc-20160816; b=vyIy4rGoTEFIszCisYFQ7Xq7S6xB32KmMOF5Zjp2DdnfEjEWdcYB6MNq4xlno6AyYk BqvIqlAQwzt+1lz7+oz7l0gqNjnOUObHxC+4z1ZDaXd+6XEcTjeDtItuXojwZHFTkcwU 7dBz15LWD2FpSkLGppnmS9lmCWe1qDrN08zRLNnK29nEJDhzEQPjznBgeb9s1dK/q3Fu s1xET8CjlWG+IN9qZUQb7RBB2eNlYaSQL+1voDSfmEcNmSXtOj6UipIVm0NxVXJ+/Zv7 PcFzYPB5jV3kWLMrViistlDHwDkpge0K241SFKfNCBARGa7r/byyYPYgtTpYlE+faziV oT/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=NfGBLwjoprYk9UKLztyEYMY3kS/F2jQg2rNXpAjWL0c=; b=WsldW0KEhoa4waD/hyiL+Zkuj5ihV3QR0vhev2et/zYPzBH5ra9SbNhmlc4IkOcKf8 df6ExriccQaLzod12EeDpfPYLKmo9JzZtebaZeEe14i5GfME1cV4bRPPFjhZlM3Vfs1s bk+DBVx1d6Z5i8G9luRFaoMNtzZDz8ozPJatSiAhBP+oq/TmZFn8p1UUSS5dKrRAu0kJ ZBieCQjKaOFKXHq6f/YxAMDrNb1p7aZsEIsYKVdpMehUqEjajPoMwflzOQw03Ytn4tgN DBkU3Pfy7YgaUVUE5693fuE2efqZhMeaITvs1DPh0szjSYu5IA9NqxCbEea83nNDNVEM NK8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=SWxaXWCf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e1si5604505pln.55.2018.11.30.03.46.40; Fri, 30 Nov 2018 03:46:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=SWxaXWCf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726644AbeK3Wxx (ORCPT + 99 others); Fri, 30 Nov 2018 17:53:53 -0500 Received: from mail-vs1-f66.google.com ([209.85.217.66]:34735 "EHLO mail-vs1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726473AbeK3Wxx (ORCPT ); Fri, 30 Nov 2018 17:53:53 -0500 Received: by mail-vs1-f66.google.com with SMTP id y27so3158212vsi.1 for ; Fri, 30 Nov 2018 03:44:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NfGBLwjoprYk9UKLztyEYMY3kS/F2jQg2rNXpAjWL0c=; b=SWxaXWCf90RC/viOeI8KLUnANscg8zyNRAF4DNDeI2aRRhgW/bjaAVO0yYK+kPYndQ FwumgLU1JctR6jZayR4v38oyETvM7YcEKkYpKgBkXN9XeWP0OYf6rF9Xf/Rbt2fJHxAu ey/CTbzSxeUHtKVf+jJsmhuPiReBbxihRKUwz4efq+9MsxKdlsF+4Rlm0zODqNSkzp/7 1V+DKALTN5n8cixAUIDUkWI1C8I+vSdG3jQnxynTDd48uYvKYZslkzErkRih7NoE4Hnu hU9EWUSEl+o5ClYlRfE2uNWxL+MeBjnVIIMYvN9JfXwHK3IYtkk4UAosl5JcFT8dFHwH NOAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NfGBLwjoprYk9UKLztyEYMY3kS/F2jQg2rNXpAjWL0c=; b=TAmSdzHxeL5f+dMFrrCwFFaPv8YbwaZ3nFH9mEBvelPvOHPrz6PqU5hrjS6FyrgdeO mGln5fpbEqAYHbyYmAdEg8AoheZYrJ0fMOhh+cCxU+XFgLGd3GR67bp2uK1dQqUhgTZr DA/Ryuae3hov8QEVfXhcAPuGHuxwoq1w0G9hZaBc4qOk5by+v+5rZ3pSFVA7xPf8nlcE au69naHm12Fp84eL2u2grefWk3fVMicbLcOGcX7vVlSUflJBoQUU6u84tcbbwfdvfhta qLP4xwHH0MQfFHc21wkV8dh4HKMTG6o9D88WUhJyfqQqZ8cpmuSd/nsRAMzgzoaEfGAj 8swA== X-Gm-Message-State: AA+aEWb16oDigAqJ6Cy9XllfOzowiV8xWM+HpSHKRna9Aef38d3Gv2Vz Qp2rsnCk0g/y1paCjJBtCsNnMc64Twv4AkttrKe6YOFWpfTT X-Received: by 2002:a67:2a83:: with SMTP id q125mr2350849vsq.230.1543578292331; Fri, 30 Nov 2018 03:44:52 -0800 (PST) MIME-Version: 1.0 References: <20181130103222.GA23393@lst.de> In-Reply-To: <20181130103222.GA23393@lst.de> From: Rui Salvaterra Date: Fri, 30 Nov 2018 11:44:41 +0000 Message-ID: Subject: Re: use generic DMA mapping code in powerpc V4 To: hch@lst.de Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 30 Nov 2018 at 10:32, Christoph Hellwig wrote: > > Hi Rui, > > can you check if the patch below fixes the issue for you? > > diff --git a/arch/powerpc/sysdev/dart_iommu.c b/arch/powerpc/sysdev/dart_iommu.c > index 2e24fc87ed84..809797dbe169 100644 > --- a/arch/powerpc/sysdev/dart_iommu.c > +++ b/arch/powerpc/sysdev/dart_iommu.c > @@ -392,7 +392,9 @@ static void pci_dma_dev_setup_dart(struct pci_dev *dev) > > static bool iommu_bypass_supported_dart(struct pci_dev *dev, u64 mask) > { > - return dart_is_u4 && dart_device_on_pcie(&dev->dev); > + return dart_is_u4 && > + dart_device_on_pcie(&dev->dev) && > + mask >= DMA_BIT_MASK(40); > } > > void __init iommu_init_early_dart(struct pci_controller_ops *controller_ops) Hi, Christoph, Thanks for the quick response! I applied it on top of your powerpc-dma.4 branch and retested. I'm not seeing nouveau complaining anymore (I'm not using X11 or any DE, though). In any case and FWIW, this series is Tested-by: Rui Salvaterra Thanks, Rui