Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 2/3] clk: qcom: gcc-msm8998: Disable halt check of UFS
 clocks
From:   Marc Gonzalez <marc.w.gonzalez@free.fr>
To:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>
Cc:     Andy Gross <andy.gross@linaro.org>,
        David Brown <david.brown@linaro.org>,
        linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
        linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
        Amit Kucheria <amit.kucheria@linaro.org>
References: <20181130065259.26497-1-bjorn.andersson@linaro.org>
 <20181130065259.26497-3-bjorn.andersson@linaro.org>
 <273c0544-bf33-fe66-ac42-ad17ea3038d1@free.fr>
Message-ID: <e78881f5-1ea3-e828-7683-6e2a7acf5c50@free.fr>
Date:   Fri, 30 Nov 2018 14:08:38 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <273c0544-bf33-fe66-ac42-ad17ea3038d1@free.fr>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 30/11/2018 11:55, Marc Gonzalez wrote:

> On 30/11/2018 07:52, Bjorn Andersson wrote:
> 
>> Drop the halt check of the UFS symbol clocks, in accordance with other
>> platforms. This makes clk_disable_unused() happy and makes it possible
>> to turn the clocks on again without an error.
>>
>> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>> ---
>>  drivers/clk/qcom/gcc-msm8998.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/clk/qcom/gcc-msm8998.c b/drivers/clk/qcom/gcc-msm8998.c
>> index d89f8e7c2a59..3d232d266d72 100644
>> --- a/drivers/clk/qcom/gcc-msm8998.c
>> +++ b/drivers/clk/qcom/gcc-msm8998.c
>> @@ -2403,7 +2403,7 @@ static struct clk_branch gcc_ufs_phy_aux_clk = {
>>  
>>  static struct clk_branch gcc_ufs_rx_symbol_0_clk = {
>>  	.halt_reg = 0x75014,
>> -	.halt_check = BRANCH_HALT,
>> +	.halt_check = BRANCH_HALT_SKIP,
>>  	.clkr = {
>>  		.enable_reg = 0x75014,
>>  		.enable_mask = BIT(0),
>> @@ -2416,7 +2416,7 @@ static struct clk_branch gcc_ufs_rx_symbol_0_clk = {
>>  
>>  static struct clk_branch gcc_ufs_rx_symbol_1_clk = {
>>  	.halt_reg = 0x7605c,
>> -	.halt_check = BRANCH_HALT,
>> +	.halt_check = BRANCH_HALT_SKIP,
>>  	.clkr = {
>>  		.enable_reg = 0x7605c,
>>  		.enable_mask = BIT(0),
>> @@ -2429,7 +2429,7 @@ static struct clk_branch gcc_ufs_rx_symbol_1_clk = {
>>  
>>  static struct clk_branch gcc_ufs_tx_symbol_0_clk = {
>>  	.halt_reg = 0x75010,
>> -	.halt_check = BRANCH_HALT,
>> +	.halt_check = BRANCH_HALT_SKIP,
>>  	.clkr = {
>>  		.enable_reg = 0x75010,
>>  		.enable_mask = BIT(0),
> 
> FWIW, before applying your patch, the kernel printed the following
> warnings at boot:
> 
> [    1.820756] gcc_ufs_rx_symbol_1_clk status stuck at 'on'
> [    1.992977] gcc_ufs_rx_symbol_0_clk status stuck at 'on'
> [    2.165113] gcc_gpu_bimc_gfx_clk status stuck at 'on'
> 
> https://lore.kernel.org/linux-clk/f4271471-b60a-f056-b453-1cfa593a0fc4@free.fr/

As far as gcc_gpu_bimc_gfx_clk is concerned, downstream flags it as
"no_halt_check_on_disable", and sets CLKFLAG_RETAIN_MEM.

Regards.