Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2] fs: fix lost error code in dio_complete
To:     Christoph Hellwig <hch@lst.de>, Maximilian Heyne <mheyne@amazon.de>
Cc:     Torsten Mehlan <tomeh@amazon.de>, Uwe Dannowski <uwed@amazon.de>,
        Amit Shah <aams@amazon.de>,
        David Woodhouse <dwmw@amazon.co.uk>, stable@vger.kernel.org,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20181108185835.17803-1-mheyne@amazon.de>
 <83319cde-9855-d544-8079-15e028f4458f@amazon.de>
 <20181130104620.GA26765@lst.de>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <c98c7576-53d6-cfd6-8b16-3edbf4c01d50@kernel.dk>
Date:   Fri, 30 Nov 2018 08:15:20 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <20181130104620.GA26765@lst.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 11/30/18 3:46 AM, Christoph Hellwig wrote:
> Al, Jens,
> 
> can someone pick this up, please?
> 
> On Fri, Nov 30, 2018 at 10:02:22AM +0100, Maximilian Heyne wrote:
>> On 11/8/18 7:58 PM, Maximilian Heyne wrote:
>>> commit e259221763a40403d5bb232209998e8c45804ab8 ("fs: simplify the
>>> generic_write_sync prototype") reworked callers of generic_write_sync(),
>>> and ended up dropping the error return for the directio path. Prior to
>>> that commit, in dio_complete(), an error would be bubbled up the stack,
>>> but after that commit, errors passed on to dio_complete were eaten up.
>>>
>>> This was reported on the list earlier, and a fix was proposed in
>>> https://lore.kernel.org/lkml/20160921141539.GA17898@infradead.org/, but
>>> never followed up with.  We recently hit this bug in our testing where
>>> fencing io errors, which were previously erroring out with EIO, were
>>> being returned as success operations after this commit.
>> I just wanted to follow up on this. Has anyone picked up this patch?

I'll pick it up.

-- 
Jens Axboe