Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 30 Nov 2018 12:25:21 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     leo.yan@linaro.org
Cc:     Jiri Olsa <jolsa@redhat.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>, linux-kernel@vger.kernel.org,
        Daniel Thompson <daniel.thompson@linaro.org>
Subject: Re: [PATCH] perf evsel: Correct clock unit to nanosecond
Message-ID: <20181130152521.GA10748@kernel.org>
References: <1543572365-11706-1-git-send-email-leo.yan@linaro.org>
 <20181130102154.GA3617@krava>
 <20181130142140.GB11833@leoy-ThinkPad-X240s>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181130142140.GB11833@leoy-ThinkPad-X240s>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Em Fri, Nov 30, 2018 at 10:21:40PM +0800, leo.yan@linaro.org escreveu:
> On Fri, Nov 30, 2018 at 11:21:54AM +0100, Jiri Olsa wrote:
> > On Fri, Nov 30, 2018 at 06:06:05PM +0800, Leo Yan wrote:
> > > Since commit 0aa802a79469 ("perf stat: Get rid of extra clock display
> > > function"), the cpu and task clock unit has been changed from
> > > nanosecond value to millisecond value.  This introduces confusion for
> > > CPU run time statistics, we can see in below flow the clock value is
> > > scaled from nanosecond value to millisecond value; but this is
> > > contradiction with statistics type 'STAT_NSECS', which always takes
> > > clock as nanosecond unit.
> 
> [...]
> 
> > there was fix for this recently, could you please check
> > if it's working for you:
> >   6e269c85dcea perf stat: Fix shadow stats for clock events
> 
> Ah, I missed this patch ...
> 
> Yeah, I tested this patch and can confirm this patch fixes
> this issue.

My fault, new notebook update process got in the way causing
acme/perf/core to pile up, a perf/core pull req is about to be sent to
Ingo now tho :-)

- Arnaldo