Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4143022imu; Fri, 30 Nov 2018 11:47:11 -0800 (PST) X-Google-Smtp-Source: AFSGD/V8maob70uyX/y8wjeguPB7k7OVj+KqTMvHActBWz12FmxpeXMpMXgUlb1D4XeVIgcIdZhG X-Received: by 2002:a63:c141:: with SMTP id p1mr5875345pgi.424.1543607231824; Fri, 30 Nov 2018 11:47:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543607231; cv=none; d=google.com; s=arc-20160816; b=W6aTkEXnr6JJFMUKbm3YdXrLcBAZX8rx66oE4Wzzxuk9/ecfPrnh753MEoTKywqTtm SkA9wGkT6QUkQikjh4yC46F6M7eMottgp7XSW1Dsm3ZMuW2wjT3MkjHjpQNpzgQc8hBV 7BknIQpso1dQK7DS1gnsIZ8kmokx55BqT8HOJ7I6zGf7euRqy3GCLclcdEOlUpVnKkrZ 8GKtEv3DNZnGuIjBiGuOeTe4CHZVML6du1funM3LMV0dO8awR2kvHsVVNON/hLtYsgsd sWbgpdojjz17G3uxG+30EXXDF4BvMt5gPRCr5ir3OtxNQsigh7uIIHQyt9/iwrY0xkqf Eisw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=WtlTgtUilYOBKnXnQRdlG+93Y6itvwnqZXTEFM9dxfA=; b=V9WZc/6S65S8Ob7deKqPKw6+8gBGfn1G6gpgedziAm/IRxSTaQtEnGg6sj8YdapaxU JEsfVmI5u8TzkLjmnpckrf2CIvVz4AS9vDvvgN4PpuH9GL0p5auBTHPMZcqVfpyaGyEk 3ONAPvEIYLV7H3Oda+h9UPOikZZOP3N6dzlaBPQBX8gDvcdIJp3ANmR5LzsMrQ1ZDhXz 2fEeprvv2vA+j5+307ox65T+TarXnw0RZyH7FvyaRZvdLvlzgJhvtsc4uOViHyYWxHiq 2iFz9EQrjq+O8fV3//BwtLmYI1gG9RVh9n/E1whBPHRgeU/Ex9RcLLwpeTFDEzgJi6sg NpoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=FWxq6XEN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t13si5748659pga.102.2018.11.30.11.46.56; Fri, 30 Nov 2018 11:47:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=FWxq6XEN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726717AbeLAG4g (ORCPT + 99 others); Sat, 1 Dec 2018 01:56:36 -0500 Received: from mail-lf1-f65.google.com ([209.85.167.65]:33952 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725749AbeLAG4g (ORCPT ); Sat, 1 Dec 2018 01:56:36 -0500 Received: by mail-lf1-f65.google.com with SMTP id p6so4962480lfc.1 for ; Fri, 30 Nov 2018 11:46:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WtlTgtUilYOBKnXnQRdlG+93Y6itvwnqZXTEFM9dxfA=; b=FWxq6XEN1FdQQd65gUuJGXvqkihiZELIBtl9VG3CH2Vdx+YXWfw8mDm1rzQPI7sDTF sPbYlZxQEl/b/SEHlk/t68laoPCBkr9+ah1ig1xBbAWsAHBJc6ffVLNmNMh4ONPBpnkE 7rKSs1LUjQB2H3A1y9NNopUuOxUTzN216LZcM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WtlTgtUilYOBKnXnQRdlG+93Y6itvwnqZXTEFM9dxfA=; b=YNN42rd5Sl+pmvdcdp9XPMe9J+BHEzIMPCfFXxMxLB+xsYkUQe/oZIaNy22yDoTu5O SXApBVjUUeudhdGthiNS/gZdCjLYUJi0rqfsTbW4xRL8QgYoLaIkAw7R9lZEZpC/j4ha 0Yz0psQUQi5xeFGqd7O5gxFQ935mQG62CX8gxUeocWxe8bP0/O4pfkYyxIaSkRbzDoFt Ee48EBfwuA9bGKUxFJXYRZVIv7vZUYcBntS0uVHuB3dVlhqn4KmWWDyDM7JlUP30KhdD kLQXHHSFGiUFQHiXQ7q/8QRK2odKYbVI6QsYweMtfzlqZuI0vZbtM2rpyVlZggcGRldQ I86Q== X-Gm-Message-State: AA+aEWaGSpEEbfsmJD3FwMRk94mCa2nvlEhVESijRIQR0kvnWy+nEN/N 25Kppaok2uayKcAWhOjCe7tdm+2c0sY= X-Received: by 2002:a19:c995:: with SMTP id z143mr3871710lff.79.1543607172585; Fri, 30 Nov 2018 11:46:12 -0800 (PST) Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com. [209.85.167.48]) by smtp.gmail.com with ESMTPSA id k3-v6sm939197lja.8.2018.11.30.11.46.11 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Nov 2018 11:46:11 -0800 (PST) Received: by mail-lf1-f48.google.com with SMTP id p6so4962399lfc.1 for ; Fri, 30 Nov 2018 11:46:11 -0800 (PST) X-Received: by 2002:a19:982:: with SMTP id 124mr4282052lfj.138.1543607170629; Fri, 30 Nov 2018 11:46:10 -0800 (PST) MIME-Version: 1.0 References: <20181129124404.2fe55dd0@gandalf.local.home> <20181129125857.75c55b96@gandalf.local.home> <20181129134725.6d86ade6@gandalf.local.home> <20181129202452.56f4j2wdct6qbaqo@treble> <20181130183917.hxmti5josgq4clti@treble> In-Reply-To: <20181130183917.hxmti5josgq4clti@treble> From: Linus Torvalds Date: Fri, 30 Nov 2018 11:45:53 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 4/4] x86/static_call: Add inline static call implementation for x86-64 To: Josh Poimboeuf Cc: Andrew Lutomirski , Steven Rostedt , Peter Zijlstra , "the arch/x86 maintainers" , Linux List Kernel Mailing , Ard Biesheuvel , Ingo Molnar , Thomas Gleixner , mhiramat@kernel.org, jbaron@akamai.com, Jiri Kosina , David.Laight@aculab.com, bp@alien8.de, julia@ni.com, jeyu@kernel.org, Peter Anvin Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 30, 2018 at 10:39 AM Josh Poimboeuf wrote: > > AFAICT, all the other proposed options seem to have major issues. I still absolutely detest this patch, and in fact it got worse from the test of the config variable. Honestly, the entry code being legible and simple is more important than the extra cycle from branching to a trampoline for static calls. Just don't do the inline case if it causes this much confusion. Linus