Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4198544imu; Fri, 30 Nov 2018 12:44:28 -0800 (PST) X-Google-Smtp-Source: AFSGD/U20LO8q34zyqagP4ZiHl7u1cc4D3fRmruhVZDkOF6UJuD/bbyxpZAI5GkYRGq+W0Vc5QCB X-Received: by 2002:a63:c503:: with SMTP id f3mr5844976pgd.431.1543610668710; Fri, 30 Nov 2018 12:44:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543610668; cv=none; d=google.com; s=arc-20160816; b=glkrAAWPHyKGnmSVCaPv9OunJxe7JFhQ2X6NAY0USZQ3ZsuEMCLPCTETz5uOLFxvoP NQhDQYPFDS97mYzYBT0+D7jGNi4umiwsMRm2/KFG3y4jjUOPkR8iC3PGzh64elLlxkbS t5PtomezJF2HGtBgW0mYgNzjcS3BYtsjfEb6Bcts4QTObv0tXpv2oxbxbvpVNFq3sRqV 8C9nZ+iZybVJpHKdYgPL0azHwuVd7u+HFr7UMDZHAvGrUgtyFB66Ujeated1AMxUsIG3 HtW+xz6kW8GHycOGGcnMSaLhew3QCWj3Uya2xOnTSEir/ioxDPCE1Cg0ZH9WiKM9CgvW +Lsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=nqcGNH+R8mwv39my4VM1ziCIPR3pHCOXDzV15pwb1ms=; b=VHDsuMvD5ixDfjNAT+oy3soZ7DAWjmrllm4t6fjFEkgCxZ3GGRUv0U5uHQzimLkSSi NhxpEzBySGw51k3Zxxz3AKgvUBh3yScTuw+4yoIyH76F18dVk5qXTzkQkhV/1KEkCtH6 XKngl4dkIbCm7Fy07nakMRfuRxsU/HO6ZQzFhbQ2D/jpy2fL84Pb5zgzo/F+i0Tuhtrq 3w9Qex/NOMRQ6UTTRzuyDNae6Tjq+O6InWUUs79GGtEt9GTx6ujxmgRGi094Qw1vK6HV MwN5xFyygBdzX35EJavulj6Czbp4Jt/2mwkFEvUR1UM/4jvSJNMciNa6qTm01FEGs3ck flmA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=iki.fi Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h3si6501178pll.116.2018.11.30.12.44.14; Fri, 30 Nov 2018 12:44:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=iki.fi Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726691AbeLAHwr (ORCPT + 99 others); Sat, 1 Dec 2018 02:52:47 -0500 Received: from emh02.mail.saunalahti.fi ([62.142.5.108]:33826 "EHLO emh02.mail.saunalahti.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726637AbeLAHwr (ORCPT ); Sat, 1 Dec 2018 02:52:47 -0500 Received: from darkstar.musicnaut.iki.fi (85-76-84-209-nat.elisa-mobile.fi [85.76.84.209]) by emh02.mail.saunalahti.fi (Postfix) with ESMTP id DF0F020065; Fri, 30 Nov 2018 22:42:14 +0200 (EET) Date: Fri, 30 Nov 2018 22:42:14 +0200 From: Aaro Koskinen To: Kees Cook Cc: LKML , Jarkko Sakkinen Subject: Re: Fwd: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3 Message-ID: <20181130204214.GA2287@darkstar.musicnaut.iki.fi> References: <20181130192737.15053-1-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 30, 2018 at 11:48:24AM -0800, Kees Cook wrote: > Better yet, since it's only 17 files, how about doing context-specific > changes? "This API is terrible" I think we should only use "good" with selected operators like !, ++, -- E.g. "This API is !good++" Suggested-by: George Orwell A.