Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263836AbUAPAp5 (ORCPT ); Thu, 15 Jan 2004 19:45:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263891AbUAPAp5 (ORCPT ); Thu, 15 Jan 2004 19:45:57 -0500 Received: from omega.webmasters.gr.jp ([218.44.239.78]:46991 "EHLO webmasters.gr.jp") by vger.kernel.org with ESMTP id S263836AbUAPApz (ORCPT ); Thu, 15 Jan 2004 19:45:55 -0500 Date: Fri, 16 Jan 2004 09:45:47 +0900 Message-ID: <817jzsd8lg.wl@omega.webmasters.gr.jp> From: GOTO Masanori To: arjanv@redhat.com Cc: Steve Youngs , Linux Kernel List Subject: Re: [PATCH] Increase recursive symlink limit from 5 to 8 In-Reply-To: <1073814570.4431.3.camel@laptop.fenrus.com> References: <2flllofnvp6.fsf@saruman.uio.no> <1073814570.4431.3.camel@laptop.fenrus.com> User-Agent: Wanderlust/2.9.9 (Unchained Melody) SEMI/1.14.3 (Ushinoya) FLIM/1.14.3 (=?ISO-8859-4?Q?Unebigory=F2mae?=) APEL/10.3 Emacs/21.2 (i386-debian-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1134 Lines: 30 At Sun, 11 Jan 2004 10:49:30 +0100, Arjan van de Ven wrote: > > 6 does seem pretty low. What was the reason for setting it there? Is > > there a downside to increasing it? > > It was reduced down from 8 because it can lead to stack overflows. > Recursive links like this usually point at a quite broken filesystem > setup too afaik. But I still think 6 is too small from user level point of view, as Petter wrote. The example is /usr/lib library links. I got bug report which complained that a library want to use "bounce" link: /usr/lib/liba -> /etc/alternatives/liba -> /usr/lib/another/libb. If .so file uses major.minor scheme, then /usr/lib/liba.so links: /usr/lib/liba.so -> /usr/lib/liba.so.2 -> /usr/lib/liba.so.2.3 and so on. It can easily exceed 6 symlinks. I think the correct fix is to make VFS not to overflow stacks. Is it allowable change? Regards, -- gotom - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/