Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4406010imu; Fri, 30 Nov 2018 16:59:36 -0800 (PST) X-Google-Smtp-Source: AFSGD/VU5+4nVfc4Auyarj1eg5C92Y9yvFctBwdDY7kTyqzu5z90Lc5KLh5KpGb0Dxa3uauKY890 X-Received: by 2002:a62:5e41:: with SMTP id s62mr7601652pfb.232.1543625976521; Fri, 30 Nov 2018 16:59:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543625976; cv=none; d=google.com; s=arc-20160816; b=IKgzif4sdWR8GU1pAxBfIdUa3yOsHWzRToJ5mg/lfajulGmOnisCyYyJXLRqUGt8Bj CI6gD0yUavlFt+Bb5re2AgZMlPBuU2g1VGdyBKOYpISLgZ+gU4zKwnEBIYpbcm/ehAUz jqax6KpQJdqgLcdKlB0g5Sqzc0qrwR1MJPHjjosxtgvrgRDA1TuAPZ1FIXpiCuyQ9Wz8 BOfADOLfMqmRaJJBlyy8Kfp7r5QWUXxpIaVJGX1Ru3VoaYhs8jnlyD751rFw3R2nOYok 8stMBO6umwAwexmjbMtvuy8V/K2bQnfoItprEekdBJTAUs+p2uKO3a6tD1KdSaF3DSxp gD8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=LT6CvLoSlo5lGUAHi6CGKYOrMAPZDBcoszEEjAEVWXs=; b=0sXoXd+tSE3dMJZxU3gmoIX21mOm0aZ4wuqWijJbOnnSvhjpkoWmO1TI+Bo6u5/+tK fcLd2EE3+Bax4kYid3myRcOxwRFUu0sOF7e5/V4lgC+IrvyeOk5l15B1hXKMa1NlTsJx Ng1W5Eg87GaxkoUxPktKadYoN538tKb9t7pvQmwOcO4d/25Bg5Q204HSZhuW3LYX93+E CqjYlLQor9m+z9wa0UJ6L+HnEherdpAd+ldZaAtGeDvFCL7L1krPF6dN3fccUX3Tlrw5 mwOMg73ygQuzljCPVlT6CEY17ox4rI4PmCskWdmHD3zXzPQJbeLqq1M/FD50RU2gqYL+ YfSg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 207si7205562pfz.249.2018.11.30.16.59.21; Fri, 30 Nov 2018 16:59:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726850AbeLAMJc (ORCPT + 99 others); Sat, 1 Dec 2018 07:09:32 -0500 Received: from anholt.net ([50.246.234.109]:42758 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726666AbeLAMJR (ORCPT ); Sat, 1 Dec 2018 07:09:17 -0500 Received: from localhost (localhost [127.0.0.1]) by anholt.net (Postfix) with ESMTP id CE7B910A1570; Fri, 30 Nov 2018 16:58:04 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at anholt.net Received: from anholt.net ([127.0.0.1]) by localhost (kingsolver.anholt.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Gf_0sOPTBtFc; Fri, 30 Nov 2018 16:58:03 -0800 (PST) Received: from eliezer.anholt.net (localhost [127.0.0.1]) by anholt.net (Postfix) with ESMTP id 6E8AA10A1218; Fri, 30 Nov 2018 16:58:00 -0800 (PST) Received: by eliezer.anholt.net (Postfix, from userid 1000) id 626372FE2D16; Fri, 30 Nov 2018 16:57:59 -0800 (PST) From: Eric Anholt To: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, Dave Emett , Thomas Spurden , Eric Anholt Subject: [PATCH 2/6] drm/v3d: Drop unused v3d_flush_caches(). Date: Fri, 30 Nov 2018 16:57:55 -0800 Message-Id: <20181201005759.28093-2-eric@anholt.net> X-Mailer: git-send-email 2.20.0.rc1 In-Reply-To: <20181201005759.28093-1-eric@anholt.net> References: <20181201005759.28093-1-eric@anholt.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Now that I've specified how the end-of-pipeline flushing should work, we're never going to use this function. Signed-off-by: Eric Anholt --- drivers/gpu/drm/v3d/v3d_drv.h | 1 - drivers/gpu/drm/v3d/v3d_gem.c | 21 --------------------- 2 files changed, 22 deletions(-) diff --git a/drivers/gpu/drm/v3d/v3d_drv.h b/drivers/gpu/drm/v3d/v3d_drv.h index bcd3d567bec2..239b56d76f3e 100644 --- a/drivers/gpu/drm/v3d/v3d_drv.h +++ b/drivers/gpu/drm/v3d/v3d_drv.h @@ -314,7 +314,6 @@ void v3d_exec_put(struct v3d_exec_info *exec); void v3d_tfu_job_put(struct v3d_tfu_job *exec); void v3d_reset(struct v3d_dev *v3d); void v3d_invalidate_caches(struct v3d_dev *v3d); -void v3d_flush_caches(struct v3d_dev *v3d); /* v3d_irq.c */ void v3d_irq_init(struct v3d_dev *v3d); diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c index 8b4af512450f..34103205b7cb 100644 --- a/drivers/gpu/drm/v3d/v3d_gem.c +++ b/drivers/gpu/drm/v3d/v3d_gem.c @@ -175,20 +175,6 @@ v3d_invalidate_slices(struct v3d_dev *v3d, int core) V3D_SET_FIELD(0xf, V3D_SLCACTL_ICC)); } -/* Invalidates texture L2 cachelines */ -static void -v3d_invalidate_l2t(struct v3d_dev *v3d, int core) -{ - V3D_CORE_WRITE(core, - V3D_CTL_L2TCACTL, - V3D_L2TCACTL_L2TFLS | - V3D_SET_FIELD(V3D_L2TCACTL_FLM_CLEAR, V3D_L2TCACTL_FLM)); - if (wait_for(!(V3D_CORE_READ(core, V3D_CTL_L2TCACTL) & - V3D_L2TCACTL_L2TFLS), 100)) { - DRM_ERROR("Timeout waiting for L2T invalidate\n"); - } -} - void v3d_invalidate_caches(struct v3d_dev *v3d) { @@ -199,13 +185,6 @@ v3d_invalidate_caches(struct v3d_dev *v3d) v3d_flush_l2t(v3d, 0); } -void -v3d_flush_caches(struct v3d_dev *v3d) -{ - v3d_invalidate_l1td(v3d, 0); - v3d_invalidate_l2t(v3d, 0); -} - static void v3d_attach_object_fences(struct v3d_bo **bos, int bo_count, struct dma_fence *fence) -- 2.20.0.rc1