Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4424423imu; Fri, 30 Nov 2018 17:21:46 -0800 (PST) X-Google-Smtp-Source: AFSGD/VqStjVu8VhVZbT1ZN8rfshgA1D9yc6GoMUuWFAA57yLOdzwepXBlpMv4zSNccRfXFNzlad X-Received: by 2002:a62:18ce:: with SMTP id 197mr8050109pfy.88.1543627306367; Fri, 30 Nov 2018 17:21:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543627306; cv=none; d=google.com; s=arc-20160816; b=aeFyfiGiRjtozHK0miUp26+jNO/OjfXlxzKwhwuU1/WY+tcFrQdk2LgTJpC3V3amMt YhwocTu0lndV66PglNPTvq3pOUBjoSN5pVZdLEioEdq2w4qTwkF36WCFvTq3uUqseBwl KM1lo1Vdfh9xsrqCCQLGB1mKIbVeuJQPWWnSUOAgHnG7q5XwH+5Y9zKYkOoi5+UeGpEs xHwiTIUoRMzvo8svxtwRg8aXeG13sy/0tXJUM5XABPZfzix1BZmFtEhSalJPMa+mb8bh 987Ggm1F8MwIzUkfeJnotYBmcZLOeETiLecfPRqWYEFqCY2UknjiiKHaQBVoM+QL1A8L Dd5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:from:cc:to:subject :content-transfer-encoding:mime-version:references:in-reply-to :user-agent:date:dkim-signature; bh=scHL1AO23eV3cOMIfNsYXeoYriec7TVDVgXopqvkICk=; b=Ga2PY2ms5mRA/osSZak0+/bPeXixpgYZGkVN5UB8m14Ybr9SyxAeztgMO8+mNZ3LYl KCWQRIAvdQ9fRyzLmkp2jMtc4/aIgmkCIRiHfht+to2OMZuTnmkIijBCTkYCkrM8skvL zmyVxTSzDTHSNCWPMwVcgisFXJ0rBlceDdbjdoQdH/Ljr+Dm2TyhTQh6WeQwYfrVOrxk mlzuurr1/DCTp52qBtvlIuCm8H1nB75G0bPSh0p2wCm7z0woPoGjrKumlGEdX9HomSv+ 8OGiZ2iSH5u3uEIRUkpooFrYSdTKX6gvhyzem3orTvUPSCEtmMMPHHEiJtOekGpw2W09 jqyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@brauner.io header.s=google header.b=XT81wwMm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x1si7046695plb.366.2018.11.30.17.21.31; Fri, 30 Nov 2018 17:21:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@brauner.io header.s=google header.b=XT81wwMm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726717AbeLAMcD (ORCPT + 99 others); Sat, 1 Dec 2018 07:32:03 -0500 Received: from mail-io1-f65.google.com ([209.85.166.65]:37079 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726651AbeLAMcC (ORCPT ); Sat, 1 Dec 2018 07:32:02 -0500 Received: by mail-io1-f65.google.com with SMTP id f14so581227iol.4 for ; Fri, 30 Nov 2018 17:20:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brauner.io; s=google; h=date:user-agent:in-reply-to:references:mime-version :content-transfer-encoding:subject:to:cc:from:message-id; bh=scHL1AO23eV3cOMIfNsYXeoYriec7TVDVgXopqvkICk=; b=XT81wwMmm841FMp5UDixE4o3A/6pxCFEPPBs0fec52yBBQugYvNpUPBkyyc1p2fhnf Q1KjAzKaNm/ziMsRNwQ64q3tz+0O7hO6uef475DBGuf3vQ4h7epp9qQVQWeX0Eepdh7x 5TTs9RZ2Su5tDsScwwPIaX0pZlBCASGVcxzjXSin6MqzaU+AOEfchSir3snBPqIhcKO/ NXvyXO77BSUuUKytTnnb1KjdaHSY4JVAfibTOrMK+y53ISvbu/C9vUPvceojYO4wIQMr DF8lXaUWA56LDgRE8Uc2h1b+8mT/nrkVaAQCDLjucKwDabynip/69EGkxU9mTEG5obmb F7Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:user-agent:in-reply-to:references :mime-version:content-transfer-encoding:subject:to:cc:from :message-id; bh=scHL1AO23eV3cOMIfNsYXeoYriec7TVDVgXopqvkICk=; b=RVBRzcdzedmMT5EgjdXgdtfDmcYIIiPb2XWg9a2ywpuxEdHcuPQzL/5TKBJhQXLKwe he0k433TAVIk1ZRKzQd14CilQakDR0A83FPEjqu9dKSFFNEdBwwAFsCys5k/kf5aKnfs RaI5gciIhXKkn5ott6YzcaqJRnWOQi81pKcS7s88BPNzRbujgs7nvNDwFIBLATiRINI/ d0wpvrDrrQAU4U01UbQUq7YmAip3PyhBv3e/LVNX5MikStkaCMaW51VZGMoFbyAbvrb3 vfm7EgbFFp/9qUJ7+9DJN5aKzGB6oLG3znUUXiU9QgBem30Oukv6RIFfZMaut0tIDJQ+ bNpg== X-Gm-Message-State: AA+aEWax5ns4OazYcSH/013p9X1//3Q5mXouBhUBbcz3obi3n0u8cueR tXmiJegjw7fXLApcKdcOrW5OKA== X-Received: by 2002:a5d:9855:: with SMTP id p21mr6723429ios.64.1543627246988; Fri, 30 Nov 2018 17:20:46 -0800 (PST) Received: from [26.67.58.27] ([172.56.12.18]) by smtp.gmail.com with ESMTPSA id a10sm427617itc.3.2018.11.30.17.20.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Nov 2018 17:20:45 -0800 (PST) Date: Sat, 01 Dec 2018 14:20:37 +1300 User-Agent: K-9 Mail for Android In-Reply-To: References: <20181120105124.14733-1-christian@brauner.io> <36323361-90BD-41AF-AB5B-EE0D7BA02C21@amacapital.net> <993B98AC-51DF-4131-AF7F-7DA2A7F485F1@brauner.io> <20181129195551.woe2bl3z3yaysqb6@brauner.io> <6E21165F-2C76-4877-ABD9-0C86D55FD6AA@amacapital.net> <87y39b2lm2.fsf@xmission.com> <20181130065606.kmilbbq46oeycjp5@brauner.io> <7C5B4CBD-6364-4DCE-9EFD-3657C67DACEB@brauner.io> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v2] signal: add procfd_signal() syscall To: Andy Lutomirski CC: Arnd Bergmann , Daniel Colascione , Andrew Lutomirski , "Eric W. Biederman" , Florian Weimer , LKML , "Serge E. Hallyn" , Jann Horn , Andrew Morton , Oleg Nesterov , Aleksa Sarai , Al Viro , Linux FS Devel , Linux API , Tim Murray , linux-man , Kees Cook From: Christian Brauner Message-ID: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On December 1, 2018 12:46:22 PM GMT+13:00, Andy Lutomirski wrote: >On Fri, Nov 30, 2018 at 3:40 PM Christian Brauner > wrote: >> >> On December 1, 2018 12:12:53 PM GMT+13:00, Arnd Bergmann > wrote: >> >On Sat, Dec 1, 2018 at 12:05 AM Daniel Colascione > >> >wrote: >> >> On Fri, Nov 30, 2018 at 2:26 PM Christian Brauner >> > wrote: >> >> > On December 1, 2018 11:09:58 AM GMT+13:00, Arnd Bergmann >> > wrote: >> >> > >> >> > One humble point I would like to make is that what I care about >> >most is a sensible way forward without having to redo essential >parts >> >of how syscalls work=2E >> >> > I don't want to introduce a sane, small syscall that ends up >> >breaking all over the place because we decided to fix past mistakes >> >that technically have nothing to do with the patch itself=2E >> >> > However, I do sympathize and understand these concerns=2E >> >> >> >> IMHO, it's fine to just replicate all the splits we have for the >> >> existing signal system calls=2E It's ugly, but once it's done, it'll >be >> >> done for a long time=2E I can't see a need to add even more signal >> >> system calls after this one=2E >> > >> >We definitely need waitid_time64() and rt_sigtimedwait_time64() >> >in the very near future=2E >> >> Right, I remember you pointing this out in a prior mail=2E >> Thanks for working on this for such a long time now, Arnd! >> Can we agree to move on with the procfd syscall given the current >constraints? >> I just don't want to see the syscall being >> blocked by a generic problem whose >> ultimate solution is to get rid of weird >> architectural constraints=2E > >Creating and using a copy_siginfo_from_user64() function would work >for everyone, no? Meaning, no compat syscalls, introduce=20 new struct siginfo64_t and the copy=20 function you named above?